Create KeyVault.json #6975

jlichwa · 2019-08-15T23:08:43Z

Event definitions for Key Vault Certificates, Keys and Secrets - NewVersion, Near Expiry and Expired

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

Event definitions for Key Vault Certificates, Keys and Secrets - NewVersion, Near Expiry and Expired

openapi-sdkautomation · 2019-08-15T23:08:46Z

In Testing, Please Ignore

[Logs] (Generated from 44674ab, Iteration 12)

Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]

eventgrid/2018-01-01 [Logs]

Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]

azure-eventgrid [Logs] [Instructions] [Generation PR] [Integration PR]
- azure-eventgrid-1.3.0.zip
- azure_eventgrid-1.3.0-py2.py3-none-any.whl

JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]

@azure/eventgrid [Logs] [Instructions]
- azure-eventgrid-1.5.0.tgz

Ruby: test-repo-billy/azure-sdk-for-ruby [Logs] [Diff]

No packages generated.

AutorestCI · 2019-08-15T23:09:59Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#6818

azuresdkci · 2019-08-15T23:10:15Z

Can one of the admins verify this patch?

AutorestCI · 2019-08-15T23:11:40Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5701

Change topic to vaultname

mmyyrroonn · 2019-08-16T01:48:11Z

@jlichwa Hello. Why do we have this PR? I don't see any path referring these definitions. We cannot pass the Avocado's check.

specification/eventgrid/data-plane/Microsoft.KeyVault/stable/2018-01-01/KeyVault.json

kalyanaj

For consistency with the rest of the files under EventGrid dataplane, please consider removing the additional line spacing used in this file.

kalyanaj

For each definition name such as CertificateNewVersionCreated, KeyNearExpiry etc. since all the definitions share the same namespace Microsoft.EventGrid.Models, please add the KeyVault prefix, as an example, please rename CertificateNewVersionCreated to KeyVaultCertificateNewVersionCreated. This will help with better discoverability of all KeyVault specific event definitions. Also, typically, we use the "EventData" suffix for such event definitions (e.g. StorageBlobCreatedEventData), so please consider adding EventData suffix as well to each definition name. (for example "CertificateNewVersionCreated" would become KeyVaultCertificateNewVersionCreatedEventData.).

Remove empty lines

This reverts commit 66c7615.

jlichwa · 2019-08-22T18:23:15Z

Updated names KeyVault prefix and Event Data Suffix

mmyyrroonn · 2019-08-26T01:29:39Z

@jlichwa Can I assume that this PR is in progress and there will be another team working on the API paths later?

jlichwa · 2019-08-26T03:05:34Z

Yes my team adding schema definition only. Eventgrid team - @j. Kalyana Sundaram<mailto:[email protected]>, would work on API after it is merged. Jack Lichwa Get Outlook for Android<https://aka.ms/ghei36>

…

________________________________ From: MyronFanQiu <[email protected]> Sent: Sunday, August 25, 2019, 6:30 PM To: Azure/azure-rest-api-specs Cc: Jack Lichwa; Mention Subject: Re: [Azure/azure-rest-api-specs] Create KeyVault.json (#6975) @jlichwa<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.amrom.workers.dev%2Fjlichwa&data=02%7C01%7CJack.Lichwa%40microsoft.com%7Ca6c1339108ff4c61837808d729c4ec55%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637023798062845083&sdata=KJt5am6T0bIgu%2BwBZN4yk94kc3pgSZTTTAXJ6NUrxB8%3D&reserved=0> Can I assume that this PR is in progress and there will be another team working on the API paths later? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.amrom.workers.dev%2FAzure%2Fazure-rest-api-specs%2Fpull%2F6975%3Femail_source%3Dnotifications%26email_token%3DAMQULS2A3SS3WLAN4PNEZE3QGMWZZA5CNFSM4IMCS3W2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5DAWAY%23issuecomment-524684035&data=02%7C01%7CJack.Lichwa%40microsoft.com%7Ca6c1339108ff4c61837808d729c4ec55%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637023798062845083&sdata=3pKPNk10tFJlEU%2BxSd4SvjF%2BlAfyabzMVKlec5zNH0I%3D&reserved=0>, or mute the thread<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.amrom.workers.dev%2Fnotifications%2Funsubscribe-auth%2FAMQULS7U5KWZTUAROQE76HTQGMWZZANCNFSM4IMCS3WQ&data=02%7C01%7CJack.Lichwa%40microsoft.com%7Ca6c1339108ff4c61837808d729c4ec55%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637023798062855080&sdata=GrM7ZvOlH6cfNSSDQpU3zVIjEEEBbOs45CRXm3JfUZQ%3D&reserved=0>.

jlichwa · 2019-08-27T23:31:39Z

For consistency with the rest of the files under EventGrid dataplane, please consider removing the additional line spacing used in this file.

Done

jlichwa · 2019-08-28T23:14:29Z

@myronfanqiu Can we Merge based on comments? @kalyanaj

mmyyrroonn · 2019-08-29T01:55:55Z

@jlichwa I still don't understand the purpose of this PR. Who will use these definitions?

jlichwa · 2019-08-29T17:10:59Z

@jlichwa I still don't understand the purpose of this PR. Who will use these definitions?

It is for EventGridTeam( @kalyanaj ) as part of their OnBoarding process for new events schema. Based on that schema they will build API (they cannot do it without it) and once it is ready for Public Preview, it will be added to Readme.md as a part of API to customers.
My understanding is just more about Teams separation, EventGrid customers, provide the schema to EventGrid dev team (which is that json file I added) and based on that EventGrid team build API and enable that events schema definitions to public - so 2 teams contribute to the entire feature.

kalyanaj · 2019-08-29T21:22:13Z

@myronfanqiu, please see my comment earlier in this PR (#6975 (comment)) for more context on how these definitions will be used. (FYI: @jlichwa).

kalyanaj

LGTM.

sarangan12 · 2019-08-30T17:21:33Z

@jilchwa One comment. You have created a new JSON file in this PR. But this file is never included in the readme.md file. So, no tests will be run on this file unless you actually include it. I believe the failed tests are really unrelated to your file. (which is a seperate discussion). But, first please include the file reference in the readme file.

mmyyrroonn · 2019-08-31T01:40:12Z

Remove the label WatiforArmFeedback since it's related with data-plane

mmyyrroonn · 2019-09-04T02:35:46Z

@jlichwa Hello. Resolve the CI and I can merge this PR.

Create KeyVault.json

c776345

Event definitions for Key Vault Certificates, Keys and Secrets - NewVersion, Near Expiry and Expired

jlichwa requested a review from kalyanaj as a code owner August 15, 2019 23:08

azuresdkci assigned mmyyrroonn Aug 15, 2019

azuresdkci requested a review from mmyyrroonn August 15, 2019 23:10

jlichwa added 2 commits August 15, 2019 16:45

Update KeyVault.json

dbc6d94

Update KeyVault.json

ffebdaf

Change topic to vaultname

PhoenixHe-NV mentioned this pull request Aug 16, 2019

[Mirror] Create KeyVault.json test-repo-tih/azure-rest-api-specs#90

Closed

Update readme with KeyVault.json

66c7615

This was referenced Aug 16, 2019

[AutoPR eventgrid/data-plane] Create KeyVault.json Azure/azure-sdk-for-python#6817

Merged

[AutoPR eventgrid/data-plane] Create KeyVault.json Azure/azure-sdk-for-go#5546

Merged

mmyyrroonn approved these changes Aug 19, 2019

View reviewed changes

specification/eventgrid/data-plane/Microsoft.KeyVault/stable/2018-01-01/KeyVault.json Outdated Show resolved Hide resolved

specification/eventgrid/data-plane/Microsoft.KeyVault/stable/2018-01-01/KeyVault.json Show resolved Hide resolved

Update KeyVault.json

49e8d1d

Kishp01 approved these changes Aug 20, 2019

View reviewed changes

kalyanaj reviewed Aug 21, 2019

View reviewed changes

kalyanaj requested changes Aug 21, 2019

View reviewed changes

jlichwa and others added 3 commits August 21, 2019 12:21

Update KeyVault.json

1370afe

Remove empty lines

Revert "Update readme with KeyVault.json"

7d4a251

This reverts commit 66c7615.

Add prefix and suffix to definitions

dbd0549

jlichwa closed this Aug 28, 2019

jlichwa reopened this Aug 28, 2019

kalyanaj approved these changes Aug 29, 2019

View reviewed changes

mmyyrroonn added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 30, 2019

mmyyrroonn removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 31, 2019

Update readme.md

44674ab

mmyyrroonn approved these changes Sep 5, 2019

View reviewed changes

yungezz merged commit 36db3ff into Azure:master Sep 5, 2019

Create KeyVault.json #6975

Create KeyVault.json #6975

Uh oh!

Conversation

jlichwa commented Aug 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

openapi-sdkautomation bot commented Aug 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

In Testing, Please Ignore

[Logs] (Generated from 44674ab, Iteration 12)

Uh oh!

AutorestCI commented Aug 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

azuresdkci commented Aug 15, 2019

Uh oh!

AutorestCI commented Aug 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

mmyyrroonn commented Aug 16, 2019

Uh oh!

Uh oh!

Uh oh!

kalyanaj left a comment

Choose a reason for hiding this comment

Uh oh!

kalyanaj left a comment

Choose a reason for hiding this comment

Uh oh!

jlichwa commented Aug 22, 2019

Uh oh!

mmyyrroonn commented Aug 26, 2019

Uh oh!

jlichwa commented Aug 26, 2019 via email

Uh oh!

jlichwa commented Aug 27, 2019

Uh oh!

jlichwa commented Aug 28, 2019

Uh oh!

mmyyrroonn commented Aug 29, 2019

Uh oh!

jlichwa commented Aug 29, 2019

Uh oh!

kalyanaj commented Aug 29, 2019

Uh oh!

kalyanaj left a comment

Choose a reason for hiding this comment

Uh oh!

sarangan12 commented Aug 30, 2019

Uh oh!

mmyyrroonn commented Aug 31, 2019

Uh oh!

mmyyrroonn commented Sep 4, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

jlichwa commented Aug 15, 2019 •

edited

Loading

openapi-sdkautomation bot commented Aug 15, 2019 •

edited

Loading

AutorestCI commented Aug 15, 2019 •

edited

Loading

AutorestCI commented Aug 15, 2019 •

edited

Loading