Skip to content

Conversation

@linmeng08
Copy link
Contributor

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@linmeng08 linmeng08 requested a review from samedder as a code owner August 31, 2019 00:01
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 31, 2019

In Testing, Please Ignore

[Logs] (Generated from 29bedf6, Iteration 1)

Succeeded .NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]
Succeeded Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
Failed Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]
Warning Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
  • Warning preview/servicefabric/mgmt/2017-07-01-preview [Logs]
  • Warning preview/servicefabric/mgmt/2019-03-01-preview [Logs]
  • Warning servicefabric/mgmt/2016-09-01 [Logs]
  • Warning servicefabric/mgmt/2018-02-01 [Logs]
  • Warning servicefabric/mgmt/2019-03-01 [Logs]
Succeeded Ruby: test-repo-billy/azure-sdk-for-ruby [Logs] [Diff]

@AutorestCI
Copy link

AutorestCI commented Aug 31, 2019

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#7686

@AutorestCI
Copy link

AutorestCI commented Aug 31, 2019

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@linmeng08
Copy link
Contributor Author

Hi @sarangan12, @samedder - can any of you please take a look at this PR?

@a-santamaria a-santamaria added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 16, 2019
Copy link
Contributor

@KrisBash KrisBash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM

@@ -0,0 +1,1538 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For new API versions, we much prefer that the first commit be an unchanged copy of the last reviewed API version. Then subsequent commits can reflect the necessary changes. This facilitates simpler review of the changes in GH.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see - thanks, that makes a lot of senses. We will update the doc on our end to add this step for any new API changes going forward.

@KrisBash KrisBash added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 26, 2019
@yungezz
Copy link
Member

yungezz commented Oct 8, 2019

@yungezz
Copy link
Member

yungezz commented Oct 8, 2019

hi @linmeng08 is this PR ready to merge?

@linmeng08
Copy link
Contributor Author

hi @linmeng08 is this PR ready to merge?

Yes please proceed, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants