-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Add 2019-06-01-preview API version for Service Fabric #7092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
In Testing, Please Ignore[Logs] (Generated from 29bedf6, Iteration 1)
|
Automation for azure-sdk-for-pythonA PR has been created for you based on this PR content. Once this PR will be merged, content will be added to your service PR: |
Automation for azure-sdk-for-goNothing to generate for azure-sdk-for-go |
|
Can one of the admins verify this patch? |
|
Hi @sarangan12, @samedder - can any of you please take a look at this PR? |
KrisBash
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM
| @@ -0,0 +1,1538 @@ | |||
| { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For new API versions, we much prefer that the first commit be an unchanged copy of the last reviewed API version. Then subsequent commits can reflect the necessary changes. This facilitates simpler review of the changes in GH.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see - thanks, that makes a lot of senses. We will update the doc on our end to add this step for any new API changes going forward.
|
CI passed in Azure Pipeline https://github.com/Azure/azure-rest-api-specs/pull/7092/checks?check_run_id=208525848. |
|
hi @linmeng08 is this PR ready to merge? |
Yes please proceed, thank you! |
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.