Skip to content

Conversation

@hkuadithya
Copy link
Contributor

@hkuadithya hkuadithya commented Sep 10, 2019

For releasing ScopeMap and Token features, we need to retrieve models from the scopemap spec file.
The existing SDK version doesn't incorporate changes from the scopemap spec file.

Requesting a new SDK build with new scopemap spec.
Please suggest changes if deemed necessary.

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

For releasing ScopeMap and Token features, we need to retrieve models from the scopemap spec file. 
The existing SDK version doesn't incorporate changes from the scopemap spec file. 

Requesting a new SDK build. Please suggest changes if deemed necessary.
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Sep 10, 2019

In Testing, Please Ignore

[Logs] (Generated from 4d7873f, Iteration 1)

Succeeded .NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]
Succeeded Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
Failed Java: test-repo-billy/azure-sdk-for-java [Logs] [Diff]
Failed Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
Warning JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]
  • Warning @azure/arm-containerregistry [Logs]
Succeeded Ruby: test-repo-billy/azure-sdk-for-ruby [Logs] [Diff]

@AutorestCI
Copy link

AutorestCI commented Sep 10, 2019

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#6915

@AutorestCI
Copy link

AutorestCI commented Sep 10, 2019

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5736

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@ankurkhemani
Copy link
Contributor

LGTM.

@zikalino zikalino merged commit 0633527 into Azure:master Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants