Network August release #7208

anton-evseev · 2019-09-13T00:13:26Z

This is network-august-release rebased against master to get rid of some cherry picked fixes

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

…01 to version 2019-07-01

…s of Network's provisioningState property (Azure#7026)

* New Skus and generations for VirtualNetwork VpnGateways * Minor Typo fix * update [email protected] (Azure#7054) * Lock typescript version to fix compile error (Azure#7068) * Fix description for vpnGatewayGeneration.

…/ExpressRoutePort and MacSecConfig under Microsoft.Network/ExpressRouteLink (Azure#7005)

…hr.json (Azure#7080)

Azure#7066)

* Added priority field in the request routing rule * Added min and max * Minor

added number213 to Az NW

* Add privateLinkConnectionProperties to network interface on 2019-07-01. * Small changes for descriptions in the property. * make the new property to be read-only.

* PacketCaptureOperationforVPNGateways * Update virtualNetworkGateway.json * Update VirtualNetworkGatewayConnectionStopPacketCapture.json * Update VirtualNetworkGatewayStopPacketCapture.json * Update VirtualNetworkGatewayStopPacketCapture.json * Update VirtualNetworkGatewayConnectionStopPacketCapture.json * Update VirtualNetworkGatewayConnectionStartPacketCapture.json * Update VirtualNetworkGatewayStartPacketCapture.json * Update virtualNetworkGateway.json * fixing examples * fixing virtualNetworkGateway.json * fixing params * fixing path params * response body * example errors * example errors * example errors * filterdata * Update virtualNetworkGateway.json * fixing Comments * Fixing ARM Comments * Remove duplicate definition

openapi-sdkautomation · 2019-09-13T00:13:30Z

In Testing, Please Ignore

[Logs] (Generated from bb188c8, Iteration 1)

.NET: test-repo-billy/azure-sdk-for-net [Logs]

Package generation in progress.

Python: test-repo-billy/azure-sdk-for-python [Logs]

Package generation in progress.

Java: test-repo-billy/azure-sdk-for-java [Logs]

Package generation in progress.

Go: test-repo-billy/azure-sdk-for-go [Logs]

Package generation in progress.

JavaScript: test-repo-billy/azure-sdk-for-js [Logs]

Package generation in progress.

Ruby: test-repo-billy/azure-sdk-for-ruby [Logs]

Package generation in progress.

azuresdkci · 2019-09-13T00:15:15Z

Can one of the admins verify this patch?

AutorestCI · 2019-09-13T00:15:40Z

Automation for azure-sdk-for-python

Encountered a Subprocess error: (azure-sdk-for-python)

Command: ['/usr/local/bin/autorest', '/tmp/tmpkhe8qd2k/rest/specification/network/resource-manager/readme.md', '--keep-version-file', '--multiapi', '--no-async', '--python', '--python-mode=update', '--python-sdks-folder=/tmp/tmpkhe8qd2k/sdk/sdk', '[email protected]/[email protected]', '--version=preview']
Finished with return code -6
and output:

AutoRest code generation utility [version: 2.0.4283; node: v10.15.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4399)
   Loading AutoRest extension '@microsoft.azure/autorest.python' (4.0.70->4.0.70)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)
Processing batch task - {"tag":"package-2019-06"} .

<--- Last few GCs --->

[7620:0x3d3dcc0]    71655 ms: Mark-sweep 1379.0 (1426.3) -> 1379.0 (1426.8) MB, 1433.0 / 0.0 ms  (average mu = 0.168, current mu = 0.122) allocation failure GC in old space requested
[7620:0x3d3dcc0]    73102 ms: Mark-sweep 1379.6 (1426.8) -> 1379.5 (1427.3) MB, 1444.4 / 0.0 ms  (average mu = 0.088, current mu = 0.002) allocation failure GC in old space requested


<--- JS stacktrace --->

==== JS stack trace =========================================

    0: ExitFrame [pc: 0xd1aea5dbe1d]
Security context: 0x18f8c329e6e9 <JSObject>
    1: newScalar [0x13a94910099] [/node_modules/yaml-ast-parser/dist/src/yamlAST.js:~38] [pc=0xd1aeaa17bd6](this=0x3f7facb88859 <Object map = 0x3aed788a25f9>,v=0x1bf77d4826f1 <undefined>)
    2: arguments adaptor frame: 0->1
    3: readDoubleQuotedScalar(aka readDoubleQuotedScalar) [0x13a9490ffd9] [/node_modules/yaml-ast-parser/dist/src/loader.js:~530] [pc=0x...

FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
 1: 0x8dc510 node::Abort() [node]
 2: 0x8dc55c  [node]
 3: 0xad9b5e v8::Utils::ReportOOMFailure(v8::internal::Isolate*, char const*, bool) [node]
 4: 0xad9d94 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, bool) [node]
 5: 0xec7bf2  [node]
 6: 0xec7cf8 v8::internal::Heap::CheckIneffectiveMarkCompact(unsigned long, double) [node]
 7: 0xed3dd2 v8::internal::Heap::PerformGarbageCollection(v8::internal::GarbageCollector, v8::GCCallbackFlags) [node]
 8: 0xed4704 v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [node]
 9: 0xed7371 v8::internal::Heap::AllocateRawWithRetryOrFail(int, v8::internal::AllocationSpace, v8::internal::AllocationAlignment) [node]
10: 0xea07f4 v8::internal::Factory::NewFillerObject(int, bool, v8::internal::AllocationSpace) [node]
11: 0x11402db v8::internal::Runtime_AllocateInTargetSpace(int, v8::internal::Object**, v8::internal::Isolate*) [node]
12: 0xd1aea5dbe1d

AutorestCI · 2019-09-13T00:48:53Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5763

nschonni · 2019-09-13T20:40:10Z

.../resource-manager/Microsoft.Network/stable/2019-06-01/networkWatcherConnectionMonitorV1.json

@@ -0,0 +1,791 @@
+{


Should the swagger have "V1" in the name?

Yeah, there will be incompatible Connection Monitor V2 coming soon, so added V1 to differentiate

OK, but would the ever be in the same version folder?

That's why I thought it wouldn't need the version number in the name, since you'd just overwrite it with the V2 content in whatever version cut over

Connection monitor V2 will be added in networkWatcher.json and V1 will be removed, that's a bit different. We also want to explicitly state that the current CM spec is V1 since it's file will be reused until we introduce V2.

- Microsoft.Network/stable/2019-07-01/networkWatcher.json - Microsoft.Network/stable/2019-06-01/networkWatcherConnectionMonitorV1.json

makes a bit more sense (in my opinion) than

- Microsoft.Network/stable/2019-07-01/networkWatcher.json - Microsoft.Network/stable/2019-06-01/networkWatcherConnectionMonitor.json

anton-evseev and others added 17 commits September 12, 2019 17:11

Adds base for updating Microsoft.Network from version stable/2019-06-…

1fb740c

…01 to version 2019-07-01

Updates readme

845c73f

Updates API version in new specs and examples

bb6aebd

Update API version in VMSS' specs (Azure#7008)

1d9d69e

Add reference to existing base definition & fix errors in description…

add7021

…s of Network's provisioningState property (Azure#7026)

Improve Network's descriptions (Azure#6974)

daa1ba7

New Skus and Generations for VirtualNetworkVpnGateways (Azure#7089)

ebcbf37

* New Skus and generations for VirtualNetwork VpnGateways * Minor Typo fix * update [email protected] (Azure#7054) * Lock typescript version to fix compile error (Azure#7068) * Fix description for vpnGatewayGeneration.

Add VirtualRouter top level resource Identity under Microsoft.Network…

1494051

…/ExpressRoutePort and MacSecConfig under Microsoft.Network/ExpressRouteLink (Azure#7005)

Fixed required properties in TrafficAnalyticsProperties: networkWatce…

e3521d7

…hr.json (Azure#7080)

Added traffic selector policy definition to virtualNetworkGateway.json (

d049b69

Azure#7066)

Support for changes in ConnectionMonitor API (Azure#7075)

73e01eb

Updating Network Config Diagnostics API desc (Azure#7117)

93187ce

Added priority field in the request routing rule (Azure#7131)

eb01252

* Added priority field in the request routing rule * Added min and max * Minor

Added new owner to Azure Networking (Azure#7145)

2965dc3

added number213 to Az NW

Add Mssql value to Application Rule Type enum (Azure#7169)

c5b4af1

Add privateLinkConnectionProperties to network interface. (Azure#7189)

0905cd7

* Add privateLinkConnectionProperties to network interface on 2019-07-01. * Small changes for descriptions in the property. * make the new property to be read-only.

anton-evseev requested a review from MikhailTryakhov as a code owner September 13, 2019 00:13

azuresdkci assigned tjprescott Sep 13, 2019

azuresdkci requested a review from tjprescott September 13, 2019 00:14

AutorestCI mentioned this pull request Sep 13, 2019

[AutoPR network/resource-manager] Network August release Azure/azure-sdk-for-go#5767

Merged

nschonni reviewed Sep 13, 2019

View reviewed changes

anton-evseev mentioned this pull request Sep 13, 2019

Re-generate Network SDK based on Network August release Azure/azure-sdk-for-net#7612

Merged

sarangan12 approved these changes Sep 13, 2019

View reviewed changes

sarangan12 merged commit a3a1f28 into Azure:master Sep 13, 2019

anton-evseev deleted the merge-network branch September 13, 2019 22:50

anton-evseev mentioned this pull request Sep 16, 2019

Microsoft.Network schema for API version 2019-07-01 Azure/azure-resource-manager-schemas#710

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Network August release #7208

Network August release #7208

Uh oh!

anton-evseev commented Sep 13, 2019

Uh oh!

openapi-sdkautomation bot commented Sep 13, 2019 •

edited

Loading

Uh oh!

azuresdkci commented Sep 13, 2019

Uh oh!

AutorestCI commented Sep 13, 2019 •

edited

Loading

Uh oh!

AutorestCI commented Sep 13, 2019 •

edited

Loading

Uh oh!

nschonni Sep 13, 2019

Uh oh!

anton-evseev Sep 13, 2019

Uh oh!

anton-evseev Sep 13, 2019

Uh oh!

nschonni Sep 13, 2019

Uh oh!

anton-evseev Sep 13, 2019

Uh oh!

nschonni Sep 13, 2019

Uh oh!

anton-evseev Sep 13, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

16 participants

Network August release #7208

Network August release #7208

Uh oh!

Conversation

anton-evseev commented Sep 13, 2019

Contribution checklist:

ARM API Review Checklist

Uh oh!

openapi-sdkautomation bot commented Sep 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

In Testing, Please Ignore

[Logs] (Generated from bb188c8, Iteration 1)

Uh oh!

azuresdkci commented Sep 13, 2019

Uh oh!

AutorestCI commented Sep 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented Sep 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

nschonni Sep 13, 2019

Choose a reason for hiding this comment

Uh oh!

anton-evseev Sep 13, 2019

Choose a reason for hiding this comment

Uh oh!

anton-evseev Sep 13, 2019

Choose a reason for hiding this comment

Uh oh!

nschonni Sep 13, 2019

Choose a reason for hiding this comment

Uh oh!

anton-evseev Sep 13, 2019

Choose a reason for hiding this comment

Uh oh!

nschonni Sep 13, 2019

Choose a reason for hiding this comment

Uh oh!

anton-evseev Sep 13, 2019

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

16 participants

openapi-sdkautomation bot commented Sep 13, 2019 •

edited

Loading

AutorestCI commented Sep 13, 2019 •

edited

Loading

AutorestCI commented Sep 13, 2019 •

edited

Loading