some fixes for frontdoor readme #7424
Conversation
In Testing, Please Ignore[Logs] (Generated from 3a7dbc7, Iteration 10)
|
Automation for azure-sdk-for-pythonA PR has been created for you: |
Automation for azure-sdk-for-goNothing to generate for azure-sdk-for-go |
|
Can one of the admins verify this patch? |
| description: FrontDoor Client | ||
| openapi-type: arm | ||
| tag: package-2019-10 | ||
| tag: package-2019-11 |
There was a problem hiding this comment.
is package-2019-10 released before?
There was a problem hiding this comment.
no, package-2019-10 and package-2019-11 were for some reason both created just several days ago.
it anything was released using one of these tags, package would be invalid.
| ], | ||
| "x-ms-enum": { | ||
| "name": "aggregationInterval", | ||
| "name": "latencyScoreboardAggregationInterval", |
There was a problem hiding this comment.
this is a potential breaking change, is this a swagger bug fixing to align with existing service behavior?
There was a problem hiding this comment.
this should say "latencyScorecardAggregationInterval"
There was a problem hiding this comment.
@minechosoft renamed to Scorecard
@yungezz changing name in x-ms-enum only results in SDK changes. anyway, we had to change this name, as there were two different enums with the same name, and that was causing autorest to fail. Any other changes I made were checked by @minechosoft and service is going to be aligned.
| "disabling", | ||
| "disabled", | ||
| "deleting" | ||
| "Creating", |
There was a problem hiding this comment.
discussed with service team, they will make sure RP is in sync (networkexperiment was not release yet)
There was a problem hiding this comment.
yes. it's not breaking-- we will make sure to have these changes reflected in our service.
| "resourceState": { | ||
| "description": "Resource status.", | ||
| "$ref": "#/definitions/ResourceState" | ||
| "$ref": "#/definitions/NetworkExperimentationResourceState" |
There was a problem hiding this comment.
"NetworkExperimentResourceState"
| "resourceState": { | ||
| "description": "Resource status.", | ||
| "$ref": "#/definitions/ResourceState" | ||
| "$ref": "#/definitions/NetworkExperimentationResourceState" |
There was a problem hiding this comment.
"NetworkExperimentResourceState"
No description provided.