ASR : swagger changes for zone to zone recovery plan #7985

vigaur · 2019-12-16T11:00:00Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

AutorestCI · 2019-12-16T11:00:02Z

You don't have permission to trigger SDK Automation.
Please add yourself to Azure group from opensource portal if you are MSFT employee,
or please ask reviewer to add comment *** /openapibot sdkautomation ***.
Please ask [email protected] (or NullMDR in github) for additional help.

msftclas · 2019-12-16T11:00:14Z

All CLA requirements met.

azuresdkci · 2019-12-16T11:01:23Z

Can one of the admins verify this patch?

vigaur · 2019-12-16T11:02:09Z

Model validation and semantic validations are not due to this PR and are being fixed as a separate PR : #7863

vigaur · 2019-12-17T07:16:33Z

@myronfanqiu please take a look at this PR. Also please note that the changes are not breaking changes. thanks

mmyyrroonn · 2019-12-17T08:33:51Z

@vigaur Could you solve the CI errors? You need to change the swagger spec and change the example files.

vigaur · 2019-12-17T08:48:52Z

@myronfanqiu Please note that the Model validation and semantic validation errors are not result of current changes, Another PR is being raised for it along with #7863

Also please let me know who should be added to get the ARM feedback for the PR, thanks

...vicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2018-07-10/service.json

mmyyrroonn · 2019-12-20T02:17:41Z

@vigaur Can you fix another CI errors in this PR too? I know it's not related with the changes happened in this PR. But it's better to improve the quality of examples.

azure-rest-api-specs/specification/recoveryservicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2018-07-10/examples/ReplicationRecoveryPlans_TestFailover.json

Line 15 in 313f248

"instanceType": "HyperVReplicaAzure"

vigaur · 2019-12-20T10:12:29Z

@myronfanqiu I understand the concern, though since these examples involve multiple stakeholders, we are taking this as back log item and will raise a separate PR for this, thanks

mmyyrroonn · 2019-12-23T02:05:53Z

@vigaur Hello. We still need ARM's review. BTW, I don't have the right to merge it without CI pass. I will invite the correct person to help you.

mmyyrroonn · 2019-12-23T02:07:20Z

@NullMDR Could you involve the right person to help on this PR? @vigaur want to merge this PR without CI pass.

PhoenixHe-NV · 2019-12-23T04:58:33Z

/azp run automation - sdk

azure-pipelines · 2019-12-23T04:58:43Z

Azure Pipelines successfully started running 1 pipeline(s).

PhoenixHe-NV · 2019-12-23T04:59:57Z

@vigaur Please supress model validation error in readme.md. You can reference https://github.com/Azure/azure-rest-api-specs/blob/master/specification/network/resource-manager/readme.md#suppression as example

openapi-sdkautomation · 2019-12-23T05:00:35Z

azure-sdk-for-java - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 8803e2b with merge commit d1441c8. SDK Automation 13.0.17.20191226.1
️✔️sdk/recoveryservices.siterecovery/mgmt-v2016_08_10 [Logs] [Release SDK Changes]
️✔️sdk/recoveryservices.siterecovery/mgmt-v2018_01_10 [Logs] [Release SDK Changes]

openapi-sdkautomation · 2019-12-23T05:00:35Z

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 8803e2b with merge commit d1441c8. SDK Automation 13.0.17.20191226.1
️✔️recoveryservices/mgmt/2016-08-10 [Logs] [Release SDK Changes]
- recoveryservices.mgmt.2016-08-10.zip
️✔️recoveryservices/mgmt/2018-01-10 [Logs] [Release SDK Changes]
- recoveryservices.mgmt.2018-01-10.zip
️✔️recoveryservices/mgmt/2018-07-10 [Logs] [Release SDK Changes]
- recoveryservices.mgmt.2018-07-10.zip

openapi-sdkautomation · 2019-12-23T05:00:37Z

azure-sdk-for-python - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 8803e2b with merge commit d1441c8. SDK Automation 13.0.17.20191226.1
```
Failed to find any diff after autorest so no changed packages was found.
```

openapi-sdkautomation · 2019-12-23T05:00:37Z

azure-sdk-for-net - Release

❌ failed [Logs] [Expand Details]

❌ Generate from 8803e2b with merge commit d1441c8. SDK Automation 13.0.17.20191226.1

[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied

❌Microsoft.Azure.Management.RecoveryServices.SiteRecovery [Logs] [Release SDK Changes]

Failed to create the package Microsoft.Azure.Management.RecoveryServices.SiteRecovery.
Error: dotnet msbuild build.proj /t:CreateNugetPackage /p:Scope=recoveryservices-siterecovery /v:n /p:SkipTests=true , {}

openapi-sdkautomation · 2019-12-23T05:01:02Z

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 8803e2b with merge commit d1441c8. SDK Automation 13.0.17.20191226.1

️✔️@azure/arm-recoveryservices-siterecovery [Logs] [Release SDK Changes]

azure-arm-recoveryservices-siterecovery-3.2.0.tgz

[npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/siteRecoveryManagementClient.js → ./dist/arm-recoveryservices-siterecovery.js...
[npmPack] created ./dist/arm-recoveryservices-siterecovery.js in 1s

mmyyrroonn · 2020-01-13T02:34:22Z

@vigaur Hello. Could you solve the ARM's review comments?

vigaur · 2020-01-14T04:50:30Z

@ryansbenson I have resolved all the comments. We are using different objects for input (RecoveryPlanProviderSpecificInput here) and output (RecoveryPlanProviderSpecificDetails here) for many other entities in our code. This is the case since, sometime we may send additional properties in output which may not be present in input (we may add extra properties for recovery plan output which may not be present in input). Also, sometimes for the same property output format may be different than input format.

ryansbenson

I understand what you're doing, its just going to generate an unusable sdk. The type model for get and put are completely different so there is no way to get, update a single field, put. In your case there would be an entire deep details -> input mapping step needed. I highly suggest you try using your own SDK and decided if you think its acceptable. As this is a common pattern across this your swagger I'll approve it, though please own customer satisfaction for the SDK.

mmyyrroonn · 2020-01-16T06:11:31Z

re-trigger the CI

azure-pipelines · 2020-01-16T06:11:37Z

Azure Pipelines successfully started running 1 pipeline(s).

PhoenixHe-NV · 2020-01-16T06:13:38Z

/azp run automation - sdk

azure-pipelines · 2020-01-16T06:13:48Z

Azure Pipelines successfully started running 1 pipeline(s).

mmyyrroonn · 2020-01-20T02:29:43Z

/azp run automation - sdk

azure-pipelines · 2020-01-20T02:29:52Z

Azure Pipelines successfully started running 1 pipeline(s).

mmyyrroonn · 2020-01-20T02:33:17Z

/azp run PrettierCheck

azure-pipelines · 2020-01-20T02:33:22Z

No pipelines are associated with this pull request.

PhoenixHe-NV · 2020-01-20T02:33:34Z

/azp run public.rest-api-specs

azure-pipelines · 2020-01-20T02:33:46Z

Azure Pipelines successfully started running 1 pipeline(s).

mmyyrroonn · 2020-01-20T02:38:29Z

@vigaur Hello. Could you fix errors in PrettierCheck?

azure-pipelines · 2020-01-22T14:51:21Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-01-23T11:17:35Z

Azure Pipelines successfully started running 1 pipeline(s).

PhoenixHe-NV · 2020-01-23T15:33:54Z

/azp run automation - sdk

azure-pipelines · 2020-01-23T15:34:13Z

Azure Pipelines successfully started running 1 pipeline(s).

* swagger changes for zone to zone recovery plan * zone to zone recovery plan provider specific read only property update * prettier format * prettier formatting

swagger changes for zone to zone recovery plan

8df9ee6

vigaur changed the title ~~swagger changes for zone to zone recovery plan~~ ASR : swagger changes for zone to zone recovery plan Dec 16, 2019

azuresdkci assigned mmyyrroonn Dec 16, 2019

azuresdkci requested a review from mmyyrroonn December 16, 2019 11:00

mmyyrroonn added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Dec 17, 2019

mmyyrroonn reviewed Dec 18, 2019

View reviewed changes

...vicessiterecovery/resource-manager/Microsoft.RecoveryServices/stable/2018-07-10/service.json Show resolved Hide resolved

Merge remote-tracking branch 'azure-rest-local/master' into z2zRp

313f248

mmyyrroonn approved these changes Dec 23, 2019

View reviewed changes

ryansbenson reviewed Jan 14, 2020

View reviewed changes

ryansbenson added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 14, 2020

mmyyrroonn closed this Jan 16, 2020

mmyyrroonn reopened this Jan 16, 2020

prettier format

ff5e31a

vigaur added 2 commits January 23, 2020 16:44

Merge remote-tracking branch 'azure-rest-local/master' into z2zRp

342052c

prettier formatting

8803e2b

PhoenixHe-NV merged commit d1441c8 into Azure:master Jan 29, 2020

ASR : swagger changes for zone to zone recovery plan #7985

ASR : swagger changes for zone to zone recovery plan #7985

Uh oh!

Conversation

vigaur commented Dec 16, 2019

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

AutorestCI commented Dec 16, 2019

Uh oh!

msftclas commented Dec 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

azuresdkci commented Dec 16, 2019

Uh oh!

vigaur commented Dec 16, 2019

Uh oh!

vigaur commented Dec 17, 2019

Uh oh!

mmyyrroonn commented Dec 17, 2019

Uh oh!

vigaur commented Dec 17, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

mmyyrroonn commented Dec 20, 2019

Uh oh!

vigaur commented Dec 20, 2019

Uh oh!

mmyyrroonn commented Dec 23, 2019

Uh oh!

mmyyrroonn commented Dec 23, 2019

Uh oh!

PhoenixHe-NV commented Dec 23, 2019

Uh oh!

azure-pipelines bot commented Dec 23, 2019

Uh oh!

PhoenixHe-NV commented Dec 23, 2019

Uh oh!

openapi-sdkautomation bot commented Dec 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-java - Release

Uh oh!

openapi-sdkautomation bot commented Dec 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-go - Release

Uh oh!

openapi-sdkautomation bot commented Dec 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-python - Release

Uh oh!

openapi-sdkautomation bot commented Dec 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-net - Release

Uh oh!

openapi-sdkautomation bot commented Dec 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-js - Release

Uh oh!

mmyyrroonn commented Jan 13, 2020

Uh oh!

vigaur commented Jan 14, 2020

Uh oh!

ryansbenson left a comment

Choose a reason for hiding this comment

Uh oh!

mmyyrroonn commented Jan 16, 2020

Uh oh!

azure-pipelines bot commented Jan 16, 2020

Uh oh!

PhoenixHe-NV commented Jan 16, 2020

Uh oh!

azure-pipelines bot commented Jan 16, 2020

Uh oh!

mmyyrroonn commented Jan 20, 2020

Uh oh!

azure-pipelines bot commented Jan 20, 2020

Uh oh!

mmyyrroonn commented Jan 20, 2020

msftclas commented Dec 16, 2019 •

edited

Loading

vigaur commented Dec 17, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 23, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 23, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 23, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 23, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 23, 2019 •

edited

Loading