Skip to content

[SRP] Support file share soft delete (restoreShare API) #7988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zfchen95 wants to merge 6 commits into from
Closed

[SRP] Support file share soft delete (restoreShare API) #7988

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3030f5a
[SRP] Support file share soft delete (restoreShare API)
zfchen95 Dec 16, 2019
ca463aa
Update FileSharesRestore.json
zfchen95 Dec 16, 2019
43dc44f
Update file.json
zfchen95 Dec 16, 2019
d78dd46
Update file.json
zfchen95 Dec 16, 2019
5003313
List deleted shares with version, and support rename restored share
zfchen95 Jan 21, 2020
ace3f34
Make deleted share name and version required
zfchen95 Mar 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
List deleted shares with version, and support rename restored share
  • Loading branch information
@zfchen95
zfchen95 committed Jan 21, 2020
commit 50033139e87a7490ebabd03894c4e525f1b5f552
3 changes: 2 additions & 1 deletion .../resource-manager/Microsoft.Storage/stable/2019-06-01/examples/DeletedFileSharesList.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"subscriptionId": "{subscription-id}",
"resourceGroupName": "res9290",
"accountName": "sto1590",
"$expand": "deleted",
"api-version": "2019-06-01",
"monitor": "true"
},
Expand All @@ -11,7 +12,7 @@
"body": {
"value": [
{
"id": "/subscriptions/{subscription-id}/resourceGroups/res9290/providers/Microsoft.Storage/storageAccounts/sto1590/fileServices/default/shares/share1644",
"id": "/subscriptions/{subscription-id}/resourceGroups/res9290/providers/Microsoft.Storage/storageAccounts/sto1590/fileServices/default/shares/share1644_1234567890",
"name": "share1644",
"type": "Microsoft.Storage/storageAccounts/fileServices/shares",
"etag": "\"0x8D589847D51C7DE\"",
Expand Down
11 changes: 5 additions & 6 deletions ...rage/resource-manager/Microsoft.Storage/stable/2019-06-01/examples/FileSharesRestore.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,12 @@
"resourceGroupName": "res3376",
"accountName": "sto328",
"shareName": "share6185",
"deletedShare": {
"deletedShareName": "share1249",
"deletedShareVersion": "1234567890"
},
"api-version": "2019-06-01",
"monitor": "true",
"fileShare": {
"properties": {
"version": "1234567890"
}
}
"monitor": "true"
},
"responses": {
"200": {}
Expand Down
20 changes: 16 additions & 4 deletions specification/storage/resource-manager/Microsoft.Storage/stable/2019-06-01/file.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,13 +451,12 @@
"$ref": "#/parameters/ShareName"
},
{
"name": "fileShare",
"name": "deletedShare",
"in": "body",
"required": true,
"schema": {
"$ref": "#/definitions/FileShare"
},
"description": "Must contain the version of the file share to restore."
"$ref": "#/definitions/DeletedShare"
}
},
{
"$ref": "../../../../../common-types/resource-management/v1/types.json#/parameters/ApiVersionParameter"
Expand Down Expand Up @@ -539,6 +538,19 @@
],
"description": "Properties of the file share, including Id, resource name, resource type, Etag."
},
"DeletedShare":{
"properties": {
"deletedShareName": {
Copy link
Member

@blueww blueww Feb 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to set deletedShareName and deletedShareVersion as required in "DeletedShare", or the current generated SDK from swagger will have the 2 parameters as optional when restore share, but they are actually required on server.

Copy link
Contributor

@Juliehzl Juliehzl Feb 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with Wei. Currently the generated SDK doesn't make deletedShareName and deletedShareVersion required, which are not as expected.

Copy link
Contributor Author

@zfchen95 zfchen95 Mar 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done~

"type": "string",
"description": "Required. Identify the name of the deleted share that will be restored."
},
"deletedShareVersion": {
"type": "string",
"description": "Required. Identify the version of the deleted share that will be restored."
}
},
"description": "The deleted share to be restored."
},
"FileShareItem": {
"properties": {
"properties": {
Expand Down