Skip to content

ApiManagement - long running operations #8225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
allenjzhang merged 4 commits into from
Jan 29, 2020
Merged

ApiManagement - long running operations #8225

allenjzhang merged 4 commits into from
Jan 29, 2020

Conversation

@vfedonkin
Copy link
Contributor

@vfedonkin vfedonkin commented Jan 24, 2020 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azure-pipelines
Copy link

azure-pipelines bot commented Jan 24, 2020

Azure Pipelines successfully started running 1 pipeline(s).

2 similar comments
@azure-pipelines
Copy link

azure-pipelines bot commented Jan 24, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

azure-pipelines bot commented Jan 24, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jan 24, 2020 •
edited
Loading

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 87c9939 with merge commit 1d2c2e5. SDK Automation 13.0.17.20191226.1
  • ️✔️@azure/arm-apimanagement [Logs]  [Release SDK Changes] 
    [npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/apiManagementClient.js → ./dist/arm-apimanagement.js...
[npmPack] created ./dist/arm-apimanagement.js in 1.6s

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jan 24, 2020 •
edited
Loading

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 87c9939 with merge commit 1d2c2e5. SDK Automation 13.0.17.20191226.1
  • ️✔️azure-mgmt-apimanagement [Logs]  [Release SDK Changes] 
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jan 24, 2020 •
edited
Loading

azure-sdk-for-net - Release

❌ failed [Logs] [Expand Details]
  • ❌ Generate from 87c9939 with merge commit 1d2c2e5. SDK Automation 13.0.17.20191226.1 
    [AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
  • ❌Microsoft.Azure.Management.ApiManagement [Logs]  [Release SDK Changes] 
      Failed to create the package Microsoft.Azure.Management.ApiManagement.
Error: dotnet msbuild build.proj /t:CreateNugetPackage /p:Scope=apimanagement /v:n /p:SkipTests=true , {}

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jan 24, 2020 •
    edited
    Loading

    azure-sdk-for-java - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jan 24, 2020 •
    edited
    Loading

    azure-sdk-for-go - Release

    ️✔️ succeeded [Logs] [Expand Details]

    @vfedonkin
    Copy link
    Contributor Author

    vfedonkin commented Jan 24, 2020

    This pull request contains changes requested during this PR: #8066

    This was referenced Jan 24, 2020
    Closed
    Closed
    solankisamir
    solankisamir approved these changes Jan 24, 2020
    View reviewed changes
    Copy link
    Member

    @solankisamir solankisamir left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    :shipit:

    @azure-pipelines
    Copy link

    azure-pipelines bot commented Jan 24, 2020

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link

    azure-pipelines bot commented Jan 24, 2020

    Azure Pipelines successfully started running 1 pipeline(s).

    @solankisamir solankisamir added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 24, 2020
    @openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Jan 24, 2020
    Closed
    @arifsundrani arifsundrani mentioned this pull request Jan 24, 2020
    Closed
    majastrz
    majastrz reviewed Jan 25, 2020
    View reviewed changes
    Copy link
    Member

    @majastrz majastrz left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    I added a comment. Please take a look.

    @azure-pipelines
    Copy link

    azure-pipelines bot commented Jan 27, 2020

    Azure Pipelines successfully started running 1 pipeline(s).

    @solankisamir solankisamir removed the request for review from sanjaiganesh January 27, 2020 23:14
    @majastrz majastrz added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 28, 2020
    majastrz
    majastrz approved these changes Jan 28, 2020
    View reviewed changes
    Copy link
    Member

    @majastrz majastrz left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Signed off from ARM side.

    @solankisamir
    Copy link
    Member

    solankisamir commented Jan 28, 2020

    @allenjzhang can you please merge this PR? This has been approved by ARM now.

    @allenjzhang allenjzhang merged commit 1d2c2e5 into Azure:master Jan 29, 2020
    @timja timja mentioned this pull request Feb 2, 2020
    Closed
    ssripadham pushed a commit to ssripadham/azure-rest-api-specs that referenced this pull request Feb 21, 2020
    @vfedonkin @ssripadham
    ApiManagement - long running operations (Azure#8225)
    a09499b 
    * ApiManagement - long running operations

* ApiManagement - long running operations - 200

* ApiManagement - long running operations - 200 - example

* ApiManagement - long running operations - 200 - payload
    00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
    @vfedonkin @00Kai0
    ApiManagement - long running operations (Azure#8225)
    025b7ea 
    * ApiManagement - long running operations

* ApiManagement - long running operations - 200

* ApiManagement - long running operations - 200 - example

* ApiManagement - long running operations - 200 - payload
    @vfedonkin vfedonkin deleted the apim_long_running_operations branch August 26, 2021 20:25
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    @solankisamir solankisamir solankisamir approved these changes

    @majastrz majastrz majastrz approved these changes

    Assignees

    @allenjzhang allenjzhang

    Labels

    ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    4 participants

    @vfedonkin @solankisamir @majastrz @allenjzhang