BillingRP - Adding new fields to transactions API #8232

asarkar84 · 2020-01-25T02:51:57Z

Adding new fields to transactions API

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

Adding new fields to transactions API

azure-pipelines · 2020-01-25T02:52:14Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-01-25T02:53:32Z

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 5259473 with merge commit ba0ef29. SDK Automation 13.0.17.20191226.1

️✔️@azure/arm-billing [Logs] [Release SDK Changes]

azure-arm-billing-2.2.0.tgz

[npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/billingManagementClient.js → ./dist/arm-billing.js...
[npmPack] created ./dist/arm-billing.js in 676ms

openapi-sdkautomation · 2020-01-25T02:53:36Z

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 5259473 with merge commit ba0ef29. SDK Automation 13.0.17.20191226.1

️✔️azure-mgmt-billing [Logs] [Release SDK Changes]

[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)

openapi-sdkautomation · 2020-01-25T02:53:37Z

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 5259473 with merge commit ba0ef29. SDK Automation 13.0.17.20191226.1

[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied

️✔️Microsoft.Azure.Management.Billing [Logs] [Release SDK Changes]
- Microsoft.Azure.Management.Billing.3.0.0-preview.nupkg
- Microsoft.Azure.Management.Billing.3.0.0-preview.snupkg

openapi-sdkautomation · 2020-01-25T02:53:38Z

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 5259473 with merge commit ba0ef29. SDK Automation 13.0.17.20191226.1
⚠️preview/billing/mgmt/2017-02-27-preview [Logs]
```
No file is changed.
```
⚠️preview/billing/mgmt/2017-04-24-preview [Logs]
```
No file is changed.
```
⚠️preview/billing/mgmt/2018-03-01-preview [Logs]
```
No file is changed.
```
⚠️preview/billing/mgmt/2018-11-01-preview [Logs]
```
No file is changed.
```

openapi-sdkautomation · 2020-01-25T02:53:39Z

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 5259473 with merge commit ba0ef29. SDK Automation 13.0.17.20191226.1
️✔️sdk/billing/mgmt-v2017_02_27_preview [Logs] [Release SDK Changes]
️✔️sdk/billing/mgmt-v2017_04_24_preview [Logs] [Release SDK Changes]
️✔️sdk/billing/mgmt-v2018_03_01_preview [Logs] [Release SDK Changes]

⚠️sdk/billing/mgmt-v2018_11_01_preview [Logs] [Release SDK Changes]

[mvn] [ERROR] COMPILATION ERROR : 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/billing/mgmt-v2018_11_01_preview/src/main/java/com/microsoft/azure/management/billing/v2018_11_01_preview/implementation/PriceSheetsInner.java:[130,39] method getPostOrDeleteResultWithHeadersAsync in class com.microsoft.azure.AzureClient cannot be applied to given types;
[mvn]   required: rx.Observable>,java.lang.reflect.Type,java.lang.Class
[mvn]   found: rx.Observable>,com.microsoft.azure.LongRunningOperationOptions,java.lang.reflect.Type,java.lang.Class
[mvn]   reason: cannot infer type-variable(s) T,THeader
[mvn]     (actual and formal argument lists differ in length)
[mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-billing: Compilation failure
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/billing/mgmt-v2018_11_01_preview/src/main/java/com/microsoft/azure/management/billing/v2018_11_01_preview/implementation/PriceSheetsInner.java:[130,39] method getPostOrDeleteResultWithHeadersAsync in class com.microsoft.azure.AzureClient cannot be applied to given types;
[mvn] [ERROR]   required: rx.Observable>,java.lang.reflect.Type,java.lang.Class
[mvn] [ERROR]   found: rx.Observable>,com.microsoft.azure.LongRunningOperationOptions,java.lang.reflect.Type,java.lang.Class
[mvn] [ERROR]   reason: cannot infer type-variable(s) T,THeader
[mvn] [ERROR]     (actual and formal argument lists differ in length)
[mvn] [ERROR] -> [Help 1]
[mvn] [ERROR] 
[mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[mvn] [ERROR] 
[mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

⚠️sdk/billing/mgmt-v2019_10_01_preview [Logs] [Release SDK Changes]

[mvn] [ERROR] COMPILATION ERROR : 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/billing/mgmt-v2019_10_01_preview/src/main/java/com/microsoft/azure/management/billing/v2019_10_01_preview/implementation/PriceSheetsInner.java:[146,39] method getPostOrDeleteResultWithHeadersAsync in class com.microsoft.azure.AzureClient cannot be applied to given types;
[mvn]   required: rx.Observable>,java.lang.reflect.Type,java.lang.Class
[mvn]   found: rx.Observable>,com.microsoft.azure.LongRunningOperationOptions,java.lang.reflect.Type,java.lang.Class
[mvn]   reason: cannot infer type-variable(s) T,THeader
[mvn]     (actual and formal argument lists differ in length)
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/billing/mgmt-v2019_10_01_preview/src/main/java/com/microsoft/azure/management/billing/v2019_10_01_preview/implementation/PriceSheetsInner.java:[303,39] method getPostOrDeleteResultWithHeadersAsync in class com.microsoft.azure.AzureClient cannot be applied to given types;
[mvn]   required: rx.Observable>,java.lang.reflect.Type,java.lang.Class
[mvn]   found: rx.Observable>,com.microsoft.azure.LongRunningOperationOptions,java.lang.reflect.Type,java.lang.Class
[mvn]   reason: cannot infer type-variable(s) T,THeader
[mvn]     (actual and formal argument lists differ in length)
[mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-billing: Compilation failure: Compilation failure: 
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/billing/mgmt-v2019_10_01_preview/src/main/java/com/microsoft/azure/management/billing/v2019_10_01_preview/implementation/PriceSheetsInner.java:[146,39] method getPostOrDeleteResultWithHeadersAsync in class com.microsoft.azure.AzureClient cannot be applied to given types;
[mvn] [ERROR]   required: rx.Observable>,java.lang.reflect.Type,java.lang.Class
[mvn] [ERROR]   found: rx.Observable>,com.microsoft.azure.LongRunningOperationOptions,java.lang.reflect.Type,java.lang.Class
[mvn] [ERROR]   reason: cannot infer type-variable(s) T,THeader
[mvn] [ERROR]     (actual and formal argument lists differ in length)
[mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/billing/mgmt-v2019_10_01_preview/src/main/java/com/microsoft/azure/management/billing/v2019_10_01_preview/implementation/PriceSheetsInner.java:[303,39] method getPostOrDeleteResultWithHeadersAsync in class com.microsoft.azure.AzureClient cannot be applied to given types;
[mvn] [ERROR]   required: rx.Observable>,java.lang.reflect.Type,java.lang.Class
[mvn] [ERROR]   found: rx.Observable>,com.microsoft.azure.LongRunningOperationOptions,java.lang.reflect.Type,java.lang.Class
[mvn] [ERROR]   reason: cannot infer type-variable(s) T,THeader
[mvn] [ERROR]     (actual and formal argument lists differ in length)
[mvn] [ERROR] -> [Help 1]
[mvn] [ERROR] 
[mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
[mvn] [ERROR] 
[mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

...ification/billing/resource-manager/Microsoft.Billing/preview/2019-10-01-preview/billing.json

azure-pipelines · 2020-01-27T22:46:03Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-01-27T22:46:04Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-01-27T22:46:05Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-01-27T22:46:58Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-01-27T22:48:22Z

Azure Pipelines successfully started running 1 pipeline(s).

Updated the field description

azure-pipelines · 2020-01-29T02:02:59Z

Azure Pipelines successfully started running 1 pipeline(s).

asarkar84 · 2020-01-29T02:04:49Z

@allenjzhang I have incorporated the review comments. Please take a look.

azure-pipelines · 2020-01-29T02:13:35Z

Azure Pipelines successfully started running 1 pipeline(s).

asarkar84 · 2020-01-29T18:51:28Z

@allenjzhang Please review and merge the PR.

azure-pipelines · 2020-01-30T01:37:23Z

Azure Pipelines successfully started running 1 pipeline(s).

asarkar84 · 2020-01-30T12:02:18Z

@allenjzhang Please merge the PR.

allenjzhang · 2020-01-30T19:19:12Z

/azp run

azure-pipelines · 2020-01-30T19:19:33Z

Azure Pipelines successfully started running 3 pipeline(s).

* Adding new fields to transactions API Adding new fields to transactions API * Updated the field description Updated the field description * Updated few descriptions

Adding new fields to transactions API

609e7a1

Adding new fields to transactions API

asarkar84 requested a review from wilcobmsft as a code owner January 25, 2020 02:51

openapi-assignment-bot bot assigned allenjzhang Jan 25, 2020

allenjzhang reviewed Jan 25, 2020

View reviewed changes

...ification/billing/resource-manager/Microsoft.Billing/preview/2019-10-01-preview/billing.json Outdated Show resolved Hide resolved

allenjzhang added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 27, 2020

Merge remote-tracking branch 'upstream/master' into ansar/transactions

e6177df

Updated the field description

680ef78

Updated the field description

Merge remote-tracking branch 'upstream/master' into ansar/transactions

7d6b456

anthony-c-martin added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 29, 2020

allenjzhang approved these changes Jan 29, 2020

View reviewed changes

Updated few descriptions

5259473

allenjzhang merged commit ba0ef29 into Azure:master Jan 30, 2020

BillingRP - Adding new fields to transactions API #8232

BillingRP - Adding new fields to transactions API #8232

Uh oh!

Conversation

asarkar84 commented Jan 25, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

azure-pipelines bot commented Jan 25, 2020

Uh oh!

openapi-sdkautomation bot commented Jan 25, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-js - Release

Uh oh!

openapi-sdkautomation bot commented Jan 25, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-python - Release

Uh oh!

openapi-sdkautomation bot commented Jan 25, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-net - Release

Uh oh!

openapi-sdkautomation bot commented Jan 25, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-go - Release

Uh oh!

openapi-sdkautomation bot commented Jan 25, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-java - Release

Uh oh!

Uh oh!

azure-pipelines bot commented Jan 27, 2020

Uh oh!

azure-pipelines bot commented Jan 27, 2020

Uh oh!

azure-pipelines bot commented Jan 27, 2020

Uh oh!

azure-pipelines bot commented Jan 27, 2020

Uh oh!

azure-pipelines bot commented Jan 27, 2020

Uh oh!

azure-pipelines bot commented Jan 29, 2020

Uh oh!

asarkar84 commented Jan 29, 2020

Uh oh!

azure-pipelines bot commented Jan 29, 2020

Uh oh!

asarkar84 commented Jan 29, 2020

Uh oh!

azure-pipelines bot commented Jan 30, 2020

Uh oh!

asarkar84 commented Jan 30, 2020

Uh oh!

allenjzhang commented Jan 30, 2020

Uh oh!

azure-pipelines bot commented Jan 30, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

asarkar84 commented Jan 25, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jan 25, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jan 25, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jan 25, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jan 25, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jan 25, 2020 •

edited

Loading