Diagnostic Contract Fix #8271

solankisamir · 2020-01-30T22:34:40Z

Latest improvements:

Add the missing property enableHttpCorrelationProtocol which was reverted by accident from 2019-01-01 Commit SHA ec0ae41#diff-c19f475d13eda77ff6ff950fa5a65381
Update Diagnostic contract in 2019-12-01-preview to include new properties.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

azure-pipelines · 2020-01-30T22:34:56Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-01-30T22:35:00Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-01-30T22:35:01Z

Azure Pipelines failed to run 1 pipeline(s).

azure-pipelines · 2020-01-30T22:35:04Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-01-30T22:35:06Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2020-01-30T22:36:20Z

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 65d9c1d with merge commit 0603855. SDK Automation 13.0.17.20191226.1

️✔️azure-mgmt-apimanagement [Logs] [Release SDK Changes]

[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'

openapi-sdkautomation · 2020-01-30T22:36:26Z

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 65d9c1d with merge commit 0603855. SDK Automation 13.0.17.20191226.1
⚠️apimanagement/mgmt/2016-07-07 [Logs]
```
No file is changed.
```
⚠️apimanagement/mgmt/2016-10-10 [Logs]
```
No file is changed.
```
⚠️apimanagement/mgmt/2017-03-01 [Logs]
```
No file is changed.
```
⚠️apimanagement/mgmt/2018-01-01 [Logs]
```
No file is changed.
```
️✔️apimanagement/mgmt/2019-01-01 [Logs] [Release SDK Changes]
- apimanagement.mgmt.2019-01-01.zip
⚠️preview/apimanagement/mgmt/2018-06-01-preview [Logs]
```
No file is changed.
```

openapi-sdkautomation · 2020-01-30T22:36:26Z

azure-sdk-for-net - Release

❌ failed [Logs] [Expand Details]

❌ Generate from 65d9c1d with merge commit 0603855. SDK Automation 13.0.17.20191226.1

[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied

❌Microsoft.Azure.Management.ApiManagement [Logs] [Release SDK Changes]

Failed to create the package Microsoft.Azure.Management.ApiManagement.
Error: dotnet msbuild build.proj /t:CreateNugetPackage /p:Scope=apimanagement /v:n /p:SkipTests=true , {}

openapi-sdkautomation · 2020-01-30T22:36:29Z

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 65d9c1d with merge commit 0603855. SDK Automation 13.0.17.20191226.1

️✔️@azure/arm-apimanagement [Logs] [Release SDK Changes]

azure-arm-apimanagement-5.1.1.tgz

[npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/apiManagementClient.js → ./dist/arm-apimanagement.js...
[npmPack] created ./dist/arm-apimanagement.js in 1.6s

openapi-sdkautomation · 2020-01-30T22:36:32Z

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

azure-pipelines · 2020-01-30T22:40:42Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-01T00:50:06Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-01T00:56:20Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-02-03T21:02:40Z

Azure Pipelines successfully started running 1 pipeline(s).

...agement/resource-manager/Microsoft.ApiManagement/preview/2019-12-01-preview/definitions.json

pilor

one minor comment above

* Diagnostic Contract update * there is no enableHttpCorrelation in 2019-12-01-preview

Diagnostic Contract update

dc386aa

openapi-assignment-bot bot assigned allenjzhang Jan 30, 2020

openapi-sdkautomation bot mentioned this pull request Jan 30, 2020

[AutoPR azure-mgmt-apimanagement] Diagnostic Contract Fix AzureSDKAutomation/azure-sdk-for-python#253

Closed

solankisamir added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 30, 2020

solankisamir requested a review from promoisha January 30, 2020 22:40

This was referenced Jan 30, 2020

[AutoPR @azure/arm-apimanagement] Diagnostic Contract Fix AzureSDKAutomation/azure-sdk-for-js#337

Closed

[AutoPR Microsoft.Azure.Management.ApiManagement] Diagnostic Contract Fix AzureSDKAutomation/azure-sdk-for-net#379

Closed

solankisamir added the API Management label Jan 31, 2020

there is no enableHttpCorrelation in 2019-12-01-preview

65d9c1d

solankisamir changed the title ~~Diagnostic Contract update~~ Diagnostic Contract Fix Feb 1, 2020

pilor added the ARMReviewInProgress label Feb 4, 2020

pilor reviewed Feb 4, 2020

View reviewed changes

...agement/resource-manager/Microsoft.ApiManagement/preview/2019-12-01-preview/definitions.json Show resolved Hide resolved

pilor added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMReviewInProgress WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Feb 4, 2020

pilor approved these changes Feb 4, 2020

View reviewed changes

promoisha approved these changes Feb 4, 2020

View reviewed changes

allenjzhang merged commit 0603855 into Azure:master Feb 4, 2020

solankisamir mentioned this pull request Feb 7, 2020

Added support for DeveloperPortal and Open Api Json format Azure/azure-sdk-for-net#9844

Merged

ssripadham pushed a commit to ssripadham/azure-rest-api-specs that referenced this pull request Feb 21, 2020

Diagnostic Contract Fix (Azure#8271)

df03c1e

* Diagnostic Contract update * there is no enableHttpCorrelation in 2019-12-01-preview

00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020

Diagnostic Contract Fix (Azure#8271)

fc791a5

* Diagnostic Contract update * there is no enableHttpCorrelation in 2019-12-01-preview

Diagnostic Contract Fix #8271

Diagnostic Contract Fix #8271

Uh oh!

Conversation

solankisamir commented Jan 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

azure-pipelines bot commented Jan 30, 2020

Uh oh!

azure-pipelines bot commented Jan 30, 2020

Uh oh!

azure-pipelines bot commented Jan 30, 2020

Uh oh!

azure-pipelines bot commented Jan 30, 2020

Uh oh!

azure-pipelines bot commented Jan 30, 2020

Uh oh!

openapi-sdkautomation bot commented Jan 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-python - Release

Uh oh!

openapi-sdkautomation bot commented Jan 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-go - Release

Uh oh!

openapi-sdkautomation bot commented Jan 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-net - Release

Uh oh!

openapi-sdkautomation bot commented Jan 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-js - Release

Uh oh!

openapi-sdkautomation bot commented Jan 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-java - Release

Uh oh!

azure-pipelines bot commented Jan 30, 2020

Uh oh!

azure-pipelines bot commented Feb 1, 2020

Uh oh!

azure-pipelines bot commented Feb 1, 2020

Uh oh!

azure-pipelines bot commented Feb 3, 2020

Uh oh!

Uh oh!

pilor left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

solankisamir commented Jan 30, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jan 30, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jan 30, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jan 30, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jan 30, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jan 30, 2020 •

edited

Loading