Skip to content

CosmosDB autopilot support #8428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
markcowl merged 3 commits into from
Feb 21, 2020
Merged

CosmosDB autopilot support #8428

markcowl merged 3 commits into from
Feb 21, 2020

Conversation

@ravgill
Copy link
Contributor

@ravgill ravgill commented Feb 19, 2020 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azure-pipelines
Copy link

azure-pipelines bot commented Feb 19, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Feb 19, 2020 •
edited
Loading

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 0f297a5 with merge commit 8e6104e. SDK Automation 13.0.17.20191226.1 
    [AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
  • ️✔️Microsoft.Azure.Management.CosmosDB [Logs]  [Release SDK Changes]
      No Artifact Generated.

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Feb 19, 2020 •
    edited
    Loading

    azure-sdk-for-go - Release

    ⌛ Pending...

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Feb 19, 2020 •
    edited
    Loading

    azure-sdk-for-js - Release

    ️✔️ succeeded [Logs] [Expand Details]
    • ️✔️ Generate from 0f297a5 with merge commit 8e6104e. SDK Automation 13.0.17.20191226.1
    • ️✔️@azure/arm-cosmosdb [Logs]  [Release SDK Changes] 
      [npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/cosmosDBManagementClient.js → ./dist/arm-cosmosdb.js...
[npmPack] created ./dist/arm-cosmosdb.js in 731ms

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Feb 19, 2020 •
    edited
    Loading

    azure-sdk-for-java - Release

    ️✔️ succeeded [Logs] [Expand Details]

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Feb 19, 2020 •
    edited
    Loading

    azure-sdk-for-python - Release

    ️✔️ succeeded [Logs] [Expand Details]

    This was referenced Feb 19, 2020
    Closed
    Closed
    Closed
    Closed
    Closed
    Closed
    @markcowl
    Copy link
    Member

    markcowl commented Feb 19, 2020

    @ravgill This spec needs a .Net readme file. Please add this.

    markcowl
    markcowl requested changes Feb 19, 2020
    View reviewed changes
    Copy link
    Member

    @markcowl markcowl left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Failing validation because there is no .net readme file for this spec - please add a .Net readme file.

    @markcowl markcowl assigned ravgill and unassigned markcowl Feb 19, 2020
    @ravgill ravgill requested review from MehaKaushik and shurd February 19, 2020 21:20
    @azure-pipelines
    Copy link

    azure-pipelines bot commented Feb 19, 2020

    Azure Pipelines successfully started running 1 pipeline(s).

    1 similar comment
    @azure-pipelines
    Copy link

    azure-pipelines bot commented Feb 19, 2020

    Azure Pipelines successfully started running 1 pipeline(s).

    @azure-pipelines
    Copy link

    azure-pipelines bot commented Feb 19, 2020

    Azure Pipelines successfully started running 1 pipeline(s).

    @openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Feb 19, 2020
    Closed
    @ravgill ravgill requested a review from markcowl February 19, 2020 23:05
    @ravgill
    Copy link
    Contributor Author

    ravgill commented Feb 20, 2020

    @markcowl can you please re-review this?

    @ravgill ravgill closed this Feb 20, 2020
    @shurd shurd added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 20, 2020
    @ravgill ravgill reopened this Feb 20, 2020
    @azure-pipelines
    Copy link

    azure-pipelines bot commented Feb 20, 2020

    Azure Pipelines successfully started running 1 pipeline(s).

    markcowl
    markcowl requested changes Feb 21, 2020
    View reviewed changes
    specification/cosmos-db/resource-manager/Microsoft.DocumentDB/stable/2019-12-12/cosmos-db.json
    },
    "required": [
    "throughput"
    "maxThroughput"
    Copy link
    Member

    @markcowl markcowl Feb 21, 2020

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    It looks like 'throughput is now not required for 'ThroughpoutSettingsResource', is that intentional, is this no longer a required property?

    Copy link
    Contributor Author

    @ravgill ravgill Feb 21, 2020

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Either "throughput" is required or "autopilotSettings" settings is required. Is there a some way to convey "requiredOneOf" @markcowl

    Copy link
    Member

    @markcowl markcowl Feb 21, 2020

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Unfortunately, not until Swagger 3. It is not a breakign change to remove 'required', but I would suggest documenting the fact that one of these are required in the description of the object and in the description for both parameters

    Copy link
    Contributor Author

    @ravgill ravgill Feb 21, 2020

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    @markcowl I have updated the description of the object and in the description for both parameters

    @markcowl
    Copy link
    Member

    markcowl commented Feb 21, 2020

    @ravgill One question, otherwise lgtm

    @azure-pipelines
    Copy link

    azure-pipelines bot commented Feb 21, 2020

    Azure Pipelines successfully started running 1 pipeline(s).

    @markcowl markcowl merged commit 8e6104e into Azure:master Feb 21, 2020
    00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
    @ravgill @00Kai0
    CosmosDB autopilot support (Azure#8428)
    7e87e77 
    * CosmosDB autopilot support

* add readme.csharp.md

* updated description in ThroughputSettingsResource
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    @markcowl markcowl markcowl approved these changes

    @shurd shurd Awaiting requested review from shurd

    +1 more reviewer

    @MehaKaushik MehaKaushik MehaKaushik approved these changes

    Reviewers whose approvals may not affect merge requirements

    Assignees

    @ravgill ravgill

    Labels

    WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    4 participants

    @ravgill @markcowl @MehaKaushik @shurd