Skip to content

[ACR] swagger updates for private links #8440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
weidongxu-microsoft merged 4 commits into from
Feb 20, 2020
Merged

[ACR] swagger updates for private links #8440

weidongxu-microsoft merged 4 commits into from
Feb 20, 2020

Conversation

@ankurkhemani
Copy link
Contributor

@ankurkhemani ankurkhemani commented Feb 19, 2020

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@azure-pipelines
Copy link

azure-pipelines bot commented Feb 19, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@ankurkhemani
Copy link
Contributor Author

ankurkhemani commented Feb 19, 2020

// cc @djyou @yugangw-msft

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Feb 19, 2020 •
edited
Loading

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from ead34e6 with merge commit 7f558a9. SDK Automation 13.0.17.20191226.1
  • ️✔️@azure/arm-containerregistry [Logs]  [Release SDK Changes] 
    [npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/containerRegistryManagementClient.js → ./dist/arm-containerregistry.js...
[npmPack] created ./dist/arm-containerregistry.js in 509ms

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Feb 19, 2020 •
edited
Loading

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from ead34e6 with merge commit 7f558a9. SDK Automation 13.0.17.20191226.1
  • ️✔️azure-mgmt-containerregistry [Logs]  [Release SDK Changes] 
    [after_scripts|python] WARNING:__main__:Found too much API version: {'2017-10-01', '2018-02-01-preview'} in label v2018_02_01_preview
[after_scripts|python] WARNING:__main__:Guessing you want 2018-02-01-preview based on label v2018_02_01_preview
[after_scripts|python] WARNING:__main__:Found too much API version: {'2017-10-01', '2018-09-01'} in label v2018_09_01
[after_scripts|python] WARNING:__main__:Guessing you want 2018-09-01 based on label v2018_09_01
[after_scripts|python] WARNING:__main__:Found too much API version: {'2017-10-01', '2019-04-01'} in label v2019_04_01
[after_scripts|python] WARNING:__main__:Guessing you want 2019-04-01 based on label v2019_04_01
[after_scripts|python] WARNING:__main__:Found too much API version: {'2019-04-01', '2019-05-01'} in label v2019_05_01
[after_scripts|python] WARNING:__main__:Guessing you want 2019-05-01 based on label v2019_05_01
[after_scripts|python] WARNING:__main__:Found too much API version: {'2017-10-01', '2019-05-01-preview'} in label v2019_05_01_preview
[after_scripts|python] WARNING:__main__:Guessing you want 2019-05-01-preview based on label v2019_05_01_preview
[after_scripts|python] WARNING:__main__:Found too much API version: {'2019-06-01-preview', '2019-05-01-preview', '2019-05-01'} in label v2019_06_01_preview
[after_scripts|python] WARNING:__main__:Guessing you want 2019-06-01-preview based on label v2019_06_01_preview
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Feb 19, 2020 •
edited
Loading

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Feb 19, 2020 •
edited
Loading

azure-sdk-for-java - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Feb 19, 2020 •
edited
Loading

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Feb 19, 2020
Closed
@openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Feb 19, 2020
Closed
@azure-pipelines
Copy link

azure-pipelines bot commented Feb 19, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@weidongxu-microsoft weidongxu-microsoft added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 20, 2020
@azure-pipelines
Copy link

azure-pipelines bot commented Feb 20, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@ankurkhemani ankurkhemani changed the title swagger updates for private links [ACR] swagger updates for private links Feb 20, 2020
@azure-pipelines
Copy link

azure-pipelines bot commented Feb 20, 2020

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

azure-pipelines bot commented Feb 20, 2020

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Feb 20, 2020
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@openapi-sdkautomation openapi-sdkautomation bot mentioned this pull request Feb 20, 2020
Closed
@ankurkhemani ankurkhemani force-pushed the ankheman/privatelink-updates branch from cc1ca9c to ead34e6 Compare February 20, 2020 04:58
@azure-pipelines
Copy link

azure-pipelines bot commented Feb 20, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@ravbhatnagar
Copy link
Contributor

ravbhatnagar commented Feb 20, 2020

The modelling for privateEndpointconnections and privatelinkresources is in line with the recommended pattern. I think multiple SQL RPs have implemented it like this. Signing off from ARM side.

@ravbhatnagar ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Feb 20, 2020
@weidongxu-microsoft weidongxu-microsoft merged commit 7f558a9 into Azure:master Feb 20, 2020
ssripadham pushed a commit to ssripadham/azure-rest-api-specs that referenced this pull request Feb 21, 2020
@ankurkhemani @ssripadham
[ACR] swagger updates for private links (Azure#8440)
428efef 
* swagger updates for private links

* some naming fixes

* add examples

* some schema updates
00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
@ankurkhemani @00Kai0
[ACR] swagger updates for private links (Azure#8440)
b1d955d 
* swagger updates for private links

* some naming fixes

* add examples

* some schema updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@djyou djyou Awaiting requested review from djyou

1 more reviewer

@yugangw-msft yugangw-msft yugangw-msft approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@weidongxu-microsoft weidongxu-microsoft

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ankurkhemani @ravbhatnagar @yugangw-msft @weidongxu-microsoft