Skip to content

Conversation

@metacpp
Copy link
Contributor

@metacpp metacpp commented Feb 28, 2020

If you are a MSFT employee you can view your work branch via this link.

Contribution checklist:


This change is Reviewable

Fix the sequence change.

Fix the example issues.

Fix the example issues.

Remove readonly parameters in examples.

Remove readonly parameters in examples.

Remove non-steeltoe changes.
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@metacpp metacpp changed the title [Hub Generated] Review request for Microsoft.AppPlatform to add version preview/2019-05-01-preview [Hub Generated] [DO NOT MERGE !!!! ]Review request for Microsoft.AppPlatform to add version preview/2019-05-01-preview Feb 28, 2020
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Feb 28, 2020

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Feb 28, 2020

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 2c63540 with merge commit 512f342. SDK Automation 13.0.17.20200807.2
  • ️✔️@azure/arm-appplatform [View full logs]  [Release SDK Changes]
    Only show 100 items here, please refer to log for details.
    [npmPack] npm WARN deprecated [email protected]: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
    [npmPack] npm WARN deprecated [email protected]: https://github.com/lydell/resolve-url#deprecated
    [npmPack] npm WARN deprecated [email protected]: Please see https://github.com/lydell/urix#deprecated
    [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
    [npmPack] loaded rollup.config.js with warnings
    [npmPack] (!) Unused external imports
    [npmPack] default imported from external module 'rollup' but never used
    [npmPack] 
    [npmPack] ./esm/appPlatformManagementClient.js → ./dist/arm-appplatform.js...
    [npmPack] created ./dist/arm-appplatform.js in 523ms
    [npmPack] npm notice 
    [npmPack] npm notice package: @azure/[email protected]
    [npmPack] npm notice === Tarball Contents === 
    [npmPack] npm notice 2.3kB   esm/appPlatformManagementClient.js             
    [npmPack] npm notice 2.7kB   esm/appPlatformManagementClientContext.js      
    [npmPack] npm notice 13.5kB  esm/operations/apps.js                         
    [npmPack] npm notice 1.1kB   esm/models/appsMappers.js                      
    [npmPack] npm notice 212.0kB dist/arm-appplatform.js                        
    [npmPack] npm notice 67.9kB  dist/arm-appplatform.min.js                    
    [npmPack] npm notice 12.2kB  esm/operations/bindings.js                     
    [npmPack] npm notice 1.1kB   esm/models/bindingsMappers.js                  
    [npmPack] npm notice 9.0kB   esm/operations/certificates.js                 
    [npmPack] npm notice 1.1kB   esm/models/certificatesMappers.js              
    [npmPack] npm notice 7.0kB   esm/operations/configServers.js                
    [npmPack] npm notice 1.0kB   esm/models/configServersMappers.js             
    [npmPack] npm notice 12.5kB  esm/operations/customDomains.js                
    [npmPack] npm notice 1.1kB   esm/models/customDomainsMappers.js             
    [npmPack] npm notice 22.8kB  esm/operations/deployments.js                  
    [npmPack] npm notice 1.1kB   esm/models/deploymentsMappers.js               
    [npmPack] npm notice 345B    esm/models/index.js                            
    [npmPack] npm notice 687B    esm/operations/index.js                        
    [npmPack] npm notice 57.5kB  esm/models/mappers.js                          
    [npmPack] npm notice 7.3kB   esm/operations/monitoringSettings.js           
    [npmPack] npm notice 1.1kB   esm/models/monitoringSettingsMappers.js        
    [npmPack] npm notice 2.3kB   esm/operations/operations.js                   
    [npmPack] npm notice 560B    esm/models/operationsMappers.js                
    [npmPack] npm notice 3.5kB   esm/models/parameters.js                       
    [npmPack] npm notice 995B    rollup.config.js                               
    [npmPack] npm notice 1.7kB   esm/operations/runtimeVersions.js              
    [npmPack] npm notice 462B    esm/models/runtimeVersionsMappers.js           
    [npmPack] npm notice 17.2kB  esm/operations/services.js                     
    [npmPack] npm notice 1.2kB   esm/models/servicesMappers.js                  
    [npmPack] npm notice 2.3kB   esm/operations/skus.js                         
    [npmPack] npm notice 575B    esm/models/skusMappers.js                      
    [npmPack] npm notice 1.7kB   package.json                                   
    [npmPack] npm notice 457B    tsconfig.json                                  
    [npmPack] npm notice 993B    esm/appPlatformManagementClient.d.ts.map       
    [npmPack] npm notice 1.4kB   esm/appPlatformManagementClient.js.map         
    [npmPack] npm notice 521B    esm/appPlatformManagementClientContext.d.ts.map
    [npmPack] npm notice 1.4kB   esm/appPlatformManagementClientContext.js.map  
    [npmPack] npm notice 3.9kB   esm/operations/apps.d.ts.map                   
    [npmPack] npm notice 6.7kB   esm/operations/apps.js.map                     
    [npmPack] npm notice 596B    esm/models/appsMappers.d.ts.map                
    [npmPack] npm notice 609B    esm/models/appsMappers.js.map                  
    [npmPack] npm notice 395.7kB dist/arm-appplatform.js.map                    
    [npmPack] npm notice 56.1kB  dist/arm-appplatform.min.js.map                
    [npmPack] npm notice 3.1kB   esm/operations/bindings.d.ts.map               
    [npmPack] npm notice 5.6kB   esm/operations/bindings.js.map                 
    [npmPack] npm notice 565B    esm/models/bindingsMappers.d.ts.map            
    [npmPack] npm notice 578B    esm/models/bindingsMappers.js.map              
    [npmPack] npm notice 2.4kB   esm/operations/certificates.d.ts.map           
    [npmPack] npm notice 4.2kB   esm/operations/certificates.js.map             
    [npmPack] npm notice 573B    esm/models/certificatesMappers.d.ts.map        
    [npmPack] npm notice 586B    esm/models/certificatesMappers.js.map          
    [npmPack] npm notice 1.6kB   esm/operations/configServers.d.ts.map          
    [npmPack] npm notice 3.1kB   esm/operations/configServers.js.map            
    [npmPack] npm notice 562B    esm/models/configServersMappers.d.ts.map       
    [npmPack] npm notice 575B    esm/models/configServersMappers.js.map         
    [npmPack] npm notice 3.1kB   esm/operations/customDomains.d.ts.map          
    [npmPack] npm notice 5.6kB   esm/operations/customDomains.js.map            
    [npmPack] npm notice 575B    esm/models/customDomainsMappers.d.ts.map       
    [npmPack] npm notice 588B    esm/models/customDomainsMappers.js.map         
    [npmPack] npm notice 5.6kB   esm/operations/deployments.d.ts.map            
    [npmPack] npm notice 10.3kB  esm/operations/deployments.js.map              
    [npmPack] npm notice 584B    esm/models/deploymentsMappers.d.ts.map         
    [npmPack] npm notice 597B    esm/models/deploymentsMappers.js.map           
    [npmPack] npm notice 26.1kB  esm/models/index.d.ts.map                      
    [npmPack] npm notice 357B    esm/operations/index.d.ts.map                  
    [npmPack] npm notice 126B    esm/models/index.js.map                        
    [npmPack] npm notice 372B    esm/operations/index.js.map                    
    [npmPack] npm notice 3.3kB   esm/models/mappers.d.ts.map                    
    [npmPack] npm notice 32.3kB  esm/models/mappers.js.map                      
    [npmPack] npm notice 1.6kB   esm/operations/monitoringSettings.d.ts.map     
    [npmPack] npm notice 3.1kB   esm/operations/monitoringSettings.js.map       
    [npmPack] npm notice 572B    esm/models/monitoringSettingsMappers.d.ts.map  
    [npmPack] npm notice 585B    esm/models/monitoringSettingsMappers.js.map    
    [npmPack] npm notice 1.0kB   esm/operations/operations.d.ts.map             
    [npmPack] npm notice 1.4kB   esm/operations/operations.js.map               
    [npmPack] npm notice 277B    esm/models/operationsMappers.d.ts.map          
    [npmPack] npm notice 290B    esm/models/operationsMappers.js.map            
    [npmPack] npm notice 822B    esm/models/parameters.d.ts.map                 
    [npmPack] npm notice 2.7kB   esm/models/parameters.js.map                   
    [npmPack] npm notice 679B    esm/operations/runtimeVersions.d.ts.map        
    [npmPack] npm notice 921B    esm/operations/runtimeVersions.js.map          
    [npmPack] npm notice 215B    esm/models/runtimeVersionsMappers.d.ts.map     
    [npmPack] npm notice 228B    esm/models/runtimeVersionsMappers.js.map       
    [npmPack] npm notice 5.6kB   esm/operations/services.d.ts.map               
    [npmPack] npm notice 9.1kB   esm/operations/services.js.map                 
    [npmPack] npm notice 614B    esm/models/servicesMappers.d.ts.map            
    [npmPack] npm notice 627B    esm/models/servicesMappers.js.map              

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Feb 28, 2020

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Feb 28, 2020

azure-sdk-for-java - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Feb 28, 2020

azure-sdk-for-python - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 2c63540 with merge commit 512f342. SDK Automation 13.0.17.20200807.2
    [azure-mgmt-appplatform][ChangeLog] WARNING: Failed to generate ChangeLog.
  • ⚠️azure-mgmt-appplatform [View full logs]  [Release SDK Changes]
    [build_conf] INFO:packaging_tools:Building template azure-mgmt-appplatform
    [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
    [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
    [build_conf] INFO:packaging_tools:Template done azure-mgmt-appplatform
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
    [build_package]   warnings.warn(msg)
    [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
    Not exact 2 reports found:
    code_reports/0.1.0/report.json
    code_reports/latest/merged_report.json
    code_reports/latest/v2019_05_01_preview.json
    code_reports/latest/v2020_07_01.json
    Not generating changelog.
    [ChangeLog] WARNING: Failed to generate ChangeLog.

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@ArcturusZhang ArcturusZhang added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Mar 2, 2020
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

3 similar comments
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@metacpp metacpp closed this Mar 10, 2020
@ArcturusZhang
Copy link
Member

Hi @metacpp any updates?

@ArcturusZhang
Copy link
Member

Hi @metacpp do we have any update?

@ArcturusZhang
Copy link
Member

Closing this PR since no response for quite a long time.
@metacpp please feel free to reopen when you get back, thank you

@metacpp
Copy link
Contributor Author

metacpp commented Jul 8, 2020

@ArcturusZhang : please don't delete the remote branch, thanks.

@ArcturusZhang
Copy link
Member

@ArcturusZhang : please don't delete the remote branch, thanks.

No problem and since it is in your fork, I actually do not have the permission to delete

@metacpp metacpp reopened this Aug 21, 2020
@openapi-pipeline-app
Copy link

Swagger pipeline started successfully, please wait for status update in this comment.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 21, 2020

[Staging] Swagger Validation Report

BreakingChange: 6 Errors, 0 Warnings [Detail] [Expand]
Rule Message
1020 - AddedEnumValue The new version is adding enum value(s) 'NetCore_31' from the old version.
New: Microsoft.AppPlatform/preview/2019-05-01-preview/appplatform.json#L3287:9
Old: Microsoft.AppPlatform/preview/2019-05-01-preview/appplatform.json#L3249:9
1020 - AddedEnumValue The new version is adding enum value(s) 'NetCoreZip' from the old version.
New: Microsoft.AppPlatform/stable/2020-07-01/appplatform.json#L3699:9
Old: Microsoft.AppPlatform/stable/2020-07-01/appplatform.json#L3666:9
1020 - AddedEnumValue The new version is adding enum value(s) 'NetCoreZip' from the old version.
New: Microsoft.AppPlatform/preview/2019-05-01-preview/appplatform.json#L3223:9
Old: Microsoft.AppPlatform/preview/2019-05-01-preview/appplatform.json#L3190:9
1020 - AddedEnumValue The new version is adding enum value(s) 'NetCore_31' from the old version.
New: Microsoft.AppPlatform/stable/2020-07-01/appplatform.json#L3757:9
Old: Microsoft.AppPlatform/stable/2020-07-01/appplatform.json#L3719:9
1041 - AddedPropertyInResponse The new version has a new property 'netCoreMainEntryPath' in response that was not found in the old version.
New: Microsoft.AppPlatform/preview/2019-05-01-preview/appplatform.json#L3253:7
Old: Microsoft.AppPlatform/preview/2019-05-01-preview/appplatform.json#L3219:7
1041 - AddedPropertyInResponse The new version has a new property 'netCoreMainEntryPath' in response that was not found in the old version.
New: Microsoft.AppPlatform/stable/2020-07-01/appplatform.json#L3729:7
Old: Microsoft.AppPlatform/stable/2020-07-01/appplatform.json#L3695:7
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
️✔️ModelValidation [Detail]
 Validation passes for ModelValidation. 
️✔️SemanticValidation [Detail]
 Validation passes for SemanticValidation. 
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@metacpp metacpp changed the title [Hub Generated] [DO NOT MERGE !!!! ]Review request for Microsoft.AppPlatform to add version preview/2019-05-01-preview Steeltoe support in Microsoft.AppPlatform Aug 21, 2020
@metacpp metacpp requested a review from bowen5 August 21, 2020 05:39
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 21, 2020

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 21, 2020

azure-resource-manager-schemas - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from 2c63540 with merge commit 512f342. Schema Automation 13.0.17.20200807.2
  • ️✔️appplatform [View full logs]  [Release Schema Changes]
      [after_scripts|node] PostProcessor finished successfully.
      [after_scripts|node]   5621 passing (1m)
      AzureResourceSchema has no registered package commands.

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Aug 21, 2020

    Trenton Generation - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Aug 21, 2020

    azure-sdk-for-python-track2 - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @metacpp
    Copy link
    Contributor Author

    metacpp commented Aug 21, 2020

    @ArcturusZhang : can you help on the PR ?

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @metacpp metacpp changed the title Steeltoe support in Microsoft.AppPlatform .NET support in Microsoft.AppPlatform Aug 22, 2020
    @ArcturusZhang
    Copy link
    Member

    Approve breaking changes since this is preview api-version within one year

    @ArcturusZhang ArcturusZhang added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Aug 22, 2020
    @ArcturusZhang ArcturusZhang removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Aug 25, 2020
    @ArcturusZhang ArcturusZhang merged commit 512f342 into Azure:master Aug 25, 2020
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    5 participants