Skip to content

[Logic App Integration Account][Bug Fix] : Swagger spec updated as per the latest changes in the RP … #891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amarzavery merged 8 commits into from
Feb 14, 2017
Merged

[Logic App Integration Account][Bug Fix] : Swagger spec updated as per the latest changes in the RP … #891

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
af574d2
[Bug Fix] : Swagger spec updated as per the latest changes in the RP …
pankajsn Jan 30, 2017
e7a7947
ID, Name, Type properties are set to read only in IntegrationAccountR…
pankajsn Feb 1, 2017
18f2c56
Fixed linter warning regarding missing description for model types
pankajsn Feb 2, 2017
0ec6bdc
Resolved Autorest linter validation warnings
pankajsn Feb 8, 2017
7089d50
Resolved NonAppJsonTypeWarning
pankajsn Feb 8, 2017
75076ce
Fixed code review comments reg. naming conv. & required, read-only at…
pankajsn Feb 10, 2017
573ddb3
Fixed code review comments
pankajsn Feb 11, 2017
ecc34b7
Space removed from the comment
pankajsn Feb 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Resolved Autorest linter validation warnings
  • Loading branch information
@pankajsn
pankajsn committed Feb 8, 2017
commit 0ec6bdcc4d8658dfa33b6d929ab7198dd54d85c7
98 changes: 98 additions & 0 deletions arm-logic/2016-06-01/swagger/logic.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2479,21 +2479,56 @@
}
}
}
},
"/providers/Microsoft.Logic/operations": {
"get": {
"tags": [
"Operations"
],

"description": "Lists all of the available Logic REST API operations.",
"operationId": "ListOperations",
"parameters": [
{
"$ref": "#/parameters/api-version"
}
],
"responses": {
"200": {
"description": "OK. The request has succeeded.",
"schema": {
"$ref": "#/definitions/OperationListResult"
}
},
"default": {
"description": "Logic error response describing why the operation failed.",
"schema": {
"$ref": "#/definitions/ErrorResponse"
}
}
},
"x-ms-pageable": {
"nextLinkName": "nextLink"
}
}
}
},
"definitions": {
"Resource": {
Copy link
Contributor

@amarzavery amarzavery Feb 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pankajsn There is an issue #898 reported by a customer which is correct. Can you please resolve this issue, by accurately representing the properties of "Resource" "readOnly": true.

  • "id", "name" and "type" should be marked "readOnly": true as per ARM guidelines.
  • Shouldn't "location" be a required property "required": ["location"]?

"properties": {
"id": {
"type": "string",
"readOnly": true,
"description": "The resource id."
},
"name": {
"type": "string",
"readOnly": true,
"description": "Gets the resource name."
},
"type": {
"type": "string",
"readOnly": true,
"description": "Gets the resource type."
},
"location": {
Copy link
Contributor

@amarzavery amarzavery Feb 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about location being required?

Copy link
Contributor Author

@pankajsn pankajsn Feb 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not required as described in RP definitions

Expand Down Expand Up @@ -3275,6 +3310,9 @@
},
"Sku": {
"type": "object",
"required": [
"name"
],
"properties": {
"name": {
"$ref": "#/definitions/SkuName",
Expand Down Expand Up @@ -4020,6 +4058,9 @@
},
"IntegrationAccountSku": {
"type": "object",
"required": [
"name"
],
"properties": {
"name": {
"$ref": "#/definitions/IntegrationAccountSkuName",
Expand Down Expand Up @@ -6058,6 +6099,63 @@
}
},
"description": "The reference to the key vault key."
},
"Operation": {
"description": "Logic REST API operation",
"type": "object",
"properties": {
"name": {
"description": "Operation name: {provider}/{resource}/{operation}",
"type": "string"
},
"display": {
"description": "The object that represents the operation.",
"properties": {
"provider": {
"description": "Service provider: Microsoft.Logic",
"type": "string"
},
"resource": {
"description": "Resource on which the operation is performed: Profile, endpoint, etc.",
"type": "string"
},
"operation": {
"description": "Operation type: Read, write, delete, etc.",
"type": "string"
}
}
}
}
},
"OperationListResult": {
"description": "Result of the request to list Logic operations. It contains a list of operations and a URL link to get the next set of results.",
"properties": {
"value": {
"type": "array",
"items": {
"$ref": "#/definitions/Operation"
},
"description": "List of Logic operations supported by the Logic resource provider."
},
"nextLink": {
"type": "string",
"description": "URL to get the next set of operation list results if there are any."
}
}
},
"ErrorResponse": {
"description": "Error reponse indicates Logic service is not able to process the incoming request. The reason is provided in the error message.",
"type": "object",
"properties": {
"code": {
"description": "Error code.",
"type": "string"
},
"message": {
"description": "Error message indicating why the operation failed.",
"type": "string"
}
}
}
},
"parameters": {
Expand Down