Skip to content

Sync eng/common directory with azure-sdk-tools for PR 8602 #1635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scbedd merged 9 commits into from
Jul 18, 2024
Merged

Sync eng/common directory with azure-sdk-tools for PR 8602 #1635

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7120e0e
original draft of the adjustments. definitely going to be some discus…
scbedd Jul 10, 2024
1ab794a
admendments as suggested by Wes
scbedd Jul 15, 2024
d9b6d68
remove new function ref in common.ps1
scbedd Jul 15, 2024
70fbeba
remove debug statements
scbedd Jul 16, 2024
cd06bba
adjustments to call Save-Package-Properties from other eng/common calls
scbedd Jul 16, 2024
9158e20
just check for file under pkg folder
scbedd Jul 17, 2024
c2c0370
a debug value was left behind. remove it
scbedd Jul 17, 2024
617ffb0
Update eng/common/scripts/Save-Package-Properties.ps1
scbedd Jul 17, 2024
6c7221c
resolve the path always
scbedd Jul 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
a debug value was left behind. remove it
  • Loading branch information
@scbedd @azure-sdk
scbedd authored and azure-sdk committed Jul 17, 2024
commit c2c0370433549fbeaa601c03731888a293c6e89d
2 changes: 1 addition & 1 deletion eng/common/scripts/Package-Properties.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ function Get-PkgProperties
function Get-PrPkgProperties([string]$InputDiffJson) {
$packagesWithChanges = @()

$allPackageProperties = Get-AllPkgProperties -ServiceDirectory media
$allPackageProperties = Get-AllPkgProperties
$diff = Get-Content $InputDiffJson | ConvertFrom-Json
$targetedFiles = $diff.ChangedFiles

Expand Down