Skip to content

Added functionality to enable CRL checking for CURL on linux; added tests for this new functionality. #3923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LarryOsterman merged 61 commits into from
Sep 19, 2022
Merged

Added functionality to enable CRL checking for CURL on linux; added tests for this new functionality. #3923

Changes from 1 commit
Commits
Show all changes
61 commits
Select commit Hold shift + click to select a range
e216b97
Checkpoint
LarryOsterman Aug 29, 2022
5fd1af1
Checkpoint - Initial cut at Linux CRL validation
LarryOsterman Sep 1, 2022
856d8e6
First blush implementation for CRL validation on curl
LarryOsterman Sep 1, 2022
5faef70
windows build fixes
LarryOsterman Sep 1, 2022
4ec5ec5
more windows fixes
LarryOsterman Sep 1, 2022
467c0a3
Another windows build fix
LarryOsterman Sep 2, 2022
c47115e
Disable CRL test on Windows - negative test doesn't work
LarryOsterman Sep 2, 2022
a24888f
OpenSSL is linux only for test
LarryOsterman Sep 2, 2022
acdeed3
Enable detection of OSX in platform.hpp; Disable some tests on Mac
LarryOsterman Sep 6, 2022
16acb64
Don't set OpenSSL callback on OSX since it isn't supported; don't AV …
LarryOsterman Sep 6, 2022
200abe5
Corrected status code for 302 response
LarryOsterman Sep 6, 2022
c9d007d
Don't mingle connections with different CRL or root certificates
LarryOsterman Sep 6, 2022
eb0d005
Fixed stupid non-windows typo
LarryOsterman Sep 6, 2022
b2e468e
UT failures from curl cache changes
LarryOsterman Sep 6, 2022
87cd9ee
clang-format
LarryOsterman Sep 6, 2022
5401a80
Allow 302 errors when CRL validation enabled
LarryOsterman Sep 7, 2022
c6e6ee3
Added preliminary test for trusted root certificate
LarryOsterman Sep 7, 2022
b823ff8
Merge branch 'larryo/tlsrootcertificateoverride' of https://github.co…
LarryOsterman Sep 7, 2022
f27d1fe
Added test for root certificate
LarryOsterman Sep 7, 2022
06eda2c
clang-format
LarryOsterman Sep 7, 2022
c59eb51
RAII for STACK_OF(X509_CRL); better tests for CRL cache
LarryOsterman Sep 7, 2022
c684188
a different try at sk_x509_crl_new_null
LarryOsterman Sep 7, 2022
d1c387d
clang-format
LarryOsterman Sep 7, 2022
b0ec018
Added proxy server test (requires CA override)
LarryOsterman Sep 7, 2022
c622b87
Fixed challenges in test proxy test
LarryOsterman Sep 8, 2022
9761eb7
Added IsAlive proxy method to verify proxy server is running
LarryOsterman Sep 8, 2022
b2e64c4
Only disable proxy tests, not certificate tests when appropriate; sma…
LarryOsterman Sep 8, 2022
af85d45
Added playback test with proxy; changed scope of proxy tests
LarryOsterman Sep 8, 2022
d26198d
non-windows OSs use LF not CRLF on line endings
LarryOsterman Sep 8, 2022
08f44be
Temporarily disable test proxy checks on WinHTTP
LarryOsterman Sep 8, 2022
a3872e4
Removed some unused code in error dumping logic
LarryOsterman Sep 8, 2022
965939e
clang-format
LarryOsterman Sep 8, 2022
889cf8a
Tweaked code coverage numbers
LarryOsterman Sep 9, 2022
74ad967
Don't start the test proxy if we're not actually running tests (or if…
LarryOsterman Sep 9, 2022
5785944
template steps don't take contdition parameters
LarryOsterman Sep 9, 2022
cbdb9e3
template conditions don't include succeeded
LarryOsterman Sep 9, 2022
46c96ec
CHanged location of pretest/posttest check
LarryOsterman Sep 9, 2022
19c8d60
Added template parameter for enabling tests
LarryOsterman Sep 9, 2022
ac74904
Added template parameter for running tests
LarryOsterman Sep 9, 2022
de8e7fd
Explicitly set EnableTests parameter; propagate the parameter to live…
LarryOsterman Sep 9, 2022
86596d1
Better syntax for EnableTests conditional
LarryOsterman Sep 9, 2022
51e43d2
Try enabling tests differently
LarryOsterman Sep 9, 2022
a415248
Different syntax for string?
LarryOsterman Sep 9, 2022
17ac997
printf testing
LarryOsterman Sep 9, 2022
c1432af
Removed enable-tests parameter
LarryOsterman Sep 9, 2022
a65d6b3
fixed spelling of stepList
LarryOsterman Sep 9, 2022
de03f68
Expressions contain more than one field
LarryOsterman Sep 9, 2022
f7b1a75
Oops, left some debugging in
LarryOsterman Sep 9, 2022
8c8e237
Noise reduction
LarryOsterman Sep 9, 2022
ccb5c45
Added back missing line
LarryOsterman Sep 9, 2022
40af00b
Try disabling the test proxy test on winhttp in a different way
LarryOsterman Sep 9, 2022
5bc6487
Added support for root certificate validation for WinHTTP transport
LarryOsterman Sep 13, 2022
15d0f27
cspell
LarryOsterman Sep 13, 2022
288b91f
Fixed compilation error; moved some code around to improve error proc…
LarryOsterman Sep 13, 2022
7820fce
cspell
LarryOsterman Sep 13, 2022
2e98441
clang-format
LarryOsterman Sep 13, 2022
20ca2f4
Only check for peer certificate error on linux, not windows or mac
LarryOsterman Sep 13, 2022
adf5ebf
Add EnableCRL support to WinHTTP
LarryOsterman Sep 13, 2022
77d1c8d
Code review cleanup
LarryOsterman Sep 13, 2022
bba821d
clang-format; cspell
LarryOsterman Sep 13, 2022
d5d3256
Fixed code review comment from @benbp
LarryOsterman Sep 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
UT failures from curl cache changes
  • Loading branch information
@LarryOsterman
LarryOsterman committed Sep 6, 2022
commit b2e468e2d613da77529202c06ed1745bcab46dc2
14 changes: 8 additions & 6 deletions sdk/core/azure-core/test/ut/curl_connection_pool_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ namespace Azure { namespace Core { namespace Test {
Azure::Core::Http::Request req(
Azure::Core::Http::HttpMethod::Get, Azure::Core::Url(AzureSdkHttpbinServer::Get()));
std::string const expectedConnectionKey(CreateConnectionKey(
AzureSdkHttpbinServer::Schema(), AzureSdkHttpbinServer::Host(), ",0,0,0,0,1,1,0,0"));
AzureSdkHttpbinServer::Schema(), AzureSdkHttpbinServer::Host(), ",0,0,0,0,1,1,0,0,0,0"));

{
// Creating a new connection with default options
Expand Down Expand Up @@ -124,7 +124,7 @@ namespace Azure { namespace Core { namespace Test {

// Now test that using a different connection config won't re-use the same connection
std::string const secondExpectedKey = AzureSdkHttpbinServer::Schema() + "://"
+ AzureSdkHttpbinServer::Host() + ",0,0,0,0,1,0,0,200000";
+ AzureSdkHttpbinServer::Host() + ",0,0,0,0,1,0,0,0,0,200000";
{
// Creating a new connection with options
Azure::Core::Http::CurlTransportOptions options;
Expand Down Expand Up @@ -433,7 +433,9 @@ namespace Azure { namespace Core { namespace Test {
Azure::Core::Http::Request req(
Azure::Core::Http::HttpMethod::Get, Azure::Core::Url(authority));
std::string const expectedConnectionKey(CreateConnectionKey(
AzureSdkHttpbinServer::Schema(), AzureSdkHttpbinServer::Host(), ",0,0,0,0,1,1,0,0"));
AzureSdkHttpbinServer::Schema(),
AzureSdkHttpbinServer::Host(),
",0,0,0,0,1,1,0,0,0,0"));

// Creating a new connection with default options
auto connection = Azure::Core::Http::_detail::CurlConnectionPool::g_curlConnectionPool
Expand Down Expand Up @@ -471,7 +473,7 @@ namespace Azure { namespace Core { namespace Test {
std::string const expectedConnectionKey(CreateConnectionKey(
AzureSdkHttpbinServer::Schema(),
AzureSdkHttpbinServer::Host(),
":443,0,0,0,0,1,1,0,0"));
":443,0,0,0,0,1,1,0,0,0,0"));

// Creating a new connection with default options
auto connection = Azure::Core::Http::_detail::CurlConnectionPool::g_curlConnectionPool
Expand Down Expand Up @@ -508,7 +510,7 @@ namespace Azure { namespace Core { namespace Test {
Azure::Core::Http::Request req(
Azure::Core::Http::HttpMethod::Get, Azure::Core::Url(authority));
std::string const expectedConnectionKey(CreateConnectionKey(
AzureSdkHttpbinServer::Schema(), AzureSdkHttpbinServer::Host(), ",0,0,0,0,1,1,0,0"));
AzureSdkHttpbinServer::Schema(), AzureSdkHttpbinServer::Host(), ",0,0,0,0,1,1,0,0,0,0"));

// Creating a new connection with default options
auto connection = Azure::Core::Http::_detail::CurlConnectionPool::g_curlConnectionPool
Expand Down Expand Up @@ -545,7 +547,7 @@ namespace Azure { namespace Core { namespace Test {
std::string const expectedConnectionKey(CreateConnectionKey(
AzureSdkHttpbinServer::Schema(),
AzureSdkHttpbinServer::Host(),
":443,0,0,0,0,1,1,0,0"));
":443,0,0,0,0,1,1,0,0,0,0"));

// Creating a new connection with default options
auto connection = Azure::Core::Http::_detail::CurlConnectionPool::g_curlConnectionPool
Expand Down