Disable warning C6387 coming from wil in win_http_transport due to SAL annotation #4132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahsonkhan
requested review from
LarryOsterman,
RickWinter,
antkmsft,
gearama and
vhvb1989
as code owners
Contributor
Author
|
/azp run cpp - storage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run cpp - core |
|
Azure Pipelines successfully started running 1 pipeline(s). |
14 tasks
LarryOsterman
approved these changes
Nov 28, 2022
Member
|
LGTM. And thank you. |
Contributor
Author
|
/azp run cpp - core |
|
Azure Pipelines successfully started running 1 pipeline(s). |
RickWinter
approved these changes
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4131
With the vcpkg baseline update of dependencies like
wil(from #4100), it introduced this warning (treated as error), which is causing nightly run pipelines to fail on Windows:https://learn.microsoft.com/en-us/cpp/code-quality/c6387?view=msvc-170
For example:
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=2013774&view=logs&j=d6204d4c-df7b-58eb-f6e9-300f4a1ec51a&t=9dd83b26-fa53-5361-4278-635b5975bfe8&l=128
Disabling it, similar to #4054