Skip to content

Move the connection back to the connection pool when HTTP error 404 was received #5308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antkmsft merged 2 commits into from
Feb 2, 2024
Merged

Move the connection back to the connection pool when HTTP error 404 was received #5308

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
95b4fe0
Move the connection back to the connection pool when HTTP error 404 w…
mchelnokov Feb 1, 2024
1642edc
Use symbolic name for 404 status code
mchelnokov Feb 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/core/azure-core/src/http/curl/curl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2133,7 +2133,7 @@ void CurlConnectionPool::MoveConnectionBackToPool(
{
auto code = static_cast<std::underlying_type<Http::HttpStatusCode>::type>(lastStatusCode);
// laststatusCode = 0
if (code < 200 || code >= 300)
if ((code < 200 || code >= 300) && code != 404)
{
// A handler with previous response with Error can't be re-use.
return;
Expand Down