Skip to content

For new surface area, classes marked as final should not have virtual methods. #5331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahsonkhan merged 8 commits into from
Feb 10, 2024
Merged

For new surface area, classes marked as final should not have virtual methods. #5331

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f49912e
Classes marked as final should not have virtual methods.
ahsonkhan Feb 8, 2024
49cef9d
Update changelog.
ahsonkhan Feb 8, 2024
a3b35f8
Address PR feedback and use named-macro.
ahsonkhan Feb 9, 2024
39d2333
Only use the macro for testing_build final classes.
ahsonkhan Feb 9, 2024
a7de704
Add a new compile definition _azure_TESTING_BUILD.
ahsonkhan Feb 9, 2024
d9a9333
Add test as a friend class and put the test in a Identity specific test
ahsonkhan Feb 9, 2024
8178da4
Remove the macro for final expansion since doxygen struggles with it.
ahsonkhan Feb 9, 2024
ed46fe1
Address PR feedback, add ifdef guard around _azure_VIRTUAL_FOR_TESTS.
ahsonkhan Feb 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Only use the macro for testing_build final classes.
  • Loading branch information
@ahsonkhan
ahsonkhan committed Feb 9, 2024
commit 39d2333d6a2de5c1f2fdb9587c161bf990aea5e9
3 changes: 1 addition & 2 deletions sdk/identity/azure-identity/inc/azure/identity/azure_cli_credential.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,7 @@ namespace Azure { namespace Identity {
/**
* @brief Options for configuring the #Azure::Identity::AzureCliCredential.
*/
struct AzureCliCredentialOptions _azure_NON_FINAL_FOR_TESTS
: public Core::Credentials::TokenCredentialOptions
struct AzureCliCredentialOptions final : public Core::Credentials::TokenCredentialOptions
{
/**
* @brief The ID of the tenant to which the credential will authenticate by default. If not
Expand Down