Skip to content

Remove the use of ifdef for TESTING_BUILD in KeyVault clients, where they are not needed. #5418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahsonkhan merged 1 commit into from
Mar 8, 2024
Merged

Remove the use of ifdef for TESTING_BUILD in KeyVault clients, where they are not needed. #5418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions ...ure-security-keyvault-certificates/inc/azure/keyvault/certificates/certificate_client.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,7 @@ namespace Azure { namespace Security { namespace KeyVault { namespace Certificat
*
* @details The client supports retrieving KeyVaultCertificate.
*/
class CertificateClient
#if !defined(TESTING_BUILD)
final
#endif
{
class CertificateClient final {
friend class CreateCertificateOperation;

#if defined(TESTING_BUILD)
Expand Down
6 changes: 1 addition & 5 deletions sdk/keyvault/azure-security-keyvault-secrets/inc/azure/keyvault/secrets/secret_client.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,7 @@ namespace Azure { namespace Security { namespace KeyVault { namespace Secrets {
* Vault. The client supports creating, retrieving, updating, deleting, purging, backing up,
* restoring, and listing the secret.
*/
class SecretClient
#if !defined(TESTING_BUILD)
final
#endif
{
class SecretClient final {

private:
// Using a shared pipeline for a client to share it with LRO (like delete key)
Expand Down