Skip to content

Sync eng/common directory with azure-sdk-tools for PR 8602 #5801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scbedd merged 9 commits into from
Jul 18, 2024
Merged

Sync eng/common directory with azure-sdk-tools for PR 8602 #5801

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ef8e42e
original draft of the adjustments. definitely going to be some discus…
scbedd Jul 10, 2024
81c37ac
admendments as suggested by Wes
scbedd Jul 15, 2024
6abe69b
remove new function ref in common.ps1
scbedd Jul 15, 2024
dfc8d5b
remove debug statements
scbedd Jul 16, 2024
55ff84f
adjustments to call Save-Package-Properties from other eng/common calls
scbedd Jul 16, 2024
2c17412
just check for file under pkg folder
scbedd Jul 17, 2024
cf599da
a debug value was left behind. remove it
scbedd Jul 17, 2024
f3873fd
Update eng/common/scripts/Save-Package-Properties.ps1
scbedd Jul 17, 2024
f4bf626
resolve the path always
scbedd Jul 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
adjustments to call Save-Package-Properties from other eng/common calls
  • Loading branch information
@scbedd @azure-sdk
scbedd authored and azure-sdk committed Jul 17, 2024
commit 55ff84fbcadc551aa424bcf779b8c42bba5ba6ac
2 changes: 1 addition & 1 deletion eng/common/pipelines/templates/steps/daily-dev-build-variable.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ steps:
inputs:
filePath: $(Build.SourcesDirectory)/eng/common/scripts/Save-Package-Properties.ps1
arguments: >
-ServiceDirectory ${{parameters.ServiceDirectory}}
-ServiceInput ${{parameters.ServiceDirectory}}
-OutDirectory $(Build.ArtifactStagingDirectory)/PackageInfo
pwsh: true
workingDirectory: $(Pipeline.Workspace)
Expand Down
2 changes: 1 addition & 1 deletion eng/common/scripts/Verify-RestApiSpecLocation.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ function Verify-PackageVersion() {
if (-not (Test-Path -Path $PackageInfoDirectory)) {
# Call Save-Package-Properties.ps1 script to generate package info json files
$savePropertiesScriptPath = Join-Path -Path $PSScriptRoot "Save-Package-Properties.ps1"
& $savePropertiesScriptPath -serviceDirectory $ServiceDirectory -outDirectory $PackageInfoDirectory
& $savePropertiesScriptPath -serviceInput $ServiceDirectory -outDirectory $PackageInfoDirectory
}
}
$pkgPropPath = Join-Path -Path $PackageInfoDirectory "$PackageName.json"
Expand Down