Skip to content

Conversation

@antkmsft
Copy link
Member

@antkmsft antkmsft commented Oct 1, 2024

Nothing urgent, it is just to update from the July SHA, we should do it periodically.
I want to merge this before the Core release, so that the change gets auto-pushed to the Betas registry with the release.

@antkmsft antkmsft self-assigned this Oct 1, 2024
@antkmsft antkmsft force-pushed the update-vcpkg-sha-2024-10-01 branch from f3748fd to db8dd76 Compare October 2, 2024 01:45
@Azure Azure deleted a comment from azure-pipelines bot Oct 2, 2024
@antkmsft
Copy link
Member Author

antkmsft commented Oct 2, 2024

/azp run cpp - attestation, cpp - core, cpp - eventhubs, cpp - identity, cpp - keyvault, cpp - storage, cpp - tables, cpp - template

@azure-pipelines
Copy link

Azure Pipelines successfully started running 8 pipeline(s).

@antkmsft antkmsft marked this pull request as ready for review October 2, 2024 06:51
@ahsonkhan
Copy link
Contributor

@antkmsft can you help me understand why we'd want to do this periodically? What's the outcome of updating the vcpkg baseline?
And how does it impact the beta registry?

@LarryOsterman
Copy link
Member

LarryOsterman commented Oct 2, 2024

@antkmsft can you help me understand why we'd want to do this periodically? What's the outcome of updating the vcpkg baseline? And how does it impact the beta registry?

Chiming in a bit: IMHO we should be updating the vcpkg baseline at least once every quarter and preferably once each month.

Otherwise, we are testing against older versions of our dependent packages. We've seen problems in the C++ repo caused by tools which are built from out-of-date packages.

In addition, while component governance is not currently validating vcpkg packages, they ARE adding support for vcpkg, which means we're going to be forced to update to newer versions of our dependent packages.

@antkmsft
Copy link
Member Author

antkmsft commented Oct 2, 2024

@ahsonkhan, Larry has put it very well. As of "how does it impact the beta registry" - there is a baseline in the vcpkg-configuration.json: https://github.com/Azure/azure-sdk-vcpkg-betas/blob/main/vcpkg-configuration.json#L4 . And each time we release, vcpkg-betas gets updated, and there is a functionality to take the vcpkg SHA from our repo and update vcpkg SHA in that vcpkg-configuration.json each time during the release (#5330).

@antkmsft antkmsft merged commit 5c9c445 into Azure:main Oct 2, 2024
@antkmsft antkmsft deleted the update-vcpkg-sha-2024-10-01 branch October 2, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants