Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: Azure/azure-sdk-for-go
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 7a87ba0
Choose a base ref
...
head repository: Azure/azure-sdk-for-go
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 08a640c
Choose a head ref
  • 2 commits
  • 3 files changed
  • 1 contributor

Commits on Dec 14, 2023

  1. test(azidentity): add unit test for doForClient function 

    The focus is on methods/behavior implemented by azidentity
package. I didn't aim to hit 100% coverage, mainly because
there are error paths determined by e.g. std http package etc.

Signed-off-by: HandsomeJack <dusek.honza@gmail.com>
    @handsomejack-42
    handsomejack-42 committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    58d19a1 View commit details
    Browse the repository at this point in the history

  2. fix(azidentity): do not strip away request headers in doForClient 

    Some authorities might require certain headers to be passed.

For example, in our dSTS auth flow, the request form contains
client_info, which needs to be accompanied by X-Client-SKU=MSAL.Go
header, else the API call produces

AADSTS501791: Client_info is only supported for MSAL/ADAL,
please ensure that MSAL/ADAL custom headers are being sent.

The `doForClient` function creates new `runtime.Request` from the incoming
request, but it fails to propagate the respective headers.

This commits is addressing that.

Signed-off-by: HandsomeJack <dusek.honza@gmail.com>
    @handsomejack-42
    handsomejack-42 committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    08a640c View commit details
    Browse the repository at this point in the history
Loading