Synchronize goroutines within GetToken #20367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhendrixMSFT
reviewed
Mar 8, 2023
jhendrixMSFT
reviewed
Mar 8, 2023
jhendrixMSFT
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sharing a credential instance among goroutines can produce redundant token requests because goroutines may race to populate the credential's cache. This PR refactors
GetToken()into two callbacks, one for silent auth (checking the cache) and one for requesting a new token, and adds a newsyncertype to synchronize them. (Credentials that don't distinguish checking the cache from requesting a token use the same method for both callbacks.) Credentials will allow only one goroutine to authenticate at a time, and waiting goroutines will check the cache again when they wake up. Closes #20044