Skip to content

create new sub directory #22177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tanyasethi-msft merged 15 commits into from
Dec 28, 2023
Merged

create new sub directory #22177

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
58a13f5
Implement NewSubdirectoryClient
adreed-msft Aug 31, 2023
7087900
Lowercase d in subDirectoryName
adreed-msft Aug 31, 2023
ce68d74
Make test recorded and add API calls
adreed-msft Aug 31, 2023
6b3121f
Extend testing
adreed-msft Sep 1, 2023
fa88352
Merge branch 'main' into feature/storage/azbfs/newsubdirectoryclient
adreed-msft Sep 14, 2023
f9b07da
Add recorded tests
adreed-msft Oct 10, 2023
3d65869
Merge remote-tracking branch 'origin/feature/storage/azbfs/newsubdire…
adreed-msft Oct 10, 2023
4b0c2f6
Update recorded test
adreed-msft Oct 11, 2023
0c4803e
doc
adreed-msft Oct 11, 2023
c01be82
Update assets.json
adreed-msft Oct 11, 2023
b83f5e4
Merge remote-tracking branch 'origin/feature/azdatalake/STG78-84' int…
tanyasethi-msft Dec 26, 2023
5314ca2
create subdirectory client
tanyasethi-msft Dec 26, 2023
07fbb17
changelog
tanyasethi-msft Dec 27, 2023
049cb2f
revert to unrecorded test
tanyasethi-msft Dec 27, 2023
498f22e
Merge branch 'feature/azdatalake/STG78-84' into feature/azdatalake/Cr…
tanyasethi-msft Dec 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Lowercase d in subDirectoryName 
Co-authored-by: Gauri Prasad <51212198+gapra-msft@users.noreply.github.com>
  • Loading branch information
@adreed-msft @gapra-msft
adreed-msft and gapra-msft committed Aug 31, 2023
commit 7087900d8471ee1d6c31cd3611fcd36844ccb0c9
6 changes: 3 additions & 3 deletions sdk/storage/azdatalake/directory/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,9 +227,9 @@ func (d *Client) NewFileClient(fileName string) (*file.Client, error) {
return (*file.Client)(base.NewPathClient(fileURL, newBlobURL, newBlobClient, d.generatedDirClientWithDFS().InternalClient().WithClientName(shared.FileClient), d.sharedKey(), d.identityCredential(), d.getClientOptions())), nil
}

func (d *Client) NewSubdirectoryClient(subDirectoryName string) (*Client, error) {
subDirectoryName = url.PathEscape(strings.TrimRight(subDirectoryName, "/"))
subDirectoryURL := runtime.JoinPaths(d.DFSURL(), subDirectoryName)
func (d *Client) NewSubdirectoryClient(subdirectoryName string) (*Client, error) {
subdirectoryName = url.PathEscape(strings.TrimRight(subdirectoryName, "/"))
subDirectoryURL := runtime.JoinPaths(d.DFSURL(), subdirectoryName)
newBlobURL, subDirectoryURL := shared.GetURLs(subDirectoryURL)
var newBlobClient *blockblob.Client
clientOptions := &blockblob.ClientOptions{ClientOptions: d.getClientOptions().ClientOptions}
Expand Down