Skip to content

Storage/fix Module Name in azfile, azdatalake, azblob #22273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tanyasethi-msft merged 8 commits into from
Jan 23, 2024
Merged

Storage/fix Module Name in azfile, azdatalake, azblob #22273

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0e0a926
fixModuleName adls
tanyasethi-msft Jan 18, 2024
01297cc
fixModuleName blob, file and test case
tanyasethi-msft Jan 18, 2024
95dc428
linter error
tanyasethi-msft Jan 18, 2024
803e8b2
test fix
tanyasethi-msft Jan 19, 2024
79337e3
azblob module name change
tanyasethi-msft Jan 19, 2024
2994deb
azblob
tanyasethi-msft Jan 19, 2024
6247571
azfile lint error fix
tanyasethi-msft Jan 19, 2024
7975f9a
comments address
tanyasethi-msft Jan 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
azblob
  • Loading branch information
@tanyasethi-msft
tanyasethi-msft committed Jan 19, 2024
commit 2994debac07114ef6bffce95e5b4e620b3177755
6 changes: 3 additions & 3 deletions sdk/storage/azblob/blob/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ func NewClient(blobURL string, cred azcore.TokenCredential, options *ClientOptio
conOptions := shared.GetClientOptions(options)
plOpts := runtime.PipelineOptions{PerRetry: []policy.Policy{authPolicy}}

azClient, err := azcore.NewClient(shared.BlobClient, exported.ModuleVersion, plOpts, &conOptions.ClientOptions)
azClient, err := azcore.NewClient(exported.ModuleName, exported.ModuleVersion, plOpts, &conOptions.ClientOptions)
if err != nil {
return nil, err
}
Expand All @@ -55,7 +55,7 @@ func NewClient(blobURL string, cred azcore.TokenCredential, options *ClientOptio
func NewClientWithNoCredential(blobURL string, options *ClientOptions) (*Client, error) {
conOptions := shared.GetClientOptions(options)

azClient, err := azcore.NewClient(shared.BlobClient, exported.ModuleVersion, runtime.PipelineOptions{}, &conOptions.ClientOptions)
azClient, err := azcore.NewClient(exported.ModuleName, exported.ModuleVersion, runtime.PipelineOptions{}, &conOptions.ClientOptions)
if err != nil {
return nil, err
}
Expand All @@ -71,7 +71,7 @@ func NewClientWithSharedKeyCredential(blobURL string, cred *SharedKeyCredential,
conOptions := shared.GetClientOptions(options)
plOpts := runtime.PipelineOptions{PerRetry: []policy.Policy{authPolicy}}

azClient, err := azcore.NewClient(shared.BlobClient, exported.ModuleVersion, plOpts, &conOptions.ClientOptions)
azClient, err := azcore.NewClient(exported.ModuleName, exported.ModuleVersion, plOpts, &conOptions.ClientOptions)
if err != nil {
return nil, err
}
Expand Down