[Release] sdk/resourcemanager/dataprotection/armdataprotection/4.0.0 #25275

jliusan · 2025-09-18T04:53:22Z

https://github.com/Azure/sdk-release-request/issues/6483

…generation from spec commit: ba6bab2e42a47a66de7df007a6811b19064f7344

Copilot

Pull Request Overview

This pull request releases version 4.0.0 of the Azure Data Protection SDK for Go. The update upgrades the SDK from API version 2024-04-01 to 2025-07-01, introducing new types, operations, and improvements while maintaining backward compatibility in most areas.

Key changes include:

Update to API version 2025-07-01 with new client generation tooling
Addition of new ADLS blob backup datasource parameters and validation operations
Enhanced operation responses with better structured response types
Improved error handling and documentation updates

Reviewed Changes

Copilot reviewed 87 out of 89 changed files in this pull request and generated 9 comments.

Show a summary per file

File	Description
version.go	Updates module version to v4.0.0
models.go	Adds new types like AdlsBlobBackupDatasourceParameters and ValidateForModifyBackupRequest
responses.go	Introduces new response types and removes inline JSON unmarshaling
*_client.go	Updates API version references and improves parameter handling
*_example_test.go	Updates examples with new response structures and subscription IDs

Copilot · 2025-09-18T04:55:08Z

sdk/resourcemanager/dataprotection/armdataprotection/time_rfc3339.go

+	if len(data) == 0 {
+		return nil
+	}


Magic number 0 should be replaced with a named constant for better code maintainability. Consider defining const emptyDataLength = 0 or use a more descriptive check like if data == nil || len(data) == 0.

Copilot · 2025-09-18T04:55:09Z

...resourcemanager/dataprotection/armdataprotection/restorabletimeranges_client_example_test.go

 	}
 	ctx := context.Background()
-	clientFactory, err := armdataprotection.NewClientFactory("<subscription-id>", cred, nil)
+	clientFactory, err := armdataprotection.NewClientFactory("04cf684a-d41f-4550-9f70-7708a3a2283b", cred, nil)


Hard-coded subscription ID in example code should be replaced with a placeholder like <subscription-id> to avoid potential security issues if this example is copied to production code.

Suggested change

clientFactory, err := armdataprotection.NewClientFactory("04cf684a-d41f-4550-9f70-7708a3a2283b", cred, nil)

clientFactory, err := armdataprotection.NewClientFactory("<subscription-id>", cred, nil)

Copilot · 2025-09-18T04:55:09Z

sdk/resourcemanager/dataprotection/armdataprotection/resourceguards_client_example_test.go

 	}
 	ctx := context.Background()
-	clientFactory, err := armdataprotection.NewClientFactory("<subscription-id>", cred, nil)
+	clientFactory, err := armdataprotection.NewClientFactory("0b352192-dcac-4cc7-992e-a96190ccc68c", cred, nil)


Hard-coded subscription ID in example code should be replaced with a placeholder like <subscription-id> to avoid potential security issues if this example is copied to production code.

Copilot · 2025-09-18T04:55:09Z

sdk/resourcemanager/dataprotection/armdataprotection/recoverypoints_client_example_test.go

+		log.Fatalf("failed to obtain a credential: %v", err)
+	}
+	ctx := context.Background()
+	clientFactory, err := armdataprotection.NewClientFactory("04cf684a-d41f-4550-9f70-7708a3a2283b", cred, nil)


Hard-coded subscription ID in example code should be replaced with a placeholder like <subscription-id> to avoid potential security issues if this example is copied to production code.

Suggested change

clientFactory, err := armdataprotection.NewClientFactory("04cf684a-d41f-4550-9f70-7708a3a2283b", cred, nil)

clientFactory, err := armdataprotection.NewClientFactory("<subscription-id>", cred, nil)

Copilot · 2025-09-18T04:55:09Z

.../dataprotection/armdataprotection/operationstatusresourcegroupcontext_client_example_test.go

 	}
 	ctx := context.Background()
-	clientFactory, err := armdataprotection.NewClientFactory("<subscription-id>", cred, nil)
+	clientFactory, err := armdataprotection.NewClientFactory("0b352192-dcac-4cc7-992e-a96190ccc68c", cred, nil)


Hard-coded subscription ID in example code should be replaced with a placeholder like <subscription-id> to avoid potential security issues if this example is copied to production code.

Suggested change

clientFactory, err := armdataprotection.NewClientFactory("0b352192-dcac-4cc7-992e-a96190ccc68c", cred, nil)

clientFactory, err := armdataprotection.NewClientFactory("<subscription-id>", cred, nil)

Copilot · 2025-09-18T04:55:10Z

...er/dataprotection/armdataprotection/operationstatusbackupvaultcontext_client_example_test.go

 	}
 	ctx := context.Background()
-	clientFactory, err := armdataprotection.NewClientFactory("<subscription-id>", cred, nil)
+	clientFactory, err := armdataprotection.NewClientFactory("0b352192-dcac-4cc7-992e-a96190ccc68c", cred, nil)


Hard-coded subscription ID in example code should be replaced with a placeholder like <subscription-id> to avoid potential security issues if this example is copied to production code.

Suggested change

clientFactory, err := armdataprotection.NewClientFactory("0b352192-dcac-4cc7-992e-a96190ccc68c", cred, nil)

clientFactory, err := armdataprotection.NewClientFactory("<subscription-id>", cred, nil)

Copilot · 2025-09-18T04:55:10Z

sdk/resourcemanager/dataprotection/armdataprotection/operationstatus_client_example_test.go

 	}
 	ctx := context.Background()
-	clientFactory, err := armdataprotection.NewClientFactory("<subscription-id>", cred, nil)
+	clientFactory, err := armdataprotection.NewClientFactory("0b352192-dcac-4cc7-992e-a96190ccc68c", cred, nil)


Hard-coded subscription ID in example code should be replaced with a placeholder like <subscription-id> to avoid potential security issues if this example is copied to production code.

Copilot · 2025-09-18T04:55:10Z

sdk/resourcemanager/dataprotection/armdataprotection/operationresult_client_example_test.go

 	}
 	ctx := context.Background()
-	clientFactory, err := armdataprotection.NewClientFactory("<subscription-id>", cred, nil)
+	clientFactory, err := armdataprotection.NewClientFactory("0b352192-dcac-4cc7-992e-a96190ccc68c", cred, nil)


Hard-coded subscription ID in example code should be replaced with a placeholder like <subscription-id> to avoid potential security issues if this example is copied to production code.

Suggested change

clientFactory, err := armdataprotection.NewClientFactory("0b352192-dcac-4cc7-992e-a96190ccc68c", cred, nil)

clientFactory, err := armdataprotection.NewClientFactory("<subscription-id>", cred, nil)

Copilot · 2025-09-18T04:55:10Z

sdk/resourcemanager/dataprotection/armdataprotection/jobs_client_example_test.go

+		log.Fatalf("failed to obtain a credential: %v", err)
+	}
+	ctx := context.Background()
+	clientFactory, err := armdataprotection.NewClientFactory("62b829ee-7936-40c9-a1c9-47a93f9f3965", cred, nil)


Hard-coded subscription ID in example code should be replaced with a placeholder like <subscription-id> to avoid potential security issues if this example is copied to production code.

Suggested change

clientFactory, err := armdataprotection.NewClientFactory("62b829ee-7936-40c9-a1c9-47a93f9f3965", cred, nil)

clientFactory, err := armdataprotection.NewClientFactory("<subscription-id>", cred, nil)

github-actions · 2025-09-18T04:58:37Z

API Change Check

APIView identified API level changes in this PR and created the following API reviews

sdk/resourcemanager/dataprotection/armdataprotection

jliusan · 2025-09-18T05:47:50Z

The breaking changes are introduced and approved in this PR, @jhendrixMSFT , please approve this major version release by adding label of Approved Major Version, thanks.

[Release] sdk/resourcemanager/dataprotection/armdataprotection/4.0.0 …

a952848

…generation from spec commit: ba6bab2e42a47a66de7df007a6811b19064f7344

Copilot AI review requested due to automatic review settings September 18, 2025 04:53

jliusan requested review from ArcturusZhang, JiaqiZhang-Dev, lirenhe and tadelesh as code owners September 18, 2025 04:53

github-actions bot added the Mgmt This issue is related to a management-plane library. label Sep 18, 2025

Copilot AI reviewed Sep 18, 2025

View reviewed changes

jliusan added BreakingChange Stable labels Sep 18, 2025

tadelesh closed this Sep 29, 2025

	clientFactory, err := armdataprotection.NewClientFactory("04cf684a-d41f-4550-9f70-7708a3a2283b", cred, nil)
	clientFactory, err := armdataprotection.NewClientFactory("<subscription-id>", cred, nil)

[Release] sdk/resourcemanager/dataprotection/armdataprotection/4.0.0 #25275

[Release] sdk/resourcemanager/dataprotection/armdataprotection/4.0.0 #25275

Uh oh!

Conversation

jliusan commented Sep 18, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Sep 18, 2025

API Change Check

Uh oh!

jliusan commented Sep 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants