Skip to content

add to module #7357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jhendrixMSFT merged 1 commit into from
Feb 18, 2020
Merged

add to module #7357

jhendrixMSFT merged 1 commit into from
Feb 18, 2020

Conversation

@jhendrixMSFT
Copy link
Member

@jhendrixMSFT jhendrixMSFT commented Feb 18, 2020

  • The purpose of this PR is explained in this or a referenced issue.
  • The PR does not update generated files.
  • The PR targets the latest branch.
  • Tests are included and/or updated for code changes.
  • Updates to CHANGELOG.md are included.
  • Apache v2 license headers are included in each file.

JeffreyRichter
JeffreyRichter reviewed Feb 18, 2020
View reviewed changes
catalinaperalta
catalinaperalta approved these changes Feb 18, 2020
View reviewed changes
Copy link
Member

@catalinaperalta catalinaperalta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the IntPtr, LGTM

@jhendrixMSFT jhendrixMSFT merged commit ebce288 into Azure:master Feb 18, 2020
@jhendrixMSFT jhendrixMSFT deleted the tomod branch February 18, 2020 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JeffreyRichter JeffreyRichter JeffreyRichter approved these changes

@catalinaperalta catalinaperalta catalinaperalta approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jhendrixMSFT @JeffreyRichter @catalinaperalta