Update CreationSource.java

[RaRe2604]

Null check on resourceType

[ghost]

Thank you for your contribution RaRe2604! We will review the pull request and get back to you soon.

[ghost]

All CLA requirements met.

[weidongxu-microsoft]

Hi @RaRe2604
Thanks for your contribution.

If the resource type is null, does it mean that the source resource ID/URI is not correctly provided?

Note that checkstyle requires 4 space indention.

[ERROR] /home/vsts/work/1/s/sdk/resourcemanager/azure-resourcemanager-compute/src/main/java/com/azure/resourcemanager/compute/models/CreationSource.java:37: 'if' child has incorrect indentation level 15, expected level should be 16. [Indentation]
[ERROR] /home/vsts/work/1/s/sdk/resourcemanager/azure-resourcemanager-compute/src/main/java/com/azure/resourcemanager/compute/models/CreationSource.java:40: 'if' child has incorrect indentation level 15, expected level should be 16. [Indentation]
[ERROR] /home/vsts/work/1/s/sdk/resourcemanager/azure-resourcemanager-compute/src/main/java/com/azure/resourcemanager/compute/models/CreationSource.java:41: 'if' has incorrect indentation level 15, expected level should be 16. [Indentation]
[ERROR] /home/vsts/work/1/s/sdk/resourcemanager/azure-resourcemanager-compute/src/main/java/com/azure/resourcemanager/compute/models/CreationSource.java:42: 'if' child has incorrect indentation level 18, expected level should be 20. [Indentation]
[ERROR] /home/vsts/work/1/s/sdk/resourcemanager/azure-resourcemanager-compute/src/main/java/com/azure/resourcemanager/compute/models/CreationSource.java:43: 'if rcurly' has incorrect indentation level 15, expected level should be 16. [Indentation]
[ERROR] /home/vsts/work/1/s/sdk/resourcemanager/azure-resourcemanager-compute/src/main/java/com/azure/resourcemanager/compute/models/CreationSource.java:44: 'if' has incorrect indentation level 15, expected level should be 16. [Indentation]
[ERROR] /home/vsts/work/1/s/sdk/resourcemanager/azure-resourcemanager-compute/src/main/java/com/azure/resourcemanager/compute/models/CreationSource.java:45: 'if' child has incorrect indentation level 18, expected level should be 20. [Indentation]
[ERROR] /home/vsts/work/1/s/sdk/resourcemanager/azure-resourcemanager-compute/src/main/java/com/azure/resourcemanager/compute/models/CreationSource.java:46: 'if rcurly' has incorrect indentation level 15, expected level should be 16. [Indentation]

[RaRe2604]

Hi @weidongxu-microsoft Thanks I'll take care of the style.

Yes, resourceType is not checked for null and can throw NullPointerException.
We must use String literals first (if we have one) to avoid NPE.

Example:
In the below code if we pass null to heyInfo, it will throw NPE

String heyInfo = "Hey";
heyInfo.equalsIgnoreCase("Hello World");

A simple tweak to avoid NPE

String heyInfo = "Hey";
"Hello World".equalsIgnoreCase(heyInfo);

[weidongxu-microsoft]

@RaRe2604
Sure. I asked to check that if you encountered the NPE, whether it helps more to continue the flow, or to throw an IllegalArgumentException. If you didn't encountered the NPE, it is fine.

As long as the checkstyle passes, we can merge the fix.

[RaRe2604]

@weidongxu-microsoft It will continue the flow.