[Communication] - Phone Numbers - Phone Numbers Redesign #19109

minnieliu · 2021-02-09T22:59:26Z

API View: https://apiview.dev/Assemblies/Review/300aa54ba60742b4890c4a0a0853fad9

hemanttanwar · 2021-02-09T23:53:16Z

sdk/communication/azure-communication-administration/CHANGELOG.md

Wondering why package name is not listed with dots i.e. azure.communication.phonenumbers ?

Fixed thank you

hemanttanwar · 2021-02-09T23:54:32Z

sdk/communication/azure-communication-phonenumbers/CHANGELOG.md

dots in package name ?

Fixed thank you

hemanttanwar · 2021-02-09T23:55:21Z

sdk/communication/azure-communication-phonenumbers/CHANGELOG.md

Could provide link to [README][path to readme]

Fixed thank you

hemanttanwar · 2021-02-10T00:00:22Z

sdk/communication/azure-communication-phonenumbers/pom.xml

you will add some coverage number in future as development progresses .

Fixed thank you

hemanttanwar · 2021-02-10T00:02:07Z

...phonenumbers/src/main/java/com/azure/communication/phonenumbers/PhoneNumbersAsyncClient.java

@throws: We normally document runtime exception. For example in this case NullPointerException . This apply to all the API below.

Fixed thank you

hemanttanwar · 2021-02-10T00:13:27Z

...phonenumbers/src/main/java/com/azure/communication/phonenumbers/PhoneNumbersAsyncClient.java

May be we can add a link for ISO spec 'https://www.iso.org/standard/72483.html' if it helps developer.

hemanttanwar · 2021-02-10T00:17:58Z

...phonenumbers/src/main/java/com/azure/communication/phonenumbers/PhoneNumbersAsyncClient.java

I see this is called from service response. Could this url be null ? Should this be validated so we do not throw NPE.

Thanks, I will add this, but we will likely remove this logic as there are plans to return the ids in the headers without having the parse.

hemanttanwar · 2021-02-10T00:23:18Z

...tion-phonenumbers/src/main/java/com/azure/communication/phonenumbers/PhoneNumbersClient.java

Some point in time you should put code snippet here to most used api, Like we do in other SDK. So developer can find example in their IDE.
This comment for both sync and async client.
Example
https://github.com/Azure/azure-sdk-for-java/blob/master/sdk/servicebus/azure-messaging-servicebus/src/main/java/com/azure/messaging/servicebus/ServiceBusReceiverAsyncClient.java#L61

hemanttanwar · 2021-02-10T00:23:54Z

...tion-phonenumbers/src/main/java/com/azure/communication/phonenumbers/PhoneNumbersClient.java

@throws : Documenting Runtime exception

Fixed thank you

hemanttanwar · 2021-02-10T00:27:48Z

...onenumbers/src/main/java/com/azure/communication/phonenumbers/PhoneNumbersClientBuilder.java

It is missing clientOptions(ClientOptions clientOptions) API

JianpingChen · 2021-02-10T00:49:47Z

Add phoneNumbers artifact to ci.yml

jbeauregardb · 2021-02-10T16:00:20Z

...c/test/java/com/azure/communication/phonenumbers/PhoneNumbersAsyncClientIntegrationTest.java

You may be missing the test for authenticating using managed identity

Added, thank you!

check-enforcer · 2021-02-10T18:18:30Z

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run java - [service] - ci

JianpingChen

Add to test coverage pom:

eng/jacoco-test-coverage/pom.xml

eng/versioning/version_client.txt

sdk/communication/azure-communication-administration/CHANGELOG.md

sdk/communication/azure-communication-phonenumbers/CHANGELOG.md

sdk/communication/azure-communication-phonenumbers/README.md

sdk/communication/azure-communication-phonenumbers/pom.xml

sdk/communication/azure-communication-phonenumbers/swagger/README.md

jbeauregardb

This is awesome! One step closer to GA

minnieliu · 2021-02-10T23:08:10Z

/azp run java - communication - tests

azure-pipelines · 2021-02-10T23:08:21Z

Azure Pipelines successfully started running 1 pipeline(s).

minnieliu · 2021-02-11T00:19:52Z

/azp run java - core - ci

azure-pipelines · 2021-02-11T00:20:07Z

Azure Pipelines successfully started running 1 pipeline(s).

minnieliu · 2021-02-11T22:40:30Z

/azp run java - core - ci

azure-pipelines · 2021-02-11T22:40:44Z

Azure Pipelines successfully started running 1 pipeline(s).

minnieliu requested review from a team, JianpingChen, ankitarorabit and danieljurek as code owners February 9, 2021 22:59

ghost added the Communication label Feb 9, 2021

minnieliu force-pushed the phonenumbers-redesign branch from 4bbb914 to 954c42d Compare February 9, 2021 23:02

minnieliu requested review from DominikMe, RezaJooyandeh and jbeauregardb February 9, 2021 23:06

minnieliu requested review from JimSuplizio, alzimmermsft, g2vinay, mitchdenny and samvaity as code owners February 9, 2021 23:18

hemanttanwar reviewed Feb 10, 2021

View reviewed changes

jbeauregardb reviewed Feb 10, 2021

View reviewed changes

minnieliu force-pushed the phonenumbers-redesign branch from ae861d5 to 3f5be07 Compare February 10, 2021 18:13

JianpingChen reviewed Feb 10, 2021

View reviewed changes

minnieliu force-pushed the phonenumbers-redesign branch from c8b29b8 to 0a7cc91 Compare February 10, 2021 19:50

minnieliu requested review from JonathanGiles, srnagar and weshaggard as code owners February 10, 2021 20:11

JianpingChen approved these changes Feb 10, 2021

View reviewed changes

jbeauregardb approved these changes Feb 10, 2021

View reviewed changes

Minnie Liu added 26 commits February 11, 2021 15:21

Initial phone number redesign

f2fe9e2

Update names

cf86559

WIP

bc25390

Setting some models as internal

ab99d3b

Extracting phone numbers from administration package

261def1

Updating README and CHANGELOG

239095a

Update README

0a52622

Address code review comments

6fb879f

Basic code implementation complete

8933812

Cleanup

c707e9b

Search Available LRO

5e34445

Complete the rest of the LROs

4347c30

live tests for async client

2de2008

Added tests for sync clients

494b859

Add swagger transforms

a4de716

Adding documents

f8ce7c8

Updating swagger changes

58ac3fd

Add to versioning

b737a7c

Fixing test sanitization

ff7dfae

Address code review comments

9d52442

Addressing code review comments for versioning

a85bb1c

Fix build

9100ad8

Fix build

27edd11

Updating readme

6b3da61

Swagger update WIP

60eb928

Fix recordings for new swagger

ae42c62

minnieliu force-pushed the phonenumbers-redesign branch from 7175a17 to ae42c62 Compare February 11, 2021 23:21

minnieliu merged commit 859713f into Azure:master Feb 12, 2021

[Communication] - Phone Numbers - Phone Numbers Redesign #19109

[Communication] - Phone Numbers - Phone Numbers Redesign #19109

Uh oh!

Conversation

minnieliu commented Feb 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JianpingChen commented Feb 10, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

check-enforcer bot commented Feb 10, 2021

What is Check Enforcer?

Why am I getting this message?

What should I do now?

What if I am onboarding a new service?

Uh oh!

JianpingChen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jbeauregardb left a comment

Choose a reason for hiding this comment

Uh oh!

minnieliu commented Feb 10, 2021

Uh oh!

azure-pipelines bot commented Feb 10, 2021

Uh oh!

minnieliu commented Feb 11, 2021

Uh oh!

azure-pipelines bot commented Feb 11, 2021

Uh oh!

minnieliu commented Feb 11, 2021

Uh oh!

azure-pipelines bot commented Feb 11, 2021

Uh oh!

Reviewers

Assignees

minnieliu commented Feb 9, 2021 •

edited

Loading