Added storage event sample #22946
Merged
Added storage event sample #22946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickle-msft
requested review from
alzimmermsft,
amishra-dev,
gapra-msft,
jaschrep-msft and
kasobol-msft
as code owners
ghost
added
the
sdk/storage/azure-storage-blob/src/samples/java/com/azure/storage/blob/StorageEventExample.java
Outdated
Show resolved
Hide resolved
| Update the RETRY_COUNT_CONTEXT to log retries. | ||
| */ | ||
| context.setData(HttpLoggingPolicy.RETRY_COUNT_CONTEXT, attempt + 1); | ||
| context.setData(HttpLoggingPolicy.RETRY_COUNT_CONTEXT, attempt); |
Member
There was a problem hiding this comment.
Was there a bug that was found having an off-by-one retry count? For example, the first retry used attempt = 2?
Contributor
Author
There was a problem hiding this comment.
That's correct. The first attempt was coming in as attempt = 2. Since this only affected some log statements and doesn't affect any sdk logic as far as I know, I didn't think it really needed to go in the changelog or anything. But I can add it if we decide that's preferable.
…age/blob/StorageEventExample.java Co-authored-by: Alan Zimmer <[email protected]>
gapra-msft
approved these changes
Jul 13, 2021
…k-for-java into StorageEventExample
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an example on how to mimic StorageEvent behavior from track 1
Resolves #5828