Regenerate OpenAI models without property required annotation#35336
Merged
srnagar merged 1 commit intoAzure:mainfrom Jun 6, 2023
Merged
Regenerate OpenAI models without property required annotation#35336srnagar merged 1 commit intoAzure:mainfrom
srnagar merged 1 commit intoAzure:mainfrom
Conversation
srnagar
requested review from
brandom-msft,
jpalvarezl and
mssfang
as code owners
Collaborator
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
mssfang
approved these changes
Jun 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regenerate with latest AutoRest version to update OpenAI models. These models now don't have
required = trueset for@JsonPropertyannotation. This relaxes the deserialization constraints on service responses (a difference in behavior between Azure OpenAI and OpenAI) that don't always send fields that are marked required in TypeSpec.