Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
69fad2a
Number lookup ga (#37719)
ericasp16 Jan 29, 2024
460abbe
Merge branch 'main' into ericasp/number-lookup-ga-staging
ericasp16 Feb 2, 2024
5ab2972
update generated code
ericasp16 Feb 15, 2024
2e5bae7
update test recordings
ericasp16 Feb 22, 2024
c6dcf56
update package to beta version
ericasp16 Feb 22, 2024
4742713
update service version
ericasp16 Feb 22, 2024
5486811
fix build issues
ericasp16 Feb 22, 2024
688ed2f
Merge branch 'main' into convert-number-lookup-ga-to-preview
ericasp16 Feb 22, 2024
b0c5ef8
fix linting issue
ericasp16 Feb 22, 2024
fa64221
t statusMerge branch 'convert-number-lookup-ga-to-preview' of https:/…
ericasp16 Feb 22, 2024
6b6674d
update to address comments, restore unintentionally modified tests
ericasp16 Mar 7, 2024
05a84ea
restore unintentionally modified tests
ericasp16 Mar 7, 2024
c3e3c7a
Merge branch 'main' into convert-number-lookup-ga-to-preview
ericasp16 Mar 7, 2024
26fc884
restore unintentionally modified tests
ericasp16 Mar 7, 2024
8168d9f
Merge brt status
ericasp16 Mar 7, 2024
8b796fb
fix version_client
ericasp16 Mar 7, 2024
5b25f95
fix import statements
ericasp16 Mar 11, 2024
69cdcf3
update test files
ericasp16 Mar 11, 2024
fe45ae2
update test files
ericasp16 Mar 11, 2024
99fc1b8
update test files
ericasp16 Mar 11, 2024
7d83d13
update searchOperatorInformation tests to redact phone number
ericasp16 Mar 12, 2024
45aac94
update with latest tests
ericasp16 Mar 12, 2024
4118d60
update tests and recordings
ericasp16 Mar 12, 2024
0d54adc
update test files to redact phoneNumbers in request body for searchOp…
ericasp16 Mar 13, 2024
0c9c76c
remove setters on return type fields
ericasp16 Mar 13, 2024
6c257f3
update based on API view comments
ericasp16 Mar 13, 2024
1027aba
fix build errors
ericasp16 Mar 13, 2024
c2938f9
fix sanitizers, update test recordings
ericasp16 Mar 14, 2024
b8e617e
update based on PR comments
ericasp16 Mar 14, 2024
90982e9
fix errors
ericasp16 Mar 14, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove setters on return type fields
  • Loading branch information
ericasp16 committed Mar 13, 2024
commit 0c9c76c5249a443cc91b447c5ce00452012095ea
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,14 @@

package com.azure.communication.phonenumbers.models;

import com.azure.core.annotation.Fluent;
import com.azure.communication.phonenumbers.implementation.models.Error;
import com.azure.core.annotation.Immutable;
import com.fasterxml.jackson.annotation.JsonProperty;
import java.time.OffsetDateTime;
import java.util.List;

/** The result of a phone number search operation. */
@Fluent
@Immutable
public final class PhoneNumberSearchResult {
/*
* The search id.
Expand Down Expand Up @@ -60,14 +61,14 @@ public final class PhoneNumberSearchResult {
/*
* The error code of the search.
*/
@JsonProperty(value = "errorCode")
@JsonProperty(value = "errorCode", access = JsonProperty.Access.WRITE_ONLY)
private Integer errorCode;

/*
* Mapping Error Messages to Codes
*/
@JsonProperty(value = "error")
private PhoneNumberSearchResultError error;
@JsonProperty(value = "error", access = JsonProperty.Access.WRITE_ONLY)
private Error error;

/**
* Get the searchId property: The search id.
Expand Down Expand Up @@ -143,34 +144,12 @@ public Integer getErrorCode() {
return this.errorCode;
}

/**
* Set the errorCode property: The error code of the search.
*
* @param errorCode the errorCode value to set.
* @return the PhoneNumberSearchResult object itself.
*/
public PhoneNumberSearchResult setErrorCode(Integer errorCode) {
this.errorCode = errorCode;
return this;
}

/**
* Get the error property: Mapping Error Messages to Codes.
*
* @return the error value.
*/
public PhoneNumberSearchResultError getError() {
public Error getError() {
return this.error;
}

/**
* Set the error property: Mapping Error Messages to Codes.
*
* @param error the error value to set.
* @return the PhoneNumberSearchResult object itself.
*/
public PhoneNumberSearchResult setError(PhoneNumberSearchResultError error) {
this.error = error;
return this;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,8 @@ directive:
$["properties"]["phoneNumberType"].readOnly = true;
$["properties"]["assignmentType"].readOnly = true;
$["properties"]["capabilities"].readOnly = true;
$["properties"]["error"].readOnly = true;
$["properties"]["errorCode"].readOnly = true;
```

### Rename PhoneNumberOperation to PhoneNumberRawOperation
Expand Down Expand Up @@ -231,6 +233,7 @@ directive:
where: $.definitions.PhoneNumberSearchResult.properties.error.x-ms-enum
transform: >
$["name"] = "PhoneNumberSearchResultError";
$[""].readOnly = true;
```

``` yaml
Expand Down