Fixed issue where CosmosDiagnosticsContext is null when diagnostics are sampled out. #39352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FabianMeiswinkel
requested review from
Pilchie,
aayush3011,
jeet1995,
kirankumarkolli,
kushagraThapar,
milismsft,
simorenoh and
xinlian12
as code owners
Member
Author
|
/azp run java - cosmos- tests |
|
No pipelines are associated with this pull request. |
sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/CosmosDiagnosticsE2ETest.java
Show resolved
Hide resolved
sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/util/CosmosPagedFlux.java
Show resolved
Hide resolved
kushagraThapar
approved these changes
Mar 21, 2024
Member
kushagraThapar
left a comment
kushagraThapar
left a comment
There was a problem hiding this comment.
LGTM, thanks @FabianMeiswinkel
Member
Author
|
/azp run java - cosmos- tests |
|
No pipelines are associated with this pull request. |
Member
Author
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
API change check API changes are not detected in this pull request. |
Member
Author
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jeet1995
approved these changes
Mar 22, 2024
Member
jeet1995
left a comment
jeet1995
left a comment
There was a problem hiding this comment.
LGTM on the latest changes - thanks!
Member
Author
|
Change feed split tests failing due to known flakiness |
Member
Author
|
/check-enforcer override |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When diagnostics are sampled out right now not even the CosmosDiagnosticsContext gets published. Instead sampling should only effect emitting diagnostics (calling DiagnosticsHandler) - but still allow apps to access the CosmosDiagnosticsContext.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines