Skip to content

Fix spring autoconfigure test #40980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
conniey merged 8 commits into from
Jul 8, 2024
Merged

Fix spring autoconfigure test #40980

conniey merged 8 commits into from
Jul 8, 2024

Conversation

@conniey
Copy link
Member

@conniey conniey commented Jul 2, 2024 •
edited
Loading

Description

  • Use mcr.microsoft.com to pull container image from.
  • Disable pulling of ryuk image and perform manual clean-up of container.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions bot added the azure-spring All azure-spring related issues label Jul 2, 2024
@azure-sdk
Copy link
Collaborator

azure-sdk commented Jul 2, 2024

API change check

API changes are not detected in this pull request.

@conniey conniey changed the title Specify Docker registry Fix spring autoconfigure test Jul 2, 2024
@conniey conniey force-pushed the spring-tests/container-fix branch from b1a8a3c to bda722f Compare July 3, 2024 22:04
@conniey conniey force-pushed the spring-tests/container-fix branch from 2c95b33 to 825e5ae Compare July 5, 2024 22:39
@conniey
Copy link
Member Author

conniey commented Jul 5, 2024

/azp run java - spring - tests

@azure-pipelines
Copy link

azure-pipelines bot commented Jul 5, 2024

Azure Pipelines successfully started running 1 pipeline(s).

@conniey conniey self-assigned this Jul 5, 2024
@conniey
Copy link
Member Author

conniey commented Jul 5, 2024

@Netyyyy Can you look over this PR?

@Netyyyy
Copy link
Member

Netyyyy commented Jul 8, 2024

/azp run java - spring - tests

@azure-pipelines
Copy link

azure-pipelines bot commented Jul 8, 2024

Azure Pipelines successfully started running 1 pipeline(s).

@conniey conniey merged commit 33c79f2 into Azure:main Jul 8, 2024
@conniey conniey deleted the spring-tests/container-fix branch July 8, 2024 16:37
conniey added a commit that referenced this pull request Jul 8, 2024
@conniey
Revert "Fix spring autoconfigure test (#40980)"
2d24525 
This reverts commit 33c79f2.
@conniey conniey mentioned this pull request Jul 8, 2024
Merged
conniey added a commit that referenced this pull request Jul 8, 2024
@conniey
Revert "Fix spring autoconfigure test (#40980)" (#41046)
8aa025d 
This reverts commit 33c79f2.
Netyyyy pushed a commit to Netyyyy/azure-sdk-for-java that referenced this pull request Jul 9, 2024
@conniey @Netyyyy
Fix spring autoconfigure test (Azure#40980)
cb900c3 
* Specify mcr registry to use.

* Fix spelling

* Manually take care of container lifecycle.

* Fix naming of variable.

* Adding console.writeline.

* move environment variable.

* Remove Disabled annotation

* Add prebuild step to set env variable.

(cherry picked from commit 33c79f2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vcolin7 vcolin7 vcolin7 left review comments

@anuchandy anuchandy anuchandy approved these changes

@saragluna saragluna saragluna approved these changes

@rujche rujche Awaiting requested review from rujche rujche is a code owner

@Netyyyy Netyyyy Awaiting requested review from Netyyyy Netyyyy is a code owner

@moarychan moarychan Awaiting requested review from moarychan moarychan is a code owner

Assignees

@conniey conniey

Labels

azure-spring All azure-spring related issues

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@conniey @azure-sdk @Netyyyy @anuchandy @vcolin7 @saragluna