Add Refresh On Support #41038
Merged
Add Refresh On Support #41038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
API change check API changes are not detected in this pull request. |
g2vinay
commented
Jul 8, 2024
...ntity/azure-identity/src/main/java/com/azure/identity/implementation/IdentityClientBase.java
Outdated
Show resolved
Hide resolved
g2vinay
requested review from
a team,
JonathanGiles,
Netyyyy,
alzimmermsft,
anuchandy,
billwert,
joshfree,
lmolkova,
moarychan,
mssfang,
rujche,
samvaity,
saragluna,
sjkwak,
srnagar and
vcolin7
as code owners
srnagar
reviewed
Jul 8, 2024
sdk/core/azure-core/src/main/java/com/azure/core/credential/AccessToken.java
Outdated
Show resolved
Hide resolved
sdk/core/azure-core/src/main/java/com/azure/core/credential/AccessToken.java
Outdated
Show resolved
Hide resolved
srnagar
approved these changes
Jul 9, 2024
billwert
reviewed
Jul 9, 2024
sdk/core/azure-core/src/test/java/com/azure/core/credential/TokenCacheTests.java
Show resolved
Hide resolved
billwert
reviewed
Jul 9, 2024
sdk/identity/azure-identity/src/main/java/com/azure/identity/implementation/MSIToken.java
Outdated
Show resolved
Hide resolved
billwert
reviewed
Jul 9, 2024
sdk/identity/azure-identity/src/main/java/com/azure/identity/implementation/MSIToken.java
Outdated
Show resolved
Hide resolved
billwert
reviewed
Jul 9, 2024
sdk/identity/azure-identity/src/main/java/com/azure/identity/implementation/MSIToken.java
Outdated
Show resolved
Hide resolved
billwert
approved these changes
Jul 9, 2024
Contributor
billwert
left a comment
billwert
left a comment
There was a problem hiding this comment.
None of my comments are blocking so approving, but please consider. :)
anuchandy
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces getRefreshAt on AccessToken.
Updates Az Identity to popuate the AccessToken property in token response.
Updates the AccessTokenCache to honour the refreshOn information.