sdkautomation config, remove scriptError #41039
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In dpg sdk automation, we have logic
The first try failure should not count as generation failure. We should only rely on the "result" field and return code of the script.

Thus, this PR removes
scriptErrorfrom swagger_to_sdk_config.json.Another thing is, the generate script status shouldn't rely on
showInCommentslogs:test-repo-billy/azure-rest-api-specs#3398
Alternative attempt to use different log when trying for the first time: main...XiaofeiCao:azure-sdk-for-java:sdkautomation_try_generate
Though it's still strange to infer generation status from log content.
@raych1 Let us know if you have any concern.
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines