Skip to content

Conversation

@XiaofeiCao
Copy link
Contributor

@XiaofeiCao XiaofeiCao commented Jul 8, 2024

Description

In dpg sdk automation, we have logic

  1. Try generating from TypeSpec
  2. If failed and migrate from swagger, delete folder and regen

The first try failure should not count as generation failure. We should only rely on the "result" field and return code of the script.
Thus, this PR removes scriptError from swagger_to_sdk_config.json.
Another thing is, the generate script status shouldn't rely on showInComments logs:
image
test-repo-billy/azure-rest-api-specs#3398

Alternative attempt to use different log when trying for the first time: main...XiaofeiCao:azure-sdk-for-java:sdkautomation_try_generate
Though it's still strange to infer generation status from log content.

@raych1 Let us know if you have any concern.

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@XiaofeiCao
Copy link
Contributor Author

/check-enforcer override

@XiaofeiCao XiaofeiCao merged commit 3b7e612 into Azure:main Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants