Skip to content

Fixed routing map provider NPE #42874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kushagraThapar merged 11 commits into from
Nov 17, 2024
Merged

Fixed routing map provider NPE #42874

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
5a7bb9d
Fixed routing map provider npe
kushagraThapar Nov 11, 2024
6fb35a8
Fixed routing map provider npe
kushagraThapar Nov 12, 2024
239669b
Added changelog
kushagraThapar Nov 12, 2024
8434732
Fixed java version issues for List class
kushagraThapar Nov 12, 2024
d063fe3
Fixed a null pointer exception
kushagraThapar Nov 12, 2024
3889381
Code review comments and test fixes
kushagraThapar Nov 12, 2024
aea0754
Fix test failures
kushagraThapar Nov 12, 2024
9fc1694
Exposed env variable and fixed tests
kushagraThapar Nov 12, 2024
99425ab
More cleanup and fixed some tests
kushagraThapar Nov 14, 2024
46694a6
Merged latest main and resolved conflicts
kushagraThapar Nov 14, 2024
ef64a33
Fixed broken tests
kushagraThapar Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix test failures
  • Loading branch information
@kushagraThapar
kushagraThapar committed Nov 12, 2024
commit aea0754b7940ae1dbfeaebab4cd949a788fddb3d
4 changes: 2 additions & 2 deletions sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/ClientTelemetryTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,11 +299,11 @@ public void httpClientsConfigurationTests(CosmosClient cosmosClient) throws Exce

Duration responseTimeout = reactorHttpClient.configuration().responseTimeout();
int maxConnections = reactorHttpClient.configuration().connectionProvider().maxConnections();
long connectionAcquireTimeout = (long) reactorHttpClient.configuration().options().get(ChannelOption.CONNECT_TIMEOUT_MILLIS);
int connectionAcquireTimeout = (int) reactorHttpClient.configuration().options().get(ChannelOption.CONNECT_TIMEOUT_MILLIS);

assertThat(responseTimeout).isEqualTo(ClientTelemetry.IMDS_DEFAULT_NETWORK_REQUEST_TIMEOUT);
assertThat(maxConnections).isEqualTo(ClientTelemetry.IMDS_DEFAULT_MAX_CONNECTION_POOL_SIZE);
assertThat(connectionAcquireTimeout).isEqualTo(ClientTelemetry.IMDS_DEFAULT_CONNECTION_ACQUIRE_TIMEOUT.toMillis());
assertThat(connectionAcquireTimeout).isEqualTo((int) ClientTelemetry.IMDS_DEFAULT_CONNECTION_ACQUIRE_TIMEOUT.toMillis());
}


Expand Down
Loading