Skip to content

Add vmId to the Rntbd Health Check Error Message #43079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nehrao1 merged 13 commits into from
Jan 10, 2025
Merged

Add vmId to the Rntbd Health Check Error Message #43079

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
3e82403
float vmId to rntbd layer
nehrao1 Nov 25, 2024
726a94b
remove comment and extra newline
nehrao1 Nov 25, 2024
38e99bb
CHANGELOG
nehrao1 Nov 25, 2024
5d4457d
fetch system info
nehrao1 Dec 2, 2024
a7d7b0a
progress
nehrao1 Dec 10, 2024
1fb1ea9
tests
nehrao1 Dec 28, 2024
4ecff08
pr comment
nehrao1 Jan 6, 2025
88619d1
merge main
nehrao1 Jan 6, 2025
73022d9
fix
nehrao1 Jan 6, 2025
7e359cf
pr comments
nehrao1 Jan 6, 2025
45b2694
pr comments
nehrao1 Jan 8, 2025
fcec0c4
Fix ConnectionStateListenerTest
jeet1995 Jan 9, 2025
845300a
Merge branch 'main' into vmId
nehrao1 Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
tests
  • Loading branch information
@nehrao1
nehrao1 committed Dec 28, 2024
commit 1fb1ea9092c19ffa840054232994156e35f2010d
9 changes: 9 additions & 0 deletions .../cosmos/implementation/directconnectivity/rntbd/RntbdClientChannelHealthCheckerTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,10 @@ public void isHealthyForWriteHangTests(boolean withFailureReason) throws Interru
assertThat(healthyResult.getNow()).isNotEqualTo(RntbdConstants.RntbdHealthCheckResults.SuccessValue);
assertThat(healthyResult.getNow().contains("health check failed due to non-responding write"));
assertThat(healthyResult.getNow().contains("clientVmId: testClientVmId"));
assertThat(healthyResult.getNow().contains("clientUsedMemory"));
assertThat(healthyResult.getNow().contains("clientAvailableMemory"));
assertThat(healthyResult.getNow().contains("clientSystemCpuLoad"));
assertThat(healthyResult.getNow().contains("clientAvailableProcessors"));
} else {
Future<Boolean> healthyResult = healthChecker.isHealthy(channelMock).sync();
assertThat(healthyResult.isSuccess()).isTrue();
Expand Down Expand Up @@ -129,6 +133,11 @@ public void isHealthyForReadHangTests(boolean withFailureReason) throws Interrup
assertThat(healthyResult.isSuccess()).isTrue();
assertThat(healthyResult.getNow()).isNotEqualTo(RntbdConstants.RntbdHealthCheckResults.SuccessValue);
assertThat(healthyResult.getNow().contains("health check failed due to non-responding read"));
assertThat(healthyResult.getNow().contains("clientVmId: testClientVmId"));
assertThat(healthyResult.getNow().contains("clientUsedMemory"));
assertThat(healthyResult.getNow().contains("clientAvailableMemory"));
assertThat(healthyResult.getNow().contains("clientSystemCpuLoad"));
assertThat(healthyResult.getNow().contains("clientAvailableProcessors"));
} else {
Future<Boolean> healthyResult = healthChecker.isHealthy(channelMock).sync();
assertThat(healthyResult.isSuccess()).isTrue();
Expand Down
Loading