Addressing the ARB Comments

Azure · v-dharmarajv · Jul 8, 2025 · May 9, 2025 · May 13, 2025 · May 20, 2025
commit 0b8acfaba98d8e9e4252e06715243cac27eeee8d
@@ -6,11 +6,14 @@
 import com.azure.communication.callautomation.implementation.converters.AudioDataConverter;
 import com.azure.communication.callautomation.models.AudioData;
 import com.azure.core.util.BinaryData;
+import com.azure.core.util.logging.ClientLogger;
 
 /**
  * Helper class to access private values of {@link AudioData} across package boundaries.
  */
 public final class AudioDataContructorProxy {
+    private static final ClientLogger LOGGER = new ClientLogger(AudioDataContructorProxy.class);
+
     private static AudioDataContructorProxyAccessor accessor;
 
     private AudioDataContructorProxy() {
@@ -60,7 +63,11 @@ public static AudioData create(AudioDataConverter internalResponse) {
         // application accesses AudioData which triggers the accessor to be configured. So, if the accessor
         // is null this effectively pokes the class to set up the accessor.
         if (accessor == null) {
-            new AudioData();
+            try {
+                Class.forName(AudioData.class.getName(), true, AudioDataContructorProxyAccessor.class.getClassLoader());
+            } catch (ClassNotFoundException e) {
+                throw LOGGER.logExceptionAsError(new RuntimeException(e));
+            }
         }
 
         assert accessor != null;
@@ -78,7 +85,11 @@ public static AudioData create(BinaryData data) {
         // application accesses AudioData which triggers the accessor to be configured. So, if the accessor
         // is null this effectively pokes the class to set up the accessor.
         if (accessor == null) {
-            new AudioData();
+            try {
+                Class.forName(AudioData.class.getName(), true, AudioDataContructorProxyAccessor.class.getClassLoader());
+            } catch (ClassNotFoundException e) {
+                throw LOGGER.logExceptionAsError(new RuntimeException(e));
+            }
         }
 
         assert accessor != null;

@@ -5,11 +5,13 @@
 
 import com.azure.communication.callautomation.implementation.converters.AudioMetadataConverter;
 import com.azure.communication.callautomation.models.AudioMetadata;
+import com.azure.core.util.logging.ClientLogger;
 
 /**
  * Helper class to access private values of {@link AudioMetaData} across package boundaries.
  */
 public final class AudioMetadataContructorProxy {
+    private static final ClientLogger LOGGER = new ClientLogger(AudioMetadataContructorProxy.class);
     private static AudioMetadataContructorProxyAccessor accessor;
 
     private AudioMetadataContructorProxy() {
@@ -51,7 +53,12 @@ public static AudioMetadata create(AudioMetadataConverter internalResponse) {
         // application accesses AudioMetadata which triggers the accessor to be configured. So, if the accessor
         // is null this effectively pokes the class to set up the accessor.
         if (accessor == null) {
-            new AudioMetadata();
+            try {
+                Class.forName(AudioMetadata.class.getName(), true,
+                    AudioMetadataContructorProxyAccessor.class.getClassLoader());
+            } catch (ClassNotFoundException e) {
+                throw LOGGER.logExceptionAsError(new RuntimeException(e));
+            }
         }
 
         assert accessor != null;

@@ -5,11 +5,13 @@
 
 import com.azure.communication.callautomation.implementation.models.MediaStreamingSubscriptionInternal;
 import com.azure.communication.callautomation.models.MediaStreamingSubscription;
+import com.azure.core.util.logging.ClientLogger;
 
 /**
  * Helper class to access private values of {@link MediaStreamingSubscriptionInternal} across package boundaries.
  */
 public final class MediaStreamingSubscriptionConstructorProxy {
+    private static final ClientLogger LOGGER = new ClientLogger(MediaStreamingSubscriptionConstructorProxy.class);
     private static MediaStreamingSubscriptionConstructorAccessor accessor;
 
     private MediaStreamingSubscriptionConstructorProxy() {
@@ -51,7 +53,12 @@ public static MediaStreamingSubscription create(MediaStreamingSubscriptionIntern
         // application accesses MediaStreamingSubscription which triggers the accessor to be configured. So, if the accessor
         // is null this effectively pokes the class to set up the accessor.
         if (accessor == null) {
-            new MediaStreamingSubscription();
+            try {
+                Class.forName(MediaStreamingSubscription.class.getName(), true,
+                    MediaStreamingSubscriptionConstructorAccessor.class.getClassLoader());
+            } catch (ClassNotFoundException e) {
+                throw LOGGER.logExceptionAsError(new RuntimeException(e));
+            }
         }
 
         assert accessor != null;

@@ -5,11 +5,13 @@
 
 import com.azure.communication.callautomation.implementation.converters.TranscriptionDataConverter;
 import com.azure.communication.callautomation.models.TranscriptionData;
+import com.azure.core.util.logging.ClientLogger;
 
 /**
  * Helper class to access private values of {@link TranscriptionData} across package boundaries.
  */
 public final class TranscriptionDataContructorProxy {
+    private static final ClientLogger LOGGER = new ClientLogger(TranscriptionDataContructorProxy.class);
     private static TranscriptionDataContructorProxyAccessor accessor;
 
     private TranscriptionDataContructorProxy() {
@@ -51,7 +53,12 @@ public static TranscriptionData create(TranscriptionDataConverter internalRespon
         // application accesses AudioData which triggers the accessor to be configured. So, if the accessor
         // is null this effectively pokes the class to set up the accessor.
         if (accessor == null) {
-            new TranscriptionData();
+            try {
+                Class.forName(TranscriptionData.class.getName(), true,
+                    TranscriptionDataContructorProxyAccessor.class.getClassLoader());
+            } catch (ClassNotFoundException e) {
+                throw LOGGER.logExceptionAsError(new RuntimeException(e));
+            }
         }
 
         assert accessor != null;

@@ -5,11 +5,13 @@
 
 import com.azure.communication.callautomation.implementation.converters.TranscriptionMetadataConverter;
 import com.azure.communication.callautomation.models.TranscriptionMetadata;
+import com.azure.core.util.logging.ClientLogger;
 
 /**
  * Helper class to access private values of {@link TranscriptionMetadata} across package boundaries.
  */
 public final class TranscriptionMetadataContructorProxy {
+    private static final ClientLogger LOGGER = new ClientLogger(TranscriptionMetadataContructorProxy.class);
     private static TranscriptionMetadataContructorProxyAccessor accessor;
 
     private TranscriptionMetadataContructorProxy() {
@@ -51,7 +53,12 @@ public static TranscriptionMetadata create(TranscriptionMetadataConverter intern
         // application accesses TranscriptionMetadata which triggers the accessor to be configured. So, if the accessor
         // is null this effectively pokes the class to set up the accessor.
         if (accessor == null) {
-            new TranscriptionMetadata();
+            try {
+                Class.forName(TranscriptionMetadata.class.getName(), true,
+                    TranscriptionMetadataContructorProxyAccessor.class.getClassLoader());
+            } catch (ClassNotFoundException e) {
+                throw LOGGER.logExceptionAsError(new RuntimeException(e));
+            }
         }
 
         assert accessor != null;

@@ -5,11 +5,13 @@
 
 import com.azure.communication.callautomation.implementation.models.TranscriptionSubscriptionInternal;
 import com.azure.communication.callautomation.models.TranscriptionSubscription;
+import com.azure.core.util.logging.ClientLogger;
 
 /**
  * Helper class to access private values of {@link TranscriptionSubscriptionInternal} across package boundaries.
  */
 public final class TranscriptionSubscriptionConstructorProxy {
+    private static final ClientLogger LOGGER = new ClientLogger(TranscriptionSubscriptionConstructorProxy.class);
     private static TranscriptionSubscriptionConstructorAccessor accessor;
 
     private TranscriptionSubscriptionConstructorProxy() {
@@ -51,7 +53,12 @@ public static TranscriptionSubscription create(TranscriptionSubscriptionInternal
         // application accesses TranscriptionSubscription which triggers the accessor to be configured. So, if the accessor
         // is null this effectively pokes the class to set up the accessor.
         if (accessor == null) {
-            new TranscriptionSubscription();
+            try {
+                Class.forName(TranscriptionSubscription.class.getName(), true,
+                    TranscriptionSubscriptionConstructorAccessor.class.getClassLoader());
+            } catch (ClassNotFoundException e) {
+                throw LOGGER.logExceptionAsError(new RuntimeException(e));
+            }
         }
 
         assert accessor != null;

@@ -65,17 +65,6 @@ public AudioData create(BinaryData data) {
         this.silent = internalData.isSilent();
     }
 
-    /**
-     * The constructor
-     */
-    public AudioData() {
-        super(StreamingDataKind.AUDIO_DATA);
-        this.data = null;
-        this.timestamp = null;
-        this.participant = null;
-        this.silent = false;
-    }
-
     /**
      * The constructor
      *

@@ -55,17 +55,6 @@ public AudioMetadata create(AudioMetadataConverter internalData) {
         this.channels = convertToChannelsEnum(internalData.getChannels());
     }
 
-    /**
-     * Creats the audiometadata instance
-     */
-    public AudioMetadata() {
-        super(StreamingDataKind.AUDIO_METADATA);
-        this.mediaSubscriptionId = null;
-        this.encoding = null;
-        this.sampleRate = null;
-        this.channels = null;
-    }
-
     /**
      * A unique identifier for the media subscription.
      * Get the mediaSubscriptionId property.

@@ -49,7 +49,7 @@ public MediaStreamingSubscription create(MediaStreamingSubscriptionInternal inte
     /**
      * Creates an instance of MediaStreamingSubscription class.
      */
-    public MediaStreamingSubscription() {
+    MediaStreamingSubscription() {
         id = null;
         state = null;
         subscribedContentTypes = null;

@@ -95,21 +95,6 @@ protected TranscriptionData(TranscriptionDataConverter internalData) {
         this.resultState = convertToResultStatusEnum(internalData.getResultStatus());
     }
 
-    /**
-     * Create instance of transcription data
-     */
-    public TranscriptionData() {
-        super(StreamingDataKind.TRANSCRIPTION_DATA);
-        this.text = null;
-        this.format = null;
-        this.confidence = null;
-        this.offset = null;
-        this.duration = null;
-        this.words = null;
-        this.participant = null;
-        this.resultState = null;
-    }
-
     private TranscriptionResultState convertToResultStatusEnum(String resultStatus) {
         if ("Intermediate".equalsIgnoreCase(resultStatus)) {
             return TranscriptionResultState.INTERMEDIATE;

@@ -59,18 +59,6 @@ public TranscriptionMetadata create(TranscriptionMetadataConverter internalData)
         this.speechRecognitionModelEndpointId = internalData.getSpeechRecognitionModelEndpointId();
     }
 
-    /**
-     * Creates an instance of TranscriptionMetadata class.
-     */
-    public TranscriptionMetadata() {
-        super(StreamingDataKind.TRANSCRIPTION_METADATA);
-        this.transcriptionSubscriptionId = null;
-        this.locale = null;
-        this.callConnectionId = null;
-        this.correlationId = null;
-        this.speechRecognitionModelEndpointId = null;
-    }
-
     /**
      * Get the transcriptionSubscriptionId property.
      *

@@ -54,7 +54,7 @@ public TranscriptionSubscription create(TranscriptionSubscriptionInternal intern
     /**
      * Creates an instance of TranscriptionSubscriptionInternal class.
      */
-    public TranscriptionSubscription() {
+    TranscriptionSubscription() {
         id = null;
         state = null;
         subscribedResultStates = null;

@@ -80,7 +80,7 @@ public String getOperationCallbackUrl() {
      * @param operationCallbackUrl the operationCallbackUrl value to set.
      * @return the UnholdRequest object itself.
      */
-    public UnholdOptions setOperationCallbackUri(String operationCallbackUrl) {
+    public UnholdOptions setOperationCallbackUrl(String operationCallbackUrl) {
         this.operationCallbackUrl = operationCallbackUrl;
         return this;
     }