[AutoPR azure-resourcemanager-avs]-generated-from-SDK Generation - Java-4934257 #45561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fig.yaml', API Version: 2024-09-01, SDK Release Type: stable, and CommitSHA: '673395fc3962bb6e6cfb55f84d23cc1a0ea6849f' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs'
github-actions
bot
added
the
Mgmt
weidongxu-microsoft
requested review from
ArthurMa1978,
XiaofeiCao,
haolingdong-msft and
weidongxu-microsoft
as code owners
3 tasks
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates generated AVS management clients for Java to use the new TypeSpec generator and aligns method signatures and factory methods with the 2024-09-01 API:
- Swaps AutoRest headers for TypeSpec in all fluent client classes.
- Renames and re-docs listing and rotation methods in
PrivateCloudsClientandLocationsClient. - Adds
workloadNetworkssupport inAvsClientandAvsManager.
Reviewed Changes
Copilot reviewed 568 out of 568 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/avs/.../PureStoragePoliciesClient.java | Updated generator header comment |
| sdk/avs/.../PrivateCloudsClient.java | Renamed list methods, updated rotation API signatures and docs |
| sdk/avs/.../LocationsClient.java | Swapped quota/trial APIs and adjusted Javadoc to match signatures |
| sdk/avs/.../AvsClient.java | Added getWorkloadNetworks(), reordered getters, updated Javadoc |
| sdk/avs/.../AvsManager.java | Added workloadNetworks() factory, reordered resource fields |
| sdk/avs/.../pom.xml, README.md | Changed "tag" to "api-version" in descriptions |
Comments suppressed due to low confidence (3)
sdk/avs/azure-resourcemanager-avs/src/main/java/com/azure/resourcemanager/avs/fluent/AvsClient.java:23
- [nitpick] The Javadoc for
getApiVersionis ambiguous. It would be clearer to state "Gets the API version."
* * Gets Version parameter.
sdk/avs/azure-resourcemanager-avs/src/main/java/com/azure/resourcemanager/avs/fluent/AvsClient.java:15
- [nitpick] Consider updating the Javadoc to "Gets the service endpoint." for consistency with REST client naming conventions.
* * Gets Service host.
sdk/avs/azure-resourcemanager-avs/src/main/java/com/azure/resourcemanager/avs/fluent/PrivateCloudsClient.java:335
- The NSX-T rotation only exposes LRO variants (
beginRotateNsxtPassword) and lacks a synchronousrotateNsxtPasswordmethod. Consider adding a synchronous variant for consistency with the vCenter rotation API.
SyncPoller<PollResult<Void>, Void> beginRotateNsxtPassword(String resourceGroupName, String privateCloudName);
|
|
||
| <name>Microsoft Azure SDK for Avs Management</name> | ||
| <description>This package contains Microsoft Azure SDK for Avs Management SDK. For documentation on how to use this package, please see https://aka.ms/azsdk/java/mgmt. Azure VMware Solution API. Package tag package-2024-09-01.</description> | ||
| <description>This package contains Microsoft Azure SDK for Avs Management SDK. For documentation on how to use this package, please see https://aka.ms/azsdk/java/mgmt. Azure VMware Solution API. Package api-version 2024-09-01.</description> |
There was a problem hiding this comment.
[nitpick] Consider capitalizing "API version" instead of "api-version" to match standard phrasing in Maven POM descriptions.
| Azure Resource Manager Avs client library for Java. | ||
|
|
||
| This package contains Microsoft Azure SDK for Avs Management SDK. Azure VMware Solution API. Package tag package-2024-09-01. For documentation on how to use this package, please see [Azure Management Libraries for Java](https://aka.ms/azsdk/java/mgmt). | ||
| This package contains Microsoft Azure SDK for Avs Management SDK. Azure VMware Solution API. Package api-version 2024-09-01. For documentation on how to use this package, please see [Azure Management Libraries for Java](https://aka.ms/azsdk/java/mgmt). |
There was a problem hiding this comment.
[nitpick] For consistency with other docs, consider using "API version" instead of "api-version" in the README.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configurations: 'specification/vmware/Microsoft.AVS.Management/tspconfig.yaml', API Version: 2024-09-01, SDK Release Type: stable, and CommitSHA: '673395fc3962bb6e6cfb55f84d23cc1a0ea6849f' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs'