Skip to content

Conversation

@azure-sdk
Copy link
Collaborator

@azure-sdk azure-sdk commented Jun 4, 2025

Configurations: 'specification/oracle/Oracle.Database.Management/tspconfig.yaml', API Version: 2025-03-01, SDK Release Type: stable, and CommitSHA: '3c2966598b7966dcca302d07dd7d28b1d1d744f3' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs'

there is breaks (some "required" <-> "optional" may come from service), but so far nothing major
breakdown in #45575

…onfig.yaml', API Version: 2025-03-01, SDK Release Type: stable, and CommitSHA: '3c2966598b7966dcca302d07dd7d28b1d1d744f3' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs'
@github-actions github-actions bot added the Mgmt This issue is related to a management-plane library. label Jun 4, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

com.azure.resourcemanager:azure-resourcemanager-oracledatabase

@weidongxu-microsoft weidongxu-microsoft marked this pull request as ready for review June 4, 2025 08:08
Copilot AI review requested due to automatic review settings June 4, 2025 08:08
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request updates the Oracle Database Management Java SDK by regenerating client interfaces and manager classes using Microsoft’s new TypeSpec Code Generator. Key changes include updating code generator comments, adjusting API documentation and parameter descriptions, and updating version strings and dependency declarations.

Reviewed Changes

Copilot reviewed 554 out of 554 changed files in this pull request and generated no comments.

Show a summary per file
File Description
sdk/oracledatabase/azure-resourcemanager-oracledatabase/src/main/java/com/azure/resourcemanager/oracledatabase/fluent/* Updated generated interfaces’ comments and parameter descriptors to reflect TypeSpec Code Generator usage and improved naming consistency.
sdk/oracledatabase/azure-resourcemanager-oracledatabase/OracleDatabaseManager.java Refactored manager class to update client builder usage, reordering fields, and updating Javadoc to match the new management client type.
sdk/oracledatabase/azure-resourcemanager-oracledatabase/pom.xml Updated version number from “1.1.0-beta.1” to “1.1.0” and removed a beta indicator.
sdk/oracledatabase/azure-resourcemanager-oracledatabase/README.md Revised package description and authentication sample details.
eng/versioning/version_client.txt Updated version mapping for the Oracle Database SDK module.
Comments suppressed due to low confidence (3)

sdk/oracledatabase/azure-resourcemanager-oracledatabase/src/main/java/com/azure/resourcemanager/oracledatabase/fluent/DnsPrivateZonesClient.java:22

  • [nitpick] Consider renaming the parameter 'dnsprivatezonename' to 'dnsPrivateZoneName' to follow standard camelCase conventions.
 * @param dnsprivatezonename DnsPrivateZone name.

sdk/oracledatabase/azure-resourcemanager-oracledatabase/src/main/java/com/azure/resourcemanager/oracledatabase/fluent/DnsPrivateViewsClient.java:22

  • [nitpick] Consider renaming 'dnsprivateviewocid' to 'dnsPrivateViewOcid' for improved readability and consistency with Java naming conventions.
 * @param dnsprivateviewocid DnsPrivateView OCID.

sdk/oracledatabase/azure-resourcemanager-oracledatabase/OracleDatabaseManager.java:617

  • Update the Javadoc for serviceClient() to reflect that it returns an OracleDatabaseManagementClient instead of OracleDatabaseResourceManager to avoid confusion.
public OracleDatabaseManagementClient serviceClient() {

@XiaofeiCao
Copy link
Contributor

/check-enforcer override

@weidongxu-microsoft weidongxu-microsoft merged commit f8eaa5f into Azure:main Jun 4, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mgmt This issue is related to a management-plane library.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants