Skip to content

Conversation

@weidongxu-microsoft
Copy link
Member

@weidongxu-microsoft weidongxu-microsoft commented Jun 6, 2025

packages Azure/azure-sdk#8768
PR Azure/azure-rest-api-specs#34190

context:

  1. "deployments.json" is moved out of package-resources-2025-04 tag
  2. SDK now generate it separately (instead of make a new tag that contains both "resources.json" and "deployments.json"), so that when it moves to typespec, it would not have major impact on clients
  3. This should not impact customer that uses the fluent interfaces. (and there is no change in our test code or sample code)
  4. But it could affect customer that directly use the serviceClient(). And this is documented in changelog.
  5. "deploymentStackClient()" is to be moved to a separate package (currently tagged as Deprecated). We haven't exposed fluent interface for it, hence we'd expect low customer impact.

main code change 32afea2

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions bot added the Mgmt This issue is related to a management-plane library. label Jun 6, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

com.azure.resourcemanager:azure-resourcemanager-resources

@weidongxu-microsoft weidongxu-microsoft marked this pull request as ready for review June 6, 2025 04:55
Copilot AI review requested due to automatic review settings June 6, 2025 04:55
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR splits the deployments API out of the main resource manager package and moves the related clients (DeploymentsClient and DeploymentOperationsClient) to a separate DeploymentsManagementClient. It updates both test and production code along with native-image configuration files to support the new client structure and deprecates the old deploymentStackClient.

  • Moved deployments functionality from ResourceManagementClient to a new DeploymentsManagementClient.
  • Updated native image and REST proxy configurations to reflect the new API split.
  • Adjusted ResourceManager to expose the new deploymentClient and deprecate deploymentStackClient.

Reviewed Changes

Copilot reviewed 51 out of 51 changed files in this pull request and generated no comments.

Show a summary per file
File Description
DeploymentsTests.java Minor test comment update for cancellations.
native-image files Updated reflect/proxy configurations for deployments.
ResourceManagementClientImpl.java Removed deployments and deploymentOperations fields in favor of new client.
DeploymentsManagementClientImpl.java / Builder Added new deployments management client implementation and builder.
DeploymentsImpl.java, DeploymentsClientImpl.java, DeploymentOperationsClientImpl.java, DeploymentImpl.java Adjusted service client calls to use the new deploymentClient.
ResourceManager.java Exposed new deploymentClient and deprecated deploymentStackClient.
assets.json, CHANGELOG.md, api-specs.json Updated tagging and API specs to align with changes.
Comments suppressed due to low confidence (2)

sdk/resourcemanager/azure-resourcemanager-resources/src/main/java/com/azure/resourcemanager/resources/implementation/DeploymentsClientImpl.java:85

  • The service interface name 'DeploymentsManagemen' appears to be truncated. Consider renaming it to 'DeploymentsManagement' for clarity and consistency.
@ServiceInterface(name = "DeploymentsManagemen")

sdk/resourcemanager/azure-resourcemanager-resources/src/main/java/com/azure/resourcemanager/resources/implementation/DeploymentOperationsClientImpl.java:63

  • The service interface name 'DeploymentsManagemen' seems incomplete. Renaming it to 'DeploymentsManagement' would improve readability and consistency with the rest of the code.
@ServiceInterface(name = "DeploymentsManagemen")

@weidongxu-microsoft weidongxu-microsoft merged commit 1ce80d2 into Azure:main Jun 6, 2025
44 checks passed
@weidongxu-microsoft weidongxu-microsoft deleted the mgmt_refactor-deployments branch June 6, 2025 07:07
github-merge-queue bot pushed a commit to microsoft/typespec that referenced this pull request Jun 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mgmt This issue is related to a management-plane library.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants