-
Notifications
You must be signed in to change notification settings - Fork 2.1k
mgmt, handle the split of deployments in specs #45614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mgmt, handle the split of deployments in specs #45614
Conversation
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR splits the deployments API out of the main resource manager package and moves the related clients (DeploymentsClient and DeploymentOperationsClient) to a separate DeploymentsManagementClient. It updates both test and production code along with native-image configuration files to support the new client structure and deprecates the old deploymentStackClient.
- Moved deployments functionality from ResourceManagementClient to a new DeploymentsManagementClient.
- Updated native image and REST proxy configurations to reflect the new API split.
- Adjusted ResourceManager to expose the new deploymentClient and deprecate deploymentStackClient.
Reviewed Changes
Copilot reviewed 51 out of 51 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| DeploymentsTests.java | Minor test comment update for cancellations. |
| native-image files | Updated reflect/proxy configurations for deployments. |
| ResourceManagementClientImpl.java | Removed deployments and deploymentOperations fields in favor of new client. |
| DeploymentsManagementClientImpl.java / Builder | Added new deployments management client implementation and builder. |
| DeploymentsImpl.java, DeploymentsClientImpl.java, DeploymentOperationsClientImpl.java, DeploymentImpl.java | Adjusted service client calls to use the new deploymentClient. |
| ResourceManager.java | Exposed new deploymentClient and deprecated deploymentStackClient. |
| assets.json, CHANGELOG.md, api-specs.json | Updated tagging and API specs to align with changes. |
Comments suppressed due to low confidence (2)
sdk/resourcemanager/azure-resourcemanager-resources/src/main/java/com/azure/resourcemanager/resources/implementation/DeploymentsClientImpl.java:85
- The service interface name 'DeploymentsManagemen' appears to be truncated. Consider renaming it to 'DeploymentsManagement' for clarity and consistency.
@ServiceInterface(name = "DeploymentsManagemen")
sdk/resourcemanager/azure-resourcemanager-resources/src/main/java/com/azure/resourcemanager/resources/implementation/DeploymentOperationsClientImpl.java:63
- The service interface name 'DeploymentsManagemen' seems incomplete. Renaming it to 'DeploymentsManagement' would improve readability and consistency with the rest of the code.
@ServiceInterface(name = "DeploymentsManagemen")
packages Azure/azure-sdk#8768
PR Azure/azure-rest-api-specs#34190
context:
serviceClient(). And this is documented in changelog.Deprecated). We haven't exposed fluent interface for it, hence we'd expect low customer impact.main code change 32afea2
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines