-
Notifications
You must be signed in to change notification settings - Fork 2.1k
[eventgrid-systemevents] Prepare for GA #45628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR prepares the Event Grid SystemEvents package for GA by applying TypeSpec model updates, reorganizing package paths, and introducing the new AcsCallParticipantKind enum.
- Applied model changes from recent Azure REST API specs PRs.
- Updated
tsp-location.yamlto point to the latest commit including namespace/model subpackage changes. - Moved types from
systemeventsroot intosystemevents.modelsand updated related package-info and customization code.
Reviewed Changes
Copilot reviewed 338 out of 338 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| sdk/eventgrid/.../AcsCallParticipantRemovedEventData.java | Updated package, renamed base class to AcsCallParticipantEventData |
| sdk/eventgrid/.../AcsCallParticipantProperties.java | Updated package, switched role type to new AcsCallParticipantKind |
| sdk/eventgrid/.../AcsCallParticipantKind.java | Added new enum type for participant kind |
| sdk/eventgrid/.../AcsCallParticipantEventData.java | Renamed class from AcsCallParticipantEventProperties to AcsCallParticipantEventData |
| sdk/eventgrid/.../AcsCallParticipantAddedEventData.java | Updated package, renamed base class to AcsCallParticipantEventData |
| sdk/eventgrid/.../AcsCallGroupProperties.java | Updated package |
| sdk/eventgrid/.../AcsCallEndedEventData.java | Updated package |
| sdk/eventgrid/.../AcsCallEndedByProperties.java | Renamed field/method from type to kind and updated JSON mapping |
| sdk/eventgrid/.../AcsCallEndedByKind.java | Updated package |
| sdk/eventgrid/.../AcsCallEndReasonProperties.java | Updated package |
| sdk/eventgrid/.../implementation/package-info.java | Updated implementation package path |
| sdk/eventgrid/.../implementation/models/package-info.java | Updated implementation models package path |
| sdk/eventgrid/.../implementation/models/* | Updated implementation models package path for multiple generated files |
| sdk/eventgrid/.../RecordingFormatType.java, RecordingContentType.java, RecordingChannelType.java, ApiManagementCircuitBreakerPropertiesRule.java | Deleted obsolete/generated classes—ensure intended removal or proper relocation |
| sdk/eventgrid/.../AcsCallParticipantRoleKind.java | Deleted old enum after introduction of AcsCallParticipantKind |
| sdk/eventgrid/.../EventGridSystemEventsCustomization.java | Updated hardcoded package paths and imports to use .systemevents.models namespace |
Comments suppressed due to low confidence (4)
sdk/eventgrid/azure-messaging-eventgrid-systemevents/src/main/java/com/azure/messaging/eventgrid/systemevents/RecordingFormatType.java:1
- RecordingFormatType (and related RecordingContentType, RecordingChannelType) were deleted entirely—confirm this removal is intentional or relocate these enums to the models package to avoid API break.
// Copyright (c) Microsoft Corporation. All rights reserved.
sdk/eventgrid/azure-messaging-eventgrid-systemevents/src/main/java/com/azure/messaging/eventgrid/systemevents/models/AcsCallParticipantProperties.java:30
- [nitpick] The field is named
rolebut its type isAcsCallParticipantKind; consider renaming the field tokindfor consistency with its type.
private AcsCallParticipantKind role;
sdk/eventgrid/azure-messaging-eventgrid-systemevents/src/main/java/com/azure/messaging/eventgrid/systemevents/models/AcsCallEndedByProperties.java:91
- [nitpick] JSON property is still named
typewhile the backing field iskind; consider aligning the JSON field name with the property name or adding a comment to explain the mismatch.
jsonWriter.writeStringField("type", this.kind == null ? null : this.kind.toString());
sdk/eventgrid/azure-messaging-eventgrid-systemevents/src/main/java/com/azure/messaging/eventgrid/systemevents/implementation/models/ApiManagementCircuitBreakerPropertiesRule.java:1
- ApiManagementCircuitBreakerPropertiesRule was deleted—ensure this model is no longer needed or has been moved, otherwise this could break consumers relying on this type.
// Licensed under the MIT License.
Description