Skip to content

Conversation

@samvaity
Copy link
Member

@samvaity samvaity commented Jun 6, 2025

Description

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

com.azure:azure-messaging-eventgrid-systemevents

@samvaity samvaity marked this pull request as ready for review June 6, 2025 22:55
Copilot AI review requested due to automatic review settings June 6, 2025 22:55
@samvaity samvaity requested review from a team, lmolkova and srnagar as code owners June 6, 2025 22:55
@samvaity samvaity self-assigned this Jun 6, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR prepares the Event Grid SystemEvents package for GA by applying TypeSpec model updates, reorganizing package paths, and introducing the new AcsCallParticipantKind enum.

  • Applied model changes from recent Azure REST API specs PRs.
  • Updated tsp-location.yaml to point to the latest commit including namespace/model subpackage changes.
  • Moved types from systemevents root into systemevents.models and updated related package-info and customization code.

Reviewed Changes

Copilot reviewed 338 out of 338 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
sdk/eventgrid/.../AcsCallParticipantRemovedEventData.java Updated package, renamed base class to AcsCallParticipantEventData
sdk/eventgrid/.../AcsCallParticipantProperties.java Updated package, switched role type to new AcsCallParticipantKind
sdk/eventgrid/.../AcsCallParticipantKind.java Added new enum type for participant kind
sdk/eventgrid/.../AcsCallParticipantEventData.java Renamed class from AcsCallParticipantEventProperties to AcsCallParticipantEventData
sdk/eventgrid/.../AcsCallParticipantAddedEventData.java Updated package, renamed base class to AcsCallParticipantEventData
sdk/eventgrid/.../AcsCallGroupProperties.java Updated package
sdk/eventgrid/.../AcsCallEndedEventData.java Updated package
sdk/eventgrid/.../AcsCallEndedByProperties.java Renamed field/method from type to kind and updated JSON mapping
sdk/eventgrid/.../AcsCallEndedByKind.java Updated package
sdk/eventgrid/.../AcsCallEndReasonProperties.java Updated package
sdk/eventgrid/.../implementation/package-info.java Updated implementation package path
sdk/eventgrid/.../implementation/models/package-info.java Updated implementation models package path
sdk/eventgrid/.../implementation/models/* Updated implementation models package path for multiple generated files
sdk/eventgrid/.../RecordingFormatType.java, RecordingContentType.java, RecordingChannelType.java, ApiManagementCircuitBreakerPropertiesRule.java Deleted obsolete/generated classes—ensure intended removal or proper relocation
sdk/eventgrid/.../AcsCallParticipantRoleKind.java Deleted old enum after introduction of AcsCallParticipantKind
sdk/eventgrid/.../EventGridSystemEventsCustomization.java Updated hardcoded package paths and imports to use .systemevents.models namespace
Comments suppressed due to low confidence (4)

sdk/eventgrid/azure-messaging-eventgrid-systemevents/src/main/java/com/azure/messaging/eventgrid/systemevents/RecordingFormatType.java:1

  • RecordingFormatType (and related RecordingContentType, RecordingChannelType) were deleted entirely—confirm this removal is intentional or relocate these enums to the models package to avoid API break.
// Copyright (c) Microsoft Corporation. All rights reserved.

sdk/eventgrid/azure-messaging-eventgrid-systemevents/src/main/java/com/azure/messaging/eventgrid/systemevents/models/AcsCallParticipantProperties.java:30

  • [nitpick] The field is named role but its type is AcsCallParticipantKind; consider renaming the field to kind for consistency with its type.
private AcsCallParticipantKind role;

sdk/eventgrid/azure-messaging-eventgrid-systemevents/src/main/java/com/azure/messaging/eventgrid/systemevents/models/AcsCallEndedByProperties.java:91

  • [nitpick] JSON property is still named type while the backing field is kind; consider aligning the JSON field name with the property name or adding a comment to explain the mismatch.
jsonWriter.writeStringField("type", this.kind == null ? null : this.kind.toString());

sdk/eventgrid/azure-messaging-eventgrid-systemevents/src/main/java/com/azure/messaging/eventgrid/systemevents/implementation/models/ApiManagementCircuitBreakerPropertiesRule.java:1

  • ApiManagementCircuitBreakerPropertiesRule was deleted—ensure this model is no longer needed or has been moved, otherwise this could break consumers relying on this type.
// Licensed under the MIT License.

@samvaity samvaity enabled auto-merge (squash) June 6, 2025 23:11
@samvaity samvaity requested a review from srnagar June 7, 2025 00:19
@samvaity samvaity merged commit ceb0e96 into Azure:main Jun 7, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants