-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Sync eng/common directory with azure-sdk-tools for PR 12734 #47136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the cspell configuration to use a scoped package name, marks it as private, and pins the cspell dependency to an exact version.
- Package name changed from
cspell-version-pinto@azure-tools/cspell - Added
"private": trueto prevent accidental publishing - Changed cspell dependency from flexible version
^9.2.1to exact version9.2.1
Reviewed Changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| eng/common/spelling/package.json | Updated package name to scoped format, added private flag, and pinned cspell to exact version |
| eng/common/spelling/package-lock.json | Updated lockfile to reflect new package name and exact version dependency |
Files not reviewed (1)
- eng/common/spelling/package-lock.json: Language not supported
| { | ||
| "name": "cspell-version-pin", | ||
| "version": "1.0.0", | ||
| "name": "@azure-tools/cspell", |
Copilot
AI
Oct 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The package.json should include a version field. Since this is a private package and not intended for publishing, it's best practice to include \"version\": \"1.0.0\" (or another appropriate version) for consistency with the lock file and standard npm package structure.
| "name": "@azure-tools/cspell", | |
| "name": "@azure-tools/cspell", | |
| "version": "1.0.0", |
|
Hi @azure-sdk. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
|
Hi @azure-sdk. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing |
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#12734 See eng/common workflow