Skip to content

Conversation

@azure-sdk
Copy link
Collaborator

Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#12734 See eng/common workflow

@azure-sdk azure-sdk requested a review from a team as a code owner October 31, 2025 21:50
@azure-sdk azure-sdk added EngSys This issue is impacting the engineering system. Central-EngSys This issue is owned by the Engineering System team. labels Oct 31, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the cspell configuration to use a scoped package name, marks it as private, and pins the cspell dependency to an exact version.

  • Package name changed from cspell-version-pin to @azure-tools/cspell
  • Added "private": true to prevent accidental publishing
  • Changed cspell dependency from flexible version ^9.2.1 to exact version 9.2.1

Reviewed Changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File Description
eng/common/spelling/package.json Updated package name to scoped format, added private flag, and pinned cspell to exact version
eng/common/spelling/package-lock.json Updated lockfile to reflect new package name and exact version dependency
Files not reviewed (1)
  • eng/common/spelling/package-lock.json: Language not supported

{
"name": "cspell-version-pin",
"version": "1.0.0",
"name": "@azure-tools/cspell",
Copy link

Copilot AI Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package.json should include a version field. Since this is a private package and not intended for publishing, it's best practice to include \"version\": \"1.0.0\" (or another appropriate version) for consistency with the lock file and standard npm package structure.

Suggested change
"name": "@azure-tools/cspell",
"name": "@azure-tools/cspell",
"version": "1.0.0",

Copilot uses AI. Check for mistakes.
@github-actions
Copy link
Contributor

github-actions bot commented Jan 2, 2026

Hi @azure-sdk. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@github-actions github-actions bot added the no-recent-activity There has been no recent activity on this issue. label Jan 2, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2026

Hi @azure-sdk. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing /reopen if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the no-recent-activity label; otherwise, this is likely to be closed again with the next cleanup pass.

@github-actions github-actions bot closed this Jan 9, 2026
@azure-sdk azure-sdk deleted the sync-eng/common-djurek/cspell-name-12734 branch January 11, 2026 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system. no-recent-activity There has been no recent activity on this issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants