Disable Jetty by default. #4964
Conversation
mitchdenny
requested review from
danieljurek,
g2vinay,
samvaity and
weshaggard
as code owners
|
Can't wait to get this merged! |
|
/azp run java - keyvault - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Those CI times are super nice. |
|
/azp run java - keyvault - ci.data |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
I think that this PR is ready to go. When it is merged all pipelines that include track 1 and track 2 libraries will continue to build as usual (including starting Jetty). Then for libraries which have no track 1 elements we can simply set the EnableJetty flag to false and Jetty will disappear from the build times. For libraries that contain track 1 and track 2 libraries work needs to be done on a per library basis to split out the track 1 libraries into a separate build. This PR contains an example of how this is done for KeyVault (using profiles). The template yml is setup so that Jetty will start unless it is specifically disabled, but the approach to the |
|
Spoke too soon - looks like the track 1 build is failing. Not sure why. |
|
OK - it looks like some recorded tests didn't come across in the move. Will need to go back and find them and put them in the right place. |
mitchdenny
requested review from
JonathanGiles,
alzimmermsft,
christopheranderson,
conniey,
jaschrep-msft,
kushagraThapar,
moderakh,
mssfang and
nemakam
as code owners
mitchdenny
requested review from
rickle-msft,
sima-zhu,
srnagar,
yaohaizh and
yvgopal
as code owners
|
/azp run java - keyvault - ci |
|
/azp run java - keyvault - ci.data |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
mitchdenny
force-pushed
the
disable-jetty-flag
branch
from
d313540 to
880672c
Compare
Adds a flag to the pipeline which controls whether it is a track 1 or track 2 build.
6 participants
No description provided.