Skip to content

Event Hubs: Synchronous APIs Part 2 #4970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
conniey merged 33 commits into from
Aug 14, 2019
Merged

Event Hubs: Synchronous APIs Part 2 #4970

conniey merged 33 commits into from
Aug 14, 2019

Conversation

@conniey
Copy link
Member

@conniey conniey commented Aug 13, 2019 •
edited
Loading

This is the second part of a few PRs for supporting synchronous APIs in Event Hubs. This PR:

  • Adds synchronous APIs for EventHubClient and EventHubProducer.
  • Adds codesnippets for associated classes.
  • Removes overlapping codesnippet scenarios.
  • Fixes naming convention for codesnippets to match the Java guidelines.

In Progress

  • Adding tests

Proposal: Event Hubs: Synchronous APIs

conniey added 13 commits August 13, 2019 00:40
@conniey conniey added Event Hubs Client This issue points to a problem in the data-plane of the library. labels Aug 13, 2019
@conniey conniey requested a review from mssfang as a code owner August 13, 2019 17:57
@conniey conniey self-assigned this Aug 13, 2019
srnagar
srnagar reviewed Aug 13, 2019
View reviewed changes
srnagar
srnagar approved these changes Aug 14, 2019
View reviewed changes
Copy link
Member

@srnagar srnagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just change IterableResponse to IterableStream before merging.

@conniey conniey merged commit 7d24f9a into Azure:master Aug 14, 2019
@conniey conniey deleted the synchronous-client branch August 14, 2019 20:19
pull bot pushed a commit to test-repo-billy/azure-sdk-for-java that referenced this pull request Aug 14, 2019
@conniey @pull
Event Hubs: Synchronous APIs Part 2 (Azure#4970)
f8085c9 
* Formatting changes in EventHubAsyncProducer.

* Adding EventHubClient, EventHubConsumer, and EventHubProducer.

* Exposing EventHubClient creation in EventHubClientBuilder.

* EventHubClient, Consumer and Producer implements Closeable.

* Fixing sample by removing event hub instance from namespace connection string.

* Remove unneeded sample in EventHubClientBuilder.

* Add EventHubClient to builder annotation.

* Update EventHubClientBuilder samples. Remove unneeded ones.

* Update samples in EventHubClientBuilder.

* Fixing links to EventHubAsyncProducer samples.

* Adding EventHubProducer code samples.

* Update from Iterable to IterableResponse.

* Make test contents package-private.

* Adding tests for EventHubProducer.

* Simplifying creation of EventHubAsyncProducer

* Select correct retryDuration when constructing EventHubProducer.

* Adding EventHubProducer tests.

* Rename EventHubClientIntegrationTest -> EventHubAsyncClientIntegrationTests

* Add integration tests for EventHubClient.

* Make EventHubConsumer methods public
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsquire jsquire jsquire approved these changes

@srnagar srnagar srnagar approved these changes

@JonathanGiles JonathanGiles Awaiting requested review from JonathanGiles

@ramya-rao-a ramya-rao-a Awaiting requested review from ramya-rao-a

@mssfang mssfang Awaiting requested review from mssfang

Assignees

@conniey conniey

Labels

Client This issue points to a problem in the data-plane of the library. Event Hubs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@conniey @jsquire @JonathanGiles @srnagar