Skip to content

CredScan Reports - clearing noise related to "scope" in request bodies #14954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
41 commits merged into from
May 26, 2021
Merged

CredScan Reports - clearing noise related to "scope" in request bodies #14954

Changes from 1 commit
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
9ac07dd
starter code - handle browser recordings
HarshaNalluru Apr 20, 2021
c508d34
changelog
HarshaNalluru Apr 20, 2021
f56a3be
Update matchRequest with applyRequestBodyTransformations
HarshaNalluru Apr 20, 2021
acdb7bb
update test
HarshaNalluru Apr 20, 2021
60b2d93
Update sdk/test-utils/recorder/src/utils/requestBodyTransform.ts
HarshaNalluru Apr 20, 2021
05d2284
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-js in…
HarshaNalluru Apr 20, 2021
ce1f236
Merge branch 'harshan/recorder/filter-scope' of https://github.com/Ha…
HarshaNalluru Apr 21, 2021
43bc9a2
fix regexes and minor bugs
HarshaNalluru Apr 21, 2021
19dbec8
fix test titles and removed .only
HarshaNalluru Apr 21, 2021
478c7f4
remove requestBodyTransformations on the exports as it isn't well sup…
HarshaNalluru Apr 21, 2021
2332a82
InternalRecorderEnvironmentSetup with requestBodyTransformations
HarshaNalluru Apr 21, 2021
a139974
recording
HarshaNalluru Apr 21, 2021
fe26243
reasoning
HarshaNalluru Apr 21, 2021
901e574
applyRequestBodyTransformationsOnFixture
HarshaNalluru Apr 21, 2021
ff8dd0b
changelog
HarshaNalluru Apr 21, 2021
80794b7
minor bug fix
HarshaNalluru Apr 21, 2021
81b58cb
record a test from text-analytics
HarshaNalluru Apr 21, 2021
c6842ca
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-js in…
HarshaNalluru Apr 21, 2021
8a8e2a7
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-js in…
HarshaNalluru Apr 23, 2021
09af90c
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-js in…
HarshaNalluru Apr 23, 2021
fffdb55
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-js in…
HarshaNalluru May 12, 2021
8fc6629
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-js in…
HarshaNalluru May 12, 2021
051aeed
convert to Record<string, unknown>
HarshaNalluru May 12, 2021
dc46c22
rush update --recheck
HarshaNalluru May 12, 2021
822ac74
Required<RequestBodyTransformsType>
HarshaNalluru May 12, 2021
854ce6d
retain older changelog
HarshaNalluru May 12, 2021
07baf37
set the date
HarshaNalluru May 12, 2021
c9d66fd
Update sdk/test-utils/recorder/CHANGELOG.md
HarshaNalluru May 12, 2021
0f14c68
lock file
HarshaNalluru May 19, 2021
fedce31
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-js in…
HarshaNalluru May 22, 2021
0bdcad2
revert recording
HarshaNalluru May 22, 2021
1af5db3
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-js in…
HarshaNalluru May 25, 2021
b3b00dd
lock file
HarshaNalluru May 25, 2021
5c1b872
sanitizeScopeUrl
HarshaNalluru May 25, 2021
4d8fe5a
fix the regex
HarshaNalluru May 25, 2021
e002369
regenerate and playback - works
HarshaNalluru May 25, 2021
f627108
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-js in…
HarshaNalluru May 25, 2021
1c80a0f
rush update
HarshaNalluru May 25, 2021
bbffc88
changelog
HarshaNalluru May 25, 2021
f52eb97
tests for browser recordings
HarshaNalluru May 25, 2021
b4a22d7
tests for defaultCustomizationsOnRecordings
HarshaNalluru May 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update sdk/test-utils/recorder/CHANGELOG.md
  • Loading branch information
@HarshaNalluru
HarshaNalluru authored May 12, 2021
commit c9d66fde30e9ca0880a7a7bed91f06c638c62485
2 changes: 1 addition & 1 deletion sdk/test-utils/recorder/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

## 2021-05-12

- Extended the `requestBodyTransformations` from #14897 to handle browser tests as well.
- Extended the `requestBodyTransformations` from [#14897](https://github.com/Azure/azure-sdk-for-js/pull/14897) to handle browser tests as well.
- Adds a default transformation to strip out the scope in the request body with the string `"https://sanitized/"`
- Removed `requestBodyTransformations` property from `RecorderEnvironmentSetup` since Nock doesn't support multiple `.filteringRequestBody` patches in the recordings.

Expand Down