[identity] Add support for additional tenants #23174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
xirzec
reviewed
Sep 14, 2022
Member
xirzec
left a comment
xirzec
left a comment
There was a problem hiding this comment.
Minor thoughts / suggestions but looks good!
sdk/identity/identity/src/credentials/azurePowerShellCredential.ts
Outdated
Show resolved
Hide resolved
sdk/identity/identity/src/credentials/interactiveBrowserCredential.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Jeff Fisher <[email protected]>
Collaborator
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
mpodwysocki
requested review from
KarishmaGhiya,
bterlson,
jeremymeng and
witemple-msft
as code owners
jeremymeng
reviewed
Sep 19, 2022
xirzec
approved these changes
Sep 19, 2022
Member
xirzec
left a comment
xirzec
left a comment
There was a problem hiding this comment.
Some small remarks, but overall looks good
xirzec
reviewed
Sep 19, 2022
Co-authored-by: Jeff Fisher <[email protected]>
schaabs
reviewed
Sep 19, 2022
Contributor
schaabs
left a comment
schaabs
left a comment
There was a problem hiding this comment.
The changes look good from the perspective of the identity features. I'll defer to a JS dev for approval, given the additional refactoring and layout changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
Issues associated with this PR
Describe the problem that is addressed by this PR
Adds support for multitenant auth via
additionallyAllowedTenantsto credential options types.What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Yes
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists