[monitor-ingestion] Re-record tests to fix CI #23320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
| let recordedClient: RecorderAndLogsClient; | ||
| let client: LogsIngestionClient; | ||
| beforeEach(async function (this: Context) { | ||
| if (isPlaybackMode() && isNode) this.skip(); |
Member
There was a problem hiding this comment.
do we want to enable these in node and playback?
Member
Author
There was a problem hiding this comment.
Yes we do! The recent test proxy fix solved the cross-OS issue, since it unzips the request body before matching.
Collaborator
|
API change check API changes are not detected in this pull request. |
KarishmaGhiya
approved these changes
Sep 26, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
@azure/monitor-ingestionDescribe the problem that is addressed by this PR
Fixes CI tests which were failing, most likely as a result of test proxy issue Azure/azure-sdk-tools#4169. The fix allows us to unskip the Node recorded tests as well, which is a bonus.